From cca8d0b26549b5f3813178443a3a600aef104181 Mon Sep 17 00:00:00 2001 From: Toma Tabacu Date: Fri, 23 Dec 2016 09:52:43 +0000 Subject: [PATCH] MIPS: Cleanup the forcing of assembly output in error tests. gcc/testsuite * gcc.target/mips/oddspreg-2.c (dg-options): Remove dg-skip-if for -fno-fat-lto-objects and add the -ffat-lto-objects option, along with an explanation for its purpose. * gcc.target/mips/oddspreg-3.c (dg-options): Likewise. * gcc.target/mips/oddspreg-6.c (dg-options): Likewise. * gcc.target/mips/no-dsp-1.c: Add an explanation for the purpose of -ffat-lto-objects. * gcc.target/mips/pr54240.c: Likewise. * gcc.target/mips/r10k-cache-barrier-14.c: Likewise. * gcc.target/mips/soft-float-1.c: Likewise. From-SVN: r243908 --- gcc/testsuite/ChangeLog | 13 +++++++++++++ gcc/testsuite/gcc.target/mips/no-dsp-1.c | 3 +++ gcc/testsuite/gcc.target/mips/oddspreg-2.c | 6 ++++-- gcc/testsuite/gcc.target/mips/oddspreg-3.c | 6 ++++-- gcc/testsuite/gcc.target/mips/oddspreg-6.c | 6 ++++-- gcc/testsuite/gcc.target/mips/pr54240.c | 3 +++ .../gcc.target/mips/r10k-cache-barrier-14.c | 3 +++ gcc/testsuite/gcc.target/mips/soft-float-1.c | 3 +++ 8 files changed, 37 insertions(+), 6 deletions(-) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index c8b5544eb2c..f208f08c575 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,16 @@ +2016-12-23 Toma Tabacu + + * gcc.target/mips/oddspreg-2.c (dg-options): Remove dg-skip-if for + -fno-fat-lto-objects and add the -ffat-lto-objects option, along with + an explanation for its purpose. + * gcc.target/mips/oddspreg-3.c (dg-options): Likewise. + * gcc.target/mips/oddspreg-6.c (dg-options): Likewise. + * gcc.target/mips/no-dsp-1.c: Add an explanation for the purpose of + -ffat-lto-objects. + * gcc.target/mips/pr54240.c: Likewise. + * gcc.target/mips/r10k-cache-barrier-14.c: Likewise. + * gcc.target/mips/soft-float-1.c: Likewise. + 2016-12-22 Prathamesh Kulkarni * gcc.dg/gimplefe-20.c: New test-case. diff --git a/gcc/testsuite/gcc.target/mips/no-dsp-1.c b/gcc/testsuite/gcc.target/mips/no-dsp-1.c index c4a7b0aede2..f03f2393777 100644 --- a/gcc/testsuite/gcc.target/mips/no-dsp-1.c +++ b/gcc/testsuite/gcc.target/mips/no-dsp-1.c @@ -1,4 +1,7 @@ /* { dg-options "-mno-dsp -ffat-lto-objects" } */ +/* This is testing for errors which can only happen in assembly generation. + dg-error does not guarantee assembly generation, so we need to do it + manually by using -ffat-lto-objects. */ void foo (void) diff --git a/gcc/testsuite/gcc.target/mips/oddspreg-2.c b/gcc/testsuite/gcc.target/mips/oddspreg-2.c index efeb0af1b0d..1a857377fb6 100644 --- a/gcc/testsuite/gcc.target/mips/oddspreg-2.c +++ b/gcc/testsuite/gcc.target/mips/oddspreg-2.c @@ -1,6 +1,8 @@ /* Check that we disable odd-numbered single precision registers. */ -/* { dg-skip-if "needs asm output" { *-*-* } { "-fno-fat-lto-objects" } { "" } } */ -/* { dg-options "-mabi=32 -mno-odd-spreg -mhard-float" } */ +/* { dg-options "-mabi=32 -mno-odd-spreg -mhard-float -ffat-lto-objects" } */ +/* This is testing for errors which can only happen in assembly generation. + dg-error does not guarantee assembly generation, so we need to do it + manually by using -ffat-lto-objects. */ NOMIPS16 void foo () diff --git a/gcc/testsuite/gcc.target/mips/oddspreg-3.c b/gcc/testsuite/gcc.target/mips/oddspreg-3.c index 8a0d85cc7cd..16a2f03e0ff 100644 --- a/gcc/testsuite/gcc.target/mips/oddspreg-3.c +++ b/gcc/testsuite/gcc.target/mips/oddspreg-3.c @@ -1,6 +1,8 @@ /* Check that we disable odd-numbered single precision registers. */ -/* { dg-skip-if "needs asm output" { *-*-* } { "-fno-fat-lto-objects" } { "" } } */ -/* { dg-options "-mabi=32 -mfp32 -march=loongson3a -mhard-float" } */ +/* { dg-options "-mabi=32 -mfp32 -march=loongson3a -mhard-float -ffat-lto-objects" } */ +/* This is testing for errors which can only happen in assembly generation. + dg-error does not guarantee assembly generation, so we need to do it + manually by using -ffat-lto-objects. */ NOMIPS16 void foo () diff --git a/gcc/testsuite/gcc.target/mips/oddspreg-6.c b/gcc/testsuite/gcc.target/mips/oddspreg-6.c index eb376c6b330..53ac07698ff 100644 --- a/gcc/testsuite/gcc.target/mips/oddspreg-6.c +++ b/gcc/testsuite/gcc.target/mips/oddspreg-6.c @@ -1,6 +1,8 @@ /* Check that we disable odd-numbered single precision registers for FPXX. */ -/* { dg-skip-if "needs asm output" { *-*-* } { "-fno-fat-lto-objects" } { "" } } */ -/* { dg-options "-mabi=32 -mfpxx -mhard-float" } */ +/* { dg-options "-mabi=32 -mfpxx -mhard-float -ffat-lto-objects" } */ +/* This is testing for errors which can only happen in assembly generation. + dg-error does not guarantee assembly generation, so we need to do it + manually by using -ffat-lto-objects. */ NOMIPS16 void foo () diff --git a/gcc/testsuite/gcc.target/mips/pr54240.c b/gcc/testsuite/gcc.target/mips/pr54240.c index 2d55b822344..d3976f6cfef 100644 --- a/gcc/testsuite/gcc.target/mips/pr54240.c +++ b/gcc/testsuite/gcc.target/mips/pr54240.c @@ -1,6 +1,9 @@ /* { dg-do compile } */ /* { dg-options "-fdump-tree-phiopt-details -ffat-lto-objects isa>=4" } */ /* { dg-skip-if "code quality test" { *-*-* } { "-O0" "-O1" } { "" } } */ +/* This is testing for errors which can only happen in assembly generation. + dg-error does not guarantee assembly generation, so we need to do it + manually by using -ffat-lto-objects. */ typedef struct s { int v; diff --git a/gcc/testsuite/gcc.target/mips/r10k-cache-barrier-14.c b/gcc/testsuite/gcc.target/mips/r10k-cache-barrier-14.c index 92c37f497c6..ecb4158ce3b 100644 --- a/gcc/testsuite/gcc.target/mips/r10k-cache-barrier-14.c +++ b/gcc/testsuite/gcc.target/mips/r10k-cache-barrier-14.c @@ -1,5 +1,8 @@ /* { dg-options "(-mips16) -mr10k-cache-barrier=store -ffat-lto-objects" } */ /* Test that indirect calls are protected. */ +/* This is testing for errors which can only happen in assembly generation. + dg-error does not guarantee assembly generation, so we need to do it + manually by using -ffat-lto-objects. */ MIPS16 void foo (void) { } /* { dg-message "sorry, unimplemented" } */ diff --git a/gcc/testsuite/gcc.target/mips/soft-float-1.c b/gcc/testsuite/gcc.target/mips/soft-float-1.c index 855ff8eadda..e6db3e2ddf6 100644 --- a/gcc/testsuite/gcc.target/mips/soft-float-1.c +++ b/gcc/testsuite/gcc.target/mips/soft-float-1.c @@ -1,4 +1,7 @@ /* { dg-options "-msoft-float -ffat-lto-objects" } */ +/* This is testing for errors which can only happen in assembly generation. + dg-error does not guarantee assembly generation, so we need to do it + manually by using -ffat-lto-objects. */ void foo (void) -- 2.30.2