From cdecdcc4f585e4fd80eccd42f8ae8a8334702dc1 Mon Sep 17 00:00:00 2001 From: Jeff Law Date: Thu, 23 Oct 1997 22:42:07 +0000 Subject: [PATCH] * dbxread.c (process_one_symbol): Put back initialization of a variable lost during last change. Don't perform assignment inside conditionals. * stabsread.c (symbol_reference_defined): Return -1 for error/not found. All callers changed appropriately. (define_symbol): Don't perform assignment inside conditionals. --- gdb/ChangeLog | 9 +++++++++ gdb/stabsread.c | 7 ++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index cca3e6a44b7..fdfffcd1002 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,12 @@ +Thu Oct 23 16:16:04 1997 Jeff Law (law@fast.cs.utah.edu) + + * dbxread.c (process_one_symbol): Put back initialization + of a variable lost during last change. Don't perform + assignment inside conditionals. + * stabsread.c (symbol_reference_defined): Return -1 for error/not + found. All callers changed appropriately. + (define_symbol): Don't perform assignment inside conditionals. + Wed Oct 22 13:04:52 1997 Jeffrey A Law (law@cygnus.com) * mdebugread.c (psymtab_to_symtab_1): Handle new live range stabs diff --git a/gdb/stabsread.c b/gdb/stabsread.c index 872e07e456b..62c3359c15c 100644 --- a/gdb/stabsread.c +++ b/gdb/stabsread.c @@ -1276,7 +1276,7 @@ symbol_reference_defined (string) /* Must be a reference. Either the symbol has already been defined, or this is a forward reference to it. */ *string = p; - return 0; + return -1; } } @@ -1393,7 +1393,8 @@ define_symbol (valu, string, desc, type, objfile) defined symbol, so add it to the alias list of the previously defined symbol. */ s = string; - if (refnum = symbol_reference_defined (&s), refnum) + refnum = symbol_reference_defined (&s); + if (refnum >= 0) ref_add (refnum, sym, string, SYMBOL_VALUE (sym)); else resolve_symbol_reference (objfile, sym, string); @@ -1401,7 +1402,7 @@ define_symbol (valu, string, desc, type, objfile) /* S..P contains the name of the symbol. We need to store the correct name into SYMBOL_NAME. */ nlen = p - s; - if (refnum) + if (refnum >= 0) { if (nlen > 0) { -- 2.30.2