From ced327ec64d37211ff77f17aac2338f26c82c67f Mon Sep 17 00:00:00 2001 From: Francisco Jerez Date: Fri, 20 Sep 2013 16:33:55 -0700 Subject: [PATCH] i965: Switch fs_inst to the non-zeroing allocator. All member variables of fs_inst are already being initialized from its constructor, it's not necessary to use rzalloc to allocate its memory, and doing so makes it more likely that we will start relying on the allocator to zero out all memory if the class is ever extended with new member variables. That's bad because it ties objects to some specific allocation scheme, and gives unpredictable results when an object is created with a different allocator -- Stack allocation, array allocation, or aggregation inside a different object are some of the useful possibilities that come to my mind. Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index 8d351126085..6d93132cd05 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.h +++ b/src/mesa/drivers/dri/i965/brw_fs.h @@ -124,7 +124,7 @@ public: class fs_inst : public backend_instruction { public: - DECLARE_RZALLOC_CXX_OPERATORS(fs_inst) + DECLARE_RALLOC_CXX_OPERATORS(fs_inst) void init(); -- 2.30.2