From ced3f397be6d68ba9a838ee7e3f27c456238501a Mon Sep 17 00:00:00 2001 From: Nathan Sidwell Date: Wed, 8 Sep 2004 07:47:45 +0000 Subject: [PATCH] dbxout.c (dbxout_type, [...]): Use gcc_assert and gcc_unreachable. * dbxout.c (dbxout_type, dbxout_type_name, dbxout_symbol): Use gcc_assert and gcc_unreachable. * ddg.c (create_ddg_dependence, add_deps_for_def, add_deps_for_use, create_ddg, add_edge_to_ddg): Likewise. * df.c (df_ref_unlink, df_ref_record, df_uses_record, df_reg_def_chain_create, df_reg_use_chain_create, df_analyze, df_insn_delete, df_refs_reg_replace, df_ref_reg_replace, df_insns_modify, df_pattern_emit_before, df_bb_reg_live_start_p, df_bb_reg_live_end_p, df_bb_regs_lives_compare, df_bb_single_def_use_insn_find, dataflow_set_a_op_b, dataflow_set_copy, hybrid_search, diagnostic.c, diagnostic_build_prefix, diagnostic_count_diagnostic): Likewise. * dojump.c (do_jump): Likewise. * dominance.c (calc_dfs_tree_nonrec, calc_dfs_tree, compute_dom_fast_query, calculate_dominance_info, free_dominance_info, get_immediate_dominator, set_immediate_dominator, get_dominated_by, redirect_immediate_dominators, nearest_common_dominator, dominated_by_p, verify_dominators, recount_dominator, iterate_fix_dominators, add_to_dominance_info, delete_from_dominance_info): Likewise. * dwarf2asm.c (size_of_encoded_value, eh_data_format_name, dw2_asm_output_delta_uleb128, dw2_asm_output_delta_sleb128, dw2_force_const_mem, dw2_asm_output_encoded_addr_rtx): Likewise. * dwarf2out.c (expand_builtin_init_dwarf_reg_sizes, reg_save, initial_return_save, stack_adjust_offset, dwarf2out_stack_adjust, flush_queued_reg_saves, dwarf2out_frame_debug_expr, dwarf2out_frame_debug, dw_cfi_oprnd1_desc, output_cfi, output_call_frame_info, output_loc_operands, build_cfa_loc, decl_ultimate_origin, AT_flag, AT_int, AT_unsigned, AT_string, AT_string_form, add_AT_specification, AT_ref, set_AT_ref_external, AT_loc, AT_loc_list, AT_addr, AT_lbl, add_child_die, splice_child_die, attr_checksum, same_dw_val_p, break_out_includes, build_abbrev_table, size_of_die, mark_dies, unmark_dies, value_format, output_loc_list, output_die, output_pubnames, output_aranges, base_type_die, is_base_type, modified_type_die, dbx_reg_number, multiple_reg_loc_descriptor, mem_loc_descriptor, loc_descriptor, loc_descriptor_from_tree_1, field_byte_offset, add_data_member_location_attribute, add_const_value_attribute, rtl_for_decl_location, add_location_or_const_value_attribute, add_byte_size_attribute, add_bit_offset_attribute, add_bit_size_attribute, add_abstract_origin_attribute, pop_decl_scope, scope_die_for, decl_start_label, gen_formal_parameter_die, gen_type_die_for_member, gen_subprogram_die, gen_label_die, gen_typedef_die, gen_type_die, gen_tagged_type_instantiation_die, force_decl_die, force_type_die, gen_decl_die, dwarf2out_imported_module_or_decl, prune_unused_types_prune, dwarf2out_finish): Likewise. From-SVN: r87176 --- gcc/ChangeLog | 54 ++++- gcc/dbxout.c | 29 ++- gcc/ddg.c | 26 +- gcc/df.c | 96 +++----- gcc/diagnostic.c | 6 +- gcc/dojump.c | 28 ++- gcc/dominance.c | 58 ++--- gcc/dwarf2asm.c | 21 +- gcc/dwarf2out.c | 617 ++++++++++++++++++++--------------------------- 9 files changed, 426 insertions(+), 509 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 7d422280875..c9de7f7ce87 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,55 @@ +2004-09-08 Nathan Sidwell + + * dbxout.c (dbxout_type, dbxout_type_name, dbxout_symbol): Use + gcc_assert and gcc_unreachable. + * ddg.c (create_ddg_dependence, add_deps_for_def, + add_deps_for_use, create_ddg, add_edge_to_ddg): Likewise. + * df.c (df_ref_unlink, df_ref_record, df_uses_record, + df_reg_def_chain_create, df_reg_use_chain_create, df_analyze, + df_insn_delete, df_refs_reg_replace, df_ref_reg_replace, + df_insns_modify, df_pattern_emit_before, df_bb_reg_live_start_p, + df_bb_reg_live_end_p, df_bb_regs_lives_compare, + df_bb_single_def_use_insn_find, dataflow_set_a_op_b, + dataflow_set_copy, hybrid_search, diagnostic.c, + diagnostic_build_prefix, diagnostic_count_diagnostic): Likewise. + * dojump.c (do_jump): Likewise. + * dominance.c (calc_dfs_tree_nonrec, calc_dfs_tree, + compute_dom_fast_query, calculate_dominance_info, + free_dominance_info, get_immediate_dominator, + set_immediate_dominator, get_dominated_by, + redirect_immediate_dominators, nearest_common_dominator, + dominated_by_p, verify_dominators, recount_dominator, + iterate_fix_dominators, add_to_dominance_info, + delete_from_dominance_info): Likewise. + * dwarf2asm.c (size_of_encoded_value, eh_data_format_name, + dw2_asm_output_delta_uleb128, dw2_asm_output_delta_sleb128, + dw2_force_const_mem, dw2_asm_output_encoded_addr_rtx): Likewise. + * dwarf2out.c (expand_builtin_init_dwarf_reg_sizes, reg_save, + initial_return_save, stack_adjust_offset, dwarf2out_stack_adjust, + flush_queued_reg_saves, dwarf2out_frame_debug_expr, + dwarf2out_frame_debug, dw_cfi_oprnd1_desc, output_cfi, + output_call_frame_info, output_loc_operands, build_cfa_loc, + decl_ultimate_origin, AT_flag, AT_int, AT_unsigned, AT_string, + AT_string_form, add_AT_specification, AT_ref, set_AT_ref_external, + AT_loc, AT_loc_list, AT_addr, AT_lbl, add_child_die, + splice_child_die, attr_checksum, same_dw_val_p, + break_out_includes, build_abbrev_table, size_of_die, mark_dies, + unmark_dies, value_format, output_loc_list, output_die, + output_pubnames, output_aranges, base_type_die, is_base_type, + modified_type_die, dbx_reg_number, multiple_reg_loc_descriptor, + mem_loc_descriptor, loc_descriptor, loc_descriptor_from_tree_1, + field_byte_offset, add_data_member_location_attribute, + add_const_value_attribute, rtl_for_decl_location, + add_location_or_const_value_attribute, add_byte_size_attribute, + add_bit_offset_attribute, add_bit_size_attribute, + add_abstract_origin_attribute, pop_decl_scope, scope_die_for, + decl_start_label, gen_formal_parameter_die, + gen_type_die_for_member, gen_subprogram_die, gen_label_die, + gen_typedef_die, gen_type_die, gen_tagged_type_instantiation_die, + force_decl_die, force_type_die, gen_decl_die, + dwarf2out_imported_module_or_decl, prune_unused_types_prune, + dwarf2out_finish): Likewise. + 2004-09-08 Andreas Tobler * Makefile.in (builtins.o): Depend on tree-mudflap.h. @@ -6014,7 +6066,7 @@ * config/i386/xmmintrin.h: Include . 2004-08-03 H.J. Lu - Tanguy Fautrà + Tanguy Fautrà * config/i386/pmm_malloc.h: New file. diff --git a/gcc/dbxout.c b/gcc/dbxout.c index f6948a0bd72..110ed6b3543 100644 --- a/gcc/dbxout.c +++ b/gcc/dbxout.c @@ -1683,8 +1683,7 @@ dbxout_type (tree type, int full) /* We shouldn't be outputting a reference to a type before its definition unless the type has a tag name. A typedef name without a tag name should be impossible. */ - if (TREE_CODE (TYPE_NAME (type)) != IDENTIFIER_NODE) - abort (); + gcc_assert (TREE_CODE (TYPE_NAME (type)) == IDENTIFIER_NODE); #endif if (TYPE_NAME (type) != 0) dbxout_type_name (type); @@ -1919,7 +1918,7 @@ dbxout_type (tree type, int full) break; default: - abort (); + gcc_unreachable (); } } @@ -2040,19 +2039,19 @@ print_wide_int (HOST_WIDE_INT c) static void dbxout_type_name (tree type) { - tree t; - if (TYPE_NAME (type) == 0) - abort (); - if (TREE_CODE (TYPE_NAME (type)) == IDENTIFIER_NODE) - { - t = TYPE_NAME (type); - } - else if (TREE_CODE (TYPE_NAME (type)) == TYPE_DECL) + tree t = TYPE_NAME (type); + + gcc_assert (t); + switch (TREE_CODE (t)) { - t = DECL_NAME (TYPE_NAME (type)); + case IDENTIFIER_NODE: + break; + case TYPE_DECL: + t = DECL_NAME (t); + break; + default: + gcc_unreachable (); } - else - abort (); fprintf (asmfile, "%s", IDENTIFIER_POINTER (t)); CHARS (IDENTIFIER_LENGTH (t)); @@ -2386,7 +2385,7 @@ dbxout_symbol (tree decl, int local ATTRIBUTE_UNUSED) case PARM_DECL: /* Parm decls go in their own separate chains and are output by dbxout_reg_parms and dbxout_parms. */ - abort (); + gcc_unreachable (); case RESULT_DECL: /* Named return value, treat like a VAR_DECL. */ diff --git a/gcc/ddg.c b/gcc/ddg.c index 34a5971b5a6..3cd9c6b78f5 100644 --- a/gcc/ddg.c +++ b/gcc/ddg.c @@ -164,8 +164,7 @@ create_ddg_dependence (ddg_ptr g, ddg_node_ptr src_node, if (interloop) distance = 1; - if (!link) - abort (); + gcc_assert (link); /* Note: REG_DEP_ANTI applies to MEM ANTI_DEP as well!! */ if (REG_NOTE_KIND (link) == REG_DEP_ANTI) @@ -240,8 +239,7 @@ add_deps_for_def (ddg_ptr g, struct df *df, struct ref *rd) rtx use_insn = DF_REF_INSN (r_use->ref); ddg_node_ptr dest_node = get_node_of_insn (g, use_insn); - if (!src_node || !dest_node) - abort (); + gcc_assert (src_node && dest_node); /* Any such upwards exposed use appears before the rd def. */ use_before_def = true; @@ -296,8 +294,7 @@ add_deps_for_use (ddg_ptr g, struct df *df, struct ref *use) use_node = get_node_of_insn (g, use->insn); def_node = get_node_of_insn (g, first_def->insn); - if (!use_node || !def_node) - abort (); + gcc_assert (use_node && def_node); /* Make sure there are no defs after USE. */ for (i = use_node->cuid + 1; i < g->num_nodes; i++) @@ -484,10 +481,8 @@ create_ddg (basic_block bb, struct df *df, int closing_branch_deps) } if (JUMP_P (insn)) { - if (g->closing_branch) - abort (); /* Found two branches in DDG. */ - else - g->closing_branch = &g->nodes[i]; + gcc_assert (!g->closing_branch); + g->closing_branch = &g->nodes[i]; } else if (GET_CODE (PATTERN (insn)) == USE) { @@ -505,9 +500,10 @@ create_ddg (basic_block bb, struct df *df, int closing_branch_deps) g->nodes[i++].insn = insn; first_note = NULL_RTX; } - - if (!g->closing_branch) - abort (); /* Found no branch in DDG. */ + + /* We must have found a branch in DDG. */ + gcc_assert (g->closing_branch); + /* Build the data dependency graph. */ build_intra_loop_deps (g); @@ -646,8 +642,8 @@ add_edge_to_ddg (ddg_ptr g ATTRIBUTE_UNUSED, ddg_edge_ptr e) ddg_node_ptr src = e->src; ddg_node_ptr dest = e->dest; - if (!src->successors || !dest->predecessors) - abort (); /* Should have allocated the sbitmaps. */ + /* Should have allocated the sbitmaps. */ + gcc_assert (src->successors && dest->predecessors); SET_BIT (src->successors, dest->cuid); SET_BIT (dest->predecessors, src->cuid); diff --git a/gcc/df.c b/gcc/df.c index cf3889dc0b0..f4173c6ac81 100644 --- a/gcc/df.c +++ b/gcc/df.c @@ -648,8 +648,8 @@ df_ref_unlink (struct df_link **phead, struct ref *ref) /* Only a single ref. It must be the one we want. If not, the def-use and use-def chains are likely to be inconsistent. */ - if (link->ref != ref) - abort (); + gcc_assert (link->ref == ref); + /* Now have an empty chain. */ *phead = NULL; } @@ -808,8 +808,7 @@ df_ref_record (struct df *df, rtx reg, rtx *loc, rtx insn, { unsigned int regno; - if (!REG_P (reg) && GET_CODE (reg) != SUBREG) - abort (); + gcc_assert (REG_P (reg) || GET_CODE (reg) == SUBREG); /* For the reg allocator we are interested in some SUBREG rtx's, but not all. Notably only those representing a word extraction from a multi-word @@ -1040,10 +1039,10 @@ df_uses_record (struct df *df, rtx *loc, enum df_ref_type ref_type, bb, insn, 0); break; case STRICT_LOW_PART: - /* A strict_low_part uses the whole REG and not just the SUBREG. */ + /* A strict_low_part uses the whole REG and not just the + SUBREG. */ dst = XEXP (dst, 0); - if (GET_CODE (dst) != SUBREG) - abort (); + gcc_assert (GET_CODE (dst) == SUBREG); df_uses_record (df, &SUBREG_REG (dst), DF_REF_REG_USE, bb, insn, DF_REF_READ_WRITE); break; @@ -1056,7 +1055,7 @@ df_uses_record (struct df *df, rtx *loc, enum df_ref_type ref_type, dst = XEXP (dst, 0); break; default: - abort (); + gcc_unreachable (); } return; } @@ -1311,8 +1310,7 @@ df_reg_def_chain_create (struct df *df, bitmap blocks, bool redo) { #ifdef ENABLE_CHECKING for (regno = 0; regno < df->n_regs; regno++) - if (df->regs[regno].defs) - abort (); + gcc_assert (!df->regs[regno].defs); #endif /* Pretend that all defs are new. */ @@ -1393,8 +1391,7 @@ df_reg_use_chain_create (struct df *df, bitmap blocks, bool redo) { #ifdef ENABLE_CHECKING for (regno = 0; regno < df->n_regs; regno++) - if (df->regs[regno].uses) - abort (); + gcc_assert (!df->regs[regno].uses); #endif /* Pretend that all uses are new. */ @@ -2298,8 +2295,7 @@ df_analyze (struct df *df, bitmap blocks, int flags) /* We could deal with additional basic blocks being created by rescanning everything again. */ - if (df->n_bbs && df->n_bbs != (unsigned int) last_basic_block) - abort (); + gcc_assert (!df->n_bbs || df->n_bbs == (unsigned int) last_basic_block); update = df_modified_p (df, blocks); if (update || (flags != df->flags)) @@ -2321,8 +2317,7 @@ df_analyze (struct df *df, bitmap blocks, int flags) if (blocks == (bitmap) -1) blocks = df->bbs_modified; - if (! df->n_bbs) - abort (); + gcc_assert (df->n_bbs); df_analyze_1 (df, blocks, flags, 1); bitmap_zero (df->bbs_modified); @@ -2631,8 +2626,7 @@ df_insn_delete (struct df *df, basic_block bb ATTRIBUTE_UNUSED, rtx insn) handle the JUMP_LABEL? */ /* We should not be deleting the NOTE_INSN_BASIC_BLOCK or label. */ - if (insn == BB_HEAD (bb)) - abort (); + gcc_assert (insn != BB_HEAD (bb)); /* Delete the insn. */ delete_insn (insn); @@ -2796,24 +2790,17 @@ df_refs_reg_replace (struct df *df, bitmap blocks, struct df_link *chain, rtx ol if (! INSN_P (insn)) continue; - if (bitmap_bit_p (blocks, DF_REF_BBNO (ref))) - { - df_ref_reg_replace (df, ref, oldreg, newreg); + gcc_assert (bitmap_bit_p (blocks, DF_REF_BBNO (ref))); + + df_ref_reg_replace (df, ref, oldreg, newreg); - /* Replace occurrences of the reg within the REG_NOTES. */ - if ((! link->next || DF_REF_INSN (ref) - != DF_REF_INSN (link->next->ref)) - && REG_NOTES (insn)) - { - args.insn = insn; - for_each_rtx (®_NOTES (insn), df_rtx_reg_replace, &args); - } - } - else + /* Replace occurrences of the reg within the REG_NOTES. */ + if ((! link->next || DF_REF_INSN (ref) + != DF_REF_INSN (link->next->ref)) + && REG_NOTES (insn)) { - /* Temporary check to ensure that we have a grip on which - regs should be replaced. */ - abort (); + args.insn = insn; + for_each_rtx (®_NOTES (insn), df_rtx_reg_replace, &args); } } } @@ -2844,8 +2831,7 @@ df_ref_reg_replace (struct df *df, struct ref *ref, rtx oldreg, rtx newreg) if (! INSN_P (DF_REF_INSN (ref))) return 0; - if (oldreg && oldreg != DF_REF_REG (ref)) - abort (); + gcc_assert (!oldreg || oldreg == DF_REF_REG (ref)); if (! validate_change (DF_REF_INSN (ref), DF_REF_LOC (ref), newreg, 1)) return 0; @@ -2911,10 +2897,8 @@ df_insns_modify (struct df *df, basic_block bb, rtx first_insn, rtx last_insn) /* A non-const call should not have slipped through the net. If it does, we need to create a new basic block. Ouch. The same applies for a label. */ - if ((CALL_P (insn) - && ! CONST_OR_PURE_CALL_P (insn)) - || LABEL_P (insn)) - abort (); + gcc_assert ((!CALL_P (insn) || CONST_OR_PURE_CALL_P (insn)) + && !LABEL_P (insn)); uid = INSN_UID (insn); @@ -2937,8 +2921,7 @@ df_pattern_emit_before (struct df *df, rtx pattern, basic_block bb, rtx insn) rtx prev_insn = PREV_INSN (insn); /* We should not be inserting before the start of the block. */ - if (insn == BB_HEAD (bb)) - abort (); + gcc_assert (insn != BB_HEAD (bb)); ret_insn = emit_insn_before (pattern, insn); if (ret_insn == insn) return ret_insn; @@ -3196,10 +3179,7 @@ df_bb_reg_live_start_p (struct df *df, basic_block bb, rtx reg) { struct bb_info *bb_info = DF_BB_INFO (df, bb); -#ifdef ENABLE_CHECKING - if (! bb_info->lr_in) - abort (); -#endif + gcc_assert (bb_info->lr_in); return bitmap_bit_p (bb_info->lr_in, REGNO (reg)); } @@ -3211,10 +3191,7 @@ df_bb_reg_live_end_p (struct df *df, basic_block bb, rtx reg) { struct bb_info *bb_info = DF_BB_INFO (df, bb); -#ifdef ENABLE_CHECKING - if (! bb_info->lr_in) - abort (); -#endif + gcc_assert (bb_info->lr_in); return bitmap_bit_p (bb_info->lr_out, REGNO (reg)); } @@ -3234,9 +3211,8 @@ df_bb_regs_lives_compare (struct df *df, basic_block bb, rtx reg1, rtx reg2) /* The regs must be local to BB. */ - if (df_regno_bb (df, regno1) != bb - || df_regno_bb (df, regno2) != bb) - abort (); + gcc_assert (df_regno_bb (df, regno1) == bb + && df_regno_bb (df, regno2) == bb); def2 = df_bb_regno_first_def_find (df, bb, regno2); use1 = df_bb_regno_last_use_find (df, bb, regno1); @@ -3380,8 +3356,7 @@ df_bb_single_def_use_insn_find (struct df *df, basic_block bb, rtx insn, rtx reg def = df_bb_insn_regno_first_def_find (df, bb, insn, REGNO (reg)); - if (! def) - abort (); + gcc_assert (def); du_link = DF_REF_CHAIN (def); @@ -3761,7 +3736,7 @@ dataflow_set_a_op_b (enum set_representation repr, break; default: - abort (); + gcc_unreachable (); } break; @@ -3777,12 +3752,12 @@ dataflow_set_a_op_b (enum set_representation repr, break; default: - abort (); + gcc_unreachable (); } break; default: - abort (); + gcc_unreachable (); } } @@ -3800,7 +3775,7 @@ dataflow_set_copy (enum set_representation repr, void *dest, void *src) break; default: - abort (); + gcc_unreachable (); } } @@ -3816,8 +3791,7 @@ hybrid_search (basic_block bb, struct dataflow *dataflow, edge e; SET_BIT (visited, bb->index); - if (!TEST_BIT (pending, bb->index)) - abort (); + gcc_assert (TEST_BIT (pending, bb->index)); RESET_BIT (pending, i); #define HS(E_ANTI, E_ANTI_NEXT, E_ANTI_BB, E_ANTI_START_BB, IN_SET, \ diff --git a/gcc/diagnostic.c b/gcc/diagnostic.c index 4fca486d941..d6b6ea724a2 100644 --- a/gcc/diagnostic.c +++ b/gcc/diagnostic.c @@ -174,8 +174,7 @@ diagnostic_build_prefix (diagnostic_info *diagnostic) "must-not-happen" }; expanded_location s = expand_location (diagnostic->location); - if (diagnostic->kind >= DK_LAST_DIAGNOSTIC_KIND) - abort(); + gcc_assert (diagnostic->kind < DK_LAST_DIAGNOSTIC_KIND); return s.file ? build_message_string ("%s:%d: %s", @@ -194,8 +193,7 @@ diagnostic_count_diagnostic (diagnostic_context *context, switch (kind) { default: - abort(); - break; + gcc_unreachable (); case DK_ICE: #ifndef ENABLE_CHECKING diff --git a/gcc/dojump.c b/gcc/dojump.c index eb4f21c5a52..50fc093f72f 100644 --- a/gcc/dojump.c +++ b/gcc/dojump.c @@ -265,7 +265,7 @@ do_jump (tree exp, rtx if_false_label, rtx if_true_label) case COMPOUND_EXPR: case COND_EXPR: /* Lowered by gimplify.c. */ - abort (); + gcc_unreachable (); case COMPONENT_REF: case BIT_FIELD_REF: @@ -301,10 +301,12 @@ do_jump (tree exp, rtx if_false_label, rtx if_true_label) { tree inner_type = TREE_TYPE (TREE_OPERAND (exp, 0)); - if (GET_MODE_CLASS (TYPE_MODE (inner_type)) == MODE_COMPLEX_FLOAT - || GET_MODE_CLASS (TYPE_MODE (inner_type)) == MODE_COMPLEX_INT) - abort (); - else if (integer_zerop (TREE_OPERAND (exp, 1))) + gcc_assert (GET_MODE_CLASS (TYPE_MODE (inner_type)) + != MODE_COMPLEX_FLOAT); + gcc_assert (GET_MODE_CLASS (TYPE_MODE (inner_type)) + != MODE_COMPLEX_INT); + + if (integer_zerop (TREE_OPERAND (exp, 1))) do_jump (TREE_OPERAND (exp, 0), if_true_label, if_false_label); else if (GET_MODE_CLASS (TYPE_MODE (inner_type)) == MODE_INT && !can_compare_p (EQ, TYPE_MODE (inner_type), ccp_jump)) @@ -318,10 +320,12 @@ do_jump (tree exp, rtx if_false_label, rtx if_true_label) { tree inner_type = TREE_TYPE (TREE_OPERAND (exp, 0)); - if (GET_MODE_CLASS (TYPE_MODE (inner_type)) == MODE_COMPLEX_FLOAT - || GET_MODE_CLASS (TYPE_MODE (inner_type)) == MODE_COMPLEX_INT) - abort (); - else if (integer_zerop (TREE_OPERAND (exp, 1))) + gcc_assert (GET_MODE_CLASS (TYPE_MODE (inner_type)) + != MODE_COMPLEX_FLOAT); + gcc_assert (GET_MODE_CLASS (TYPE_MODE (inner_type)) + != MODE_COMPLEX_INT); + + if (integer_zerop (TREE_OPERAND (exp, 1))) do_jump (TREE_OPERAND (exp, 0), if_false_label, if_true_label); else if (GET_MODE_CLASS (TYPE_MODE (inner_type)) == MODE_INT && !can_compare_p (NE, TYPE_MODE (inner_type), ccp_jump)) @@ -511,8 +515,10 @@ do_jump (tree exp, rtx if_false_label, rtx if_true_label) && ! can_compare_p (NE, GET_MODE (temp), ccp_jump)) /* Note swapping the labels gives us not-equal. */ do_jump_by_parts_equality_rtx (temp, if_true_label, if_false_label); - else if (GET_MODE (temp) != VOIDmode) + else { + gcc_assert (GET_MODE (temp) != VOIDmode); + /* The RTL optimizers prefer comparisons against pseudos. */ if (GET_CODE (temp) == SUBREG) { @@ -528,8 +534,6 @@ do_jump (tree exp, rtx if_false_label, rtx if_true_label) GET_MODE (temp), NULL_RTX, if_false_label, if_true_label); } - else - abort (); } } diff --git a/gcc/dominance.c b/gcc/dominance.c index d46d8f56ecd..5d7f824d1d6 100644 --- a/gcc/dominance.c +++ b/gcc/dominance.c @@ -271,8 +271,7 @@ calc_dfs_tree_nonrec (struct dom_info *di, basic_block bb, e_next = bn->succ; } - if (bn == en_block) - abort (); + gcc_assert (bn != en_block); /* Fill the DFS tree info calculatable _before_ recursing. */ if (bb != en_block) @@ -375,8 +374,7 @@ calc_dfs_tree (struct dom_info *di, enum cdi_direction reverse) di->nodes = di->dfsnum - 1; /* This aborts e.g. when there is _no_ path from ENTRY to EXIT at all. */ - if (di->nodes != (unsigned int) n_basic_blocks + 1) - abort (); + gcc_assert (di->nodes == (unsigned int) n_basic_blocks + 1); } /* Compress the path from V to the root of its set and update path_min at the @@ -597,8 +595,7 @@ compute_dom_fast_query (enum cdi_direction dir) int num = 0; basic_block bb; - if (dom_computed[dir] < DOM_NO_FAST_QUERY) - abort (); + gcc_assert (dom_computed[dir] >= DOM_NO_FAST_QUERY); if (dom_computed[dir] == DOM_OK) return; @@ -629,8 +626,7 @@ calculate_dominance_info (enum cdi_direction dir) if (dom_computed[dir] != DOM_NONE) free_dominance_info (dir); - if (n_bbs_in_dom_tree[dir]) - abort (); + gcc_assert (!n_bbs_in_dom_tree[dir]); FOR_ALL_BB (b) { @@ -672,8 +668,7 @@ free_dominance_info (enum cdi_direction dir) } /* If there are any nodes left, something is wrong. */ - if (n_bbs_in_dom_tree[dir]) - abort (); + gcc_assert (!n_bbs_in_dom_tree[dir]); dom_computed[dir] = DOM_NONE; } @@ -684,8 +679,7 @@ get_immediate_dominator (enum cdi_direction dir, basic_block bb) { struct et_node *node = bb->dom[dir]; - if (!dom_computed[dir]) - abort (); + gcc_assert (dom_computed[dir]); if (!node->father) return NULL; @@ -701,8 +695,7 @@ set_immediate_dominator (enum cdi_direction dir, basic_block bb, { struct et_node *node = bb->dom[dir]; - if (!dom_computed[dir]) - abort (); + gcc_assert (dom_computed[dir]); if (node->father) { @@ -726,8 +719,7 @@ get_dominated_by (enum cdi_direction dir, basic_block bb, basic_block **bbs) int n; struct et_node *node = bb->dom[dir], *son = node->son, *ason; - if (!dom_computed[dir]) - abort (); + gcc_assert (dom_computed[dir]); if (!son) { @@ -753,8 +745,7 @@ redirect_immediate_dominators (enum cdi_direction dir, basic_block bb, { struct et_node *bb_node = bb->dom[dir], *to_node = to->dom[dir], *son; - if (!dom_computed[dir]) - abort (); + gcc_assert (dom_computed[dir]); if (!bb_node->son) return; @@ -775,8 +766,7 @@ redirect_immediate_dominators (enum cdi_direction dir, basic_block bb, basic_block nearest_common_dominator (enum cdi_direction dir, basic_block bb1, basic_block bb2) { - if (!dom_computed[dir]) - abort (); + gcc_assert (dom_computed[dir]); if (!bb1) return bb2; @@ -792,8 +782,7 @@ dominated_by_p (enum cdi_direction dir, basic_block bb1, basic_block bb2) { struct et_node *n1 = bb1->dom[dir], *n2 = bb2->dom[dir]; - if (!dom_computed[dir]) - abort (); + gcc_assert (dom_computed[dir]); if (dom_computed[dir] == DOM_OK) return (n1->dfs_num_in >= n2->dfs_num_in @@ -809,8 +798,7 @@ verify_dominators (enum cdi_direction dir) int err = 0; basic_block bb; - if (!dom_computed[dir]) - abort (); + gcc_assert (dom_computed[dir]); FOR_EACH_BB (bb) { @@ -838,8 +826,7 @@ verify_dominators (enum cdi_direction dir) } } - if (err) - abort (); + gcc_assert (!err); } /* Determine immediate dominator (or postdominator, according to DIR) of BB, @@ -853,8 +840,7 @@ recount_dominator (enum cdi_direction dir, basic_block bb) basic_block dom_bb = NULL; edge e; - if (!dom_computed[dir]) - abort (); + gcc_assert (dom_computed[dir]); if (dir == CDI_DOMINATORS) { @@ -889,8 +875,7 @@ iterate_fix_dominators (enum cdi_direction dir, basic_block *bbs, int n) int i, changed = 1; basic_block old_dom, new_dom; - if (!dom_computed[dir]) - abort (); + gcc_assert (dom_computed[dir]); for (i = 0; i < n; i++) set_immediate_dominator (dir, bbs[i], NULL); @@ -911,18 +896,14 @@ iterate_fix_dominators (enum cdi_direction dir, basic_block *bbs, int n) } for (i = 0; i < n; i++) - if (!get_immediate_dominator (dir, bbs[i])) - abort (); + gcc_assert (get_immediate_dominator (dir, bbs[i])); } void add_to_dominance_info (enum cdi_direction dir, basic_block bb) { - if (!dom_computed[dir]) - abort (); - - if (bb->dom[dir]) - abort (); + gcc_assert (dom_computed[dir]); + gcc_assert (!bb->dom[dir]); n_bbs_in_dom_tree[dir]++; @@ -935,8 +916,7 @@ add_to_dominance_info (enum cdi_direction dir, basic_block bb) void delete_from_dominance_info (enum cdi_direction dir, basic_block bb) { - if (!dom_computed[dir]) - abort (); + gcc_assert (dom_computed[dir]); et_free_tree (bb->dom[dir]); bb->dom[dir] = NULL; diff --git a/gcc/dwarf2asm.c b/gcc/dwarf2asm.c index 10382c972c9..6d2c3cb87e6 100644 --- a/gcc/dwarf2asm.c +++ b/gcc/dwarf2asm.c @@ -333,8 +333,9 @@ size_of_encoded_value (int encoding) return 4; case DW_EH_PE_udata8: return 8; + default: + gcc_unreachable (); } - abort (); } /* Yield a name for a given pointer encoding. */ @@ -486,12 +487,12 @@ eh_data_format_name (int format) #if HAVE_DESIGNATED_INITIALIZERS }; - if (format < 0 || format > 0xff || format_names[format] == NULL) - abort (); + gcc_assert (format >= 0 && format < 0x100 && format_names[format]); + return format_names[format]; #else } - abort (); + gcc_unreachable (); #endif } @@ -635,7 +636,7 @@ dw2_asm_output_delta_uleb128 (const char *lab1 ATTRIBUTE_UNUSED, fputc ('-', asm_out_file); assemble_name (asm_out_file, lab2); #else - abort (); + gcc_unreachable (); #endif if (flag_debug_asm && comment) @@ -663,7 +664,7 @@ dw2_asm_output_delta_sleb128 (const char *lab1 ATTRIBUTE_UNUSED, fputc ('-', asm_out_file); assemble_name (asm_out_file, lab2); #else - abort (); + gcc_unreachable (); #endif if (flag_debug_asm && comment) @@ -704,8 +705,7 @@ dw2_force_const_mem (rtx x) if (! indirect_pool) indirect_pool = splay_tree_new_ggc (splay_tree_compare_pointers); - if (GET_CODE (x) != SYMBOL_REF) - abort (); + gcc_assert (GET_CODE (x) == SYMBOL_REF); str = targetm.strip_name_encoding (XSTR (x, 0)); node = splay_tree_lookup (indirect_pool, (splay_tree_key) str); @@ -836,8 +836,7 @@ dw2_asm_output_encoded_addr_rtx (int encoding, rtx addr, break; case DW_EH_PE_pcrel: - if (GET_CODE (addr) != SYMBOL_REF) - abort (); + gcc_assert (GET_CODE (addr) == SYMBOL_REF); #ifdef ASM_OUTPUT_DWARF_PCREL ASM_OUTPUT_DWARF_PCREL (asm_out_file, size, XSTR (addr, 0)); #else @@ -848,7 +847,7 @@ dw2_asm_output_encoded_addr_rtx (int encoding, rtx addr, default: /* Other encodings should have been handled by ASM_MAYBE_OUTPUT_ENCODED_ADDR_RTX. */ - abort (); + gcc_unreachable (); } #ifdef ASM_MAYBE_OUTPUT_ENCODED_ADDR_RTX diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c index 832a266156b..8b60c26c17a 100644 --- a/gcc/dwarf2out.c +++ b/gcc/dwarf2out.c @@ -489,8 +489,7 @@ expand_builtin_init_dwarf_reg_sizes (tree address) } #ifdef DWARF_ALT_FRAME_RETURN_COLUMN - if (! wrote_return_column) - abort (); + gcc_assert (wrote_return_column); i = DWARF_ALT_FRAME_RETURN_COLUMN; wrote_return_column = false; #else @@ -829,8 +828,7 @@ reg_save (const char *label, unsigned int reg, unsigned int sreg, HOST_WIDE_INT description. */ HOST_WIDE_INT check_offset = offset / DWARF_CIE_DATA_ALIGNMENT; - if (check_offset * DWARF_CIE_DATA_ALIGNMENT != offset) - abort (); + gcc_assert (check_offset * DWARF_CIE_DATA_ALIGNMENT == offset); } #endif offset /= DWARF_CIE_DATA_ALIGNMENT; @@ -934,25 +932,22 @@ initial_return_save (rtx rtl) switch (GET_CODE (rtl)) { case REG: - if (REGNO (rtl) != STACK_POINTER_REGNUM) - abort (); + gcc_assert (REGNO (rtl) == STACK_POINTER_REGNUM); offset = 0; break; case PLUS: - if (REGNO (XEXP (rtl, 0)) != STACK_POINTER_REGNUM) - abort (); + gcc_assert (REGNO (XEXP (rtl, 0)) == STACK_POINTER_REGNUM); offset = INTVAL (XEXP (rtl, 1)); break; case MINUS: - if (REGNO (XEXP (rtl, 0)) != STACK_POINTER_REGNUM) - abort (); + gcc_assert (REGNO (XEXP (rtl, 0)) == STACK_POINTER_REGNUM); offset = -INTVAL (XEXP (rtl, 1)); break; default: - abort (); + gcc_unreachable (); } break; @@ -961,13 +956,12 @@ initial_return_save (rtx rtl) /* The return address is at some offset from any value we can actually load. For instance, on the SPARC it is in %i7+8. Just ignore the offset for now; it doesn't matter for unwinding frames. */ - if (GET_CODE (XEXP (rtl, 1)) != CONST_INT) - abort (); + gcc_assert (GET_CODE (XEXP (rtl, 1)) == CONST_INT); initial_return_save (XEXP (rtl, 0)); return; default: - abort (); + gcc_unreachable (); } if (reg != DWARF_FRAME_RETURN_COLUMN) @@ -1012,9 +1006,8 @@ stack_adjust_offset (rtx pattern) { rtx val = XEXP (XEXP (src, 1), 1); /* We handle only adjustments by constant amount. */ - if (GET_CODE (XEXP (src, 1)) != PLUS || - GET_CODE (val) != CONST_INT) - abort (); + gcc_assert (GET_CODE (XEXP (src, 1)) == PLUS + && GET_CODE (val) == CONST_INT); offset = -INTVAL (val); break; } @@ -1074,8 +1067,7 @@ dwarf2out_stack_adjust (rtx insn) insn = XVECEXP (insn, 0, 0); if (GET_CODE (insn) == SET) insn = SET_SRC (insn); - if (GET_CODE (insn) != CALL) - abort (); + gcc_assert (GET_CODE (insn) == CALL); dwarf2out_args_size ("", INTVAL (XEXP (insn, 1))); return; @@ -1208,8 +1200,7 @@ flush_queued_reg_saves (void) break; if (q->saved_reg && i == num_regs_saved_in_regs) { - if (i == ARRAY_SIZE (regs_saved_in_regs)) - abort (); + gcc_assert (i != ARRAY_SIZE (regs_saved_in_regs)); num_regs_saved_in_regs++; } if (i != num_regs_saved_in_regs) @@ -1466,8 +1457,7 @@ dwarf2out_frame_debug_expr (rtx expr, const char *label) return; } - if (GET_CODE (expr) != SET) - abort (); + gcc_assert (GET_CODE (expr) == SET); src = SET_SRC (expr); dest = SET_DEST (expr); @@ -1500,14 +1490,13 @@ dwarf2out_frame_debug_expr (rtx expr, const char *label) cfa_temp.reg = cfa.reg; cfa_temp.offset = cfa.offset; } - else if (call_used_regs [REGNO (dest)] - && ! fixed_regs [REGNO (dest)]) + else { /* Saving a register in a register. */ + gcc_assert (call_used_regs [REGNO (dest)] + && !fixed_regs [REGNO (dest)]); queue_reg_save (label, src, dest, 0); } - else - abort (); break; case PLUS: @@ -1523,26 +1512,25 @@ dwarf2out_frame_debug_expr (rtx expr, const char *label) offset = INTVAL (XEXP (src, 1)); break; case REG: - if ((unsigned) REGNO (XEXP (src, 1)) != cfa_temp.reg) - abort (); + gcc_assert ((unsigned) REGNO (XEXP (src, 1)) + == cfa_temp.reg); offset = cfa_temp.offset; break; default: - abort (); + gcc_unreachable (); } if (XEXP (src, 0) == hard_frame_pointer_rtx) { /* Restoring SP from FP in the epilogue. */ - if (cfa.reg != (unsigned) HARD_FRAME_POINTER_REGNUM) - abort (); + gcc_assert (cfa.reg == (unsigned) HARD_FRAME_POINTER_REGNUM); cfa.reg = STACK_POINTER_REGNUM; } else if (GET_CODE (src) == LO_SUM) /* Assume we've set the source reg of the LO_SUM from sp. */ ; - else if (XEXP (src, 0) != stack_pointer_rtx) - abort (); + else + gcc_assert (XEXP (src, 0) == stack_pointer_rtx); if (GET_CODE (src) != MINUS) offset = -offset; @@ -1556,26 +1544,20 @@ dwarf2out_frame_debug_expr (rtx expr, const char *label) /* Rule 3 */ /* Either setting the FP from an offset of the SP, or adjusting the FP */ - if (! frame_pointer_needed) - abort (); + gcc_assert (frame_pointer_needed); - if (REG_P (XEXP (src, 0)) - && (unsigned) REGNO (XEXP (src, 0)) == cfa.reg - && GET_CODE (XEXP (src, 1)) == CONST_INT) - { - offset = INTVAL (XEXP (src, 1)); - if (GET_CODE (src) != MINUS) - offset = -offset; - cfa.offset += offset; - cfa.reg = HARD_FRAME_POINTER_REGNUM; - } - else - abort (); + gcc_assert (REG_P (XEXP (src, 0)) + && (unsigned) REGNO (XEXP (src, 0)) == cfa.reg + && GET_CODE (XEXP (src, 1)) == CONST_INT); + offset = INTVAL (XEXP (src, 1)); + if (GET_CODE (src) != MINUS) + offset = -offset; + cfa.offset += offset; + cfa.reg = HARD_FRAME_POINTER_REGNUM; } else { - if (GET_CODE (src) == MINUS) - abort (); + gcc_assert (GET_CODE (src) != MINUS); /* Rule 4 */ if (REG_P (XEXP (src, 0)) @@ -1599,8 +1581,7 @@ dwarf2out_frame_debug_expr (rtx expr, const char *label) { /* Setting a scratch register that we will use instead of SP for saving registers to the stack. */ - if (cfa.reg != STACK_POINTER_REGNUM) - abort (); + gcc_assert (cfa.reg == STACK_POINTER_REGNUM); cfa_store.reg = REGNO (dest); cfa_store.offset = cfa.offset - cfa_temp.offset; } @@ -1613,7 +1594,7 @@ dwarf2out_frame_debug_expr (rtx expr, const char *label) cfa_temp.offset = INTVAL (XEXP (src, 1)); } else - abort (); + gcc_unreachable (); } break; @@ -1625,10 +1606,9 @@ dwarf2out_frame_debug_expr (rtx expr, const char *label) /* Rule 7 */ case IOR: - if (!REG_P (XEXP (src, 0)) - || (unsigned) REGNO (XEXP (src, 0)) != cfa_temp.reg - || GET_CODE (XEXP (src, 1)) != CONST_INT) - abort (); + gcc_assert (REG_P (XEXP (src, 0)) + && (unsigned) REGNO (XEXP (src, 0)) == cfa_temp.reg + && GET_CODE (XEXP (src, 1)) == CONST_INT); if ((unsigned) REGNO (dest) != cfa_temp.reg) cfa_temp.reg = REGNO (dest); @@ -1642,15 +1622,14 @@ dwarf2out_frame_debug_expr (rtx expr, const char *label) break; default: - abort (); + gcc_unreachable (); } def_cfa_1 (label, &cfa); break; case MEM: - if (!REG_P (src)) - abort (); + gcc_assert (REG_P (src)); /* Saving a register to the stack. Make sure dest is relative to the CFA register. */ @@ -1660,13 +1639,12 @@ dwarf2out_frame_debug_expr (rtx expr, const char *label) /* With a push. */ case PRE_MODIFY: /* We can't handle variable size modifications. */ - if (GET_CODE (XEXP (XEXP (XEXP (dest, 0), 1), 1)) != CONST_INT) - abort (); + gcc_assert (GET_CODE (XEXP (XEXP (XEXP (dest, 0), 1), 1)) + == CONST_INT); offset = -INTVAL (XEXP (XEXP (XEXP (dest, 0), 1), 1)); - if (REGNO (XEXP (XEXP (dest, 0), 0)) != STACK_POINTER_REGNUM - || cfa_store.reg != STACK_POINTER_REGNUM) - abort (); + gcc_assert (REGNO (XEXP (XEXP (dest, 0), 0)) == STACK_POINTER_REGNUM + && cfa_store.reg == STACK_POINTER_REGNUM); cfa_store.offset += offset; if (cfa.reg == STACK_POINTER_REGNUM) @@ -1682,9 +1660,8 @@ dwarf2out_frame_debug_expr (rtx expr, const char *label) if (GET_CODE (XEXP (dest, 0)) == PRE_INC) offset = -offset; - if (REGNO (XEXP (XEXP (dest, 0), 0)) != STACK_POINTER_REGNUM - || cfa_store.reg != STACK_POINTER_REGNUM) - abort (); + gcc_assert (REGNO (XEXP (XEXP (dest, 0), 0)) == STACK_POINTER_REGNUM + && cfa_store.reg == STACK_POINTER_REGNUM); cfa_store.offset += offset; if (cfa.reg == STACK_POINTER_REGNUM) @@ -1698,41 +1675,52 @@ dwarf2out_frame_debug_expr (rtx expr, const char *label) case PLUS: case MINUS: case LO_SUM: - if (GET_CODE (XEXP (XEXP (dest, 0), 1)) != CONST_INT) - abort (); - offset = INTVAL (XEXP (XEXP (dest, 0), 1)); - if (GET_CODE (XEXP (dest, 0)) == MINUS) - offset = -offset; - - if (cfa_store.reg == (unsigned) REGNO (XEXP (XEXP (dest, 0), 0))) - offset -= cfa_store.offset; - else if (cfa_temp.reg == (unsigned) REGNO (XEXP (XEXP (dest, 0), 0))) - offset -= cfa_temp.offset; - else - abort (); + { + int regno; + + gcc_assert (GET_CODE (XEXP (XEXP (dest, 0), 1)) == CONST_INT); + offset = INTVAL (XEXP (XEXP (dest, 0), 1)); + if (GET_CODE (XEXP (dest, 0)) == MINUS) + offset = -offset; + + regno = REGNO (XEXP (XEXP (dest, 0), 0)); + + if (cfa_store.reg == (unsigned) regno) + offset -= cfa_store.offset; + else + { + gcc_assert (cfa_temp.reg == (unsigned) regno); + offset -= cfa_temp.offset; + } + } break; /* Rule 13 */ /* Without an offset. */ case REG: - if (cfa_store.reg == (unsigned) REGNO (XEXP (dest, 0))) - offset = -cfa_store.offset; - else if (cfa_temp.reg == (unsigned) REGNO (XEXP (dest, 0))) - offset = -cfa_temp.offset; - else - abort (); + { + int regno = REGNO (XEXP (dest, 0)); + + if (cfa_store.reg == (unsigned) regno) + offset = -cfa_store.offset; + else + { + gcc_assert (cfa_temp.reg == (unsigned) regno); + offset = -cfa_temp.offset; + } + } break; /* Rule 14 */ case POST_INC: - if (cfa_temp.reg != (unsigned) REGNO (XEXP (XEXP (dest, 0), 0))) - abort (); + gcc_assert (cfa_temp.reg + == (unsigned) REGNO (XEXP (XEXP (dest, 0), 0))); offset = -cfa_temp.offset; cfa_temp.offset -= GET_MODE_SIZE (GET_MODE (dest)); break; default: - abort (); + gcc_unreachable (); } if (REGNO (src) != STACK_POINTER_REGNUM @@ -1758,8 +1746,7 @@ dwarf2out_frame_debug_expr (rtx expr, const char *label) if (!REG_P (x)) x = XEXP (x, 0); - if (!REG_P (x)) - abort (); + gcc_assert (REG_P (x)); cfa.reg = REGNO (x); cfa.base_offset = offset; @@ -1774,7 +1761,7 @@ dwarf2out_frame_debug_expr (rtx expr, const char *label) break; default: - abort (); + gcc_unreachable (); } } @@ -1797,8 +1784,8 @@ dwarf2out_frame_debug (rtx insn) /* Set up state for generating call frame debug info. */ lookup_cfa (&cfa); - if (cfa.reg != (unsigned long) DWARF_FRAME_REGNUM (STACK_POINTER_REGNUM)) - abort (); + gcc_assert (cfa.reg + == (unsigned long)DWARF_FRAME_REGNUM (STACK_POINTER_REGNUM)); cfa.reg = STACK_POINTER_REGNUM; cfa_store = cfa; @@ -1879,7 +1866,7 @@ dw_cfi_oprnd1_desc (enum dwarf_call_frame_info cfi) return dw_cfi_oprnd_loc; default: - abort (); + gcc_unreachable (); } } @@ -2030,7 +2017,7 @@ output_cfi (dw_cfi_ref cfi, dw_fde_ref fde, int for_eh) case DW_CFA_GNU_negative_offset_extended: /* Obsoleted by DW_CFA_offset_extended_sf. */ - abort (); + gcc_unreachable (); default: break; @@ -2185,8 +2172,7 @@ output_call_frame_info (int for_eh) /* Augmentations should be small, so there's scarce need to iterate for a solution. Die if we exceed one uleb128 byte. */ - if (size_of_uleb128 (augmentation_size) != 1) - abort (); + gcc_assert (size_of_uleb128 (augmentation_size) == 1); } } @@ -2289,8 +2275,7 @@ output_call_frame_info (int for_eh) int pad = -offset & (PTR_SIZE - 1); size += pad; - if (size_of_uleb128 (size) != 1) - abort (); + gcc_assert (size_of_uleb128 (size) == 1); } dw2_asm_output_data_uleb128 (size, "Augmentation size"); @@ -3089,8 +3074,7 @@ output_loc_operands (dw_loc_descr_ref loc) break; case DW_OP_const8u: case DW_OP_const8s: - if (HOST_BITS_PER_LONG < 64) - abort (); + gcc_assert (HOST_BITS_PER_LONG >= 64); dw2_asm_output_data (8, val1->v.val_int, NULL); break; case DW_OP_skip: @@ -3098,10 +3082,8 @@ output_loc_operands (dw_loc_descr_ref loc) { int offset; - if (val1->val_class == dw_val_class_loc) - offset = val1->v.val_loc->dw_loc_addr - (loc->dw_loc_addr + 3); - else - abort (); + gcc_assert (val1->val_class == dw_val_class_loc); + offset = val1->v.val_loc->dw_loc_addr - (loc->dw_loc_addr + 3); dw2_asm_output_data (2, offset, NULL); } @@ -3120,7 +3102,7 @@ output_loc_operands (dw_loc_descr_ref loc) aligned properly like we do for the main unwind info, so don't support emitting things larger than a byte if we're only doing unwinding. */ - abort (); + gcc_unreachable (); #endif case DW_OP_const1u: case DW_OP_const1s: @@ -3196,7 +3178,7 @@ output_loc_operands (dw_loc_descr_ref loc) val1->v.val_addr); fputc ('\n', asm_out_file); #else - abort (); + gcc_unreachable (); #endif break; @@ -3248,8 +3230,7 @@ build_cfa_loc (dw_cfa_location *cfa) { struct dw_loc_descr_struct *head, *tmp; - if (cfa->indirect == 0) - abort (); + gcc_assert (cfa->indirect); if (cfa->base_offset) { @@ -4585,12 +4566,9 @@ decl_ultimate_origin (tree decl) if (DECL_ABSTRACT (decl) && DECL_ABSTRACT_ORIGIN (decl) == decl) return NULL_TREE; -#ifdef ENABLE_CHECKING - if (DECL_FROM_INLINE (DECL_ORIGIN (decl))) - /* Since the DECL_ABSTRACT_ORIGIN for a DECL is supposed to be the - most distant ancestor, this should never happen. */ - abort (); -#endif + /* Since the DECL_ABSTRACT_ORIGIN for a DECL is supposed to be the + most distant ancestor, this should never happen. */ + gcc_assert (!DECL_FROM_INLINE (DECL_ORIGIN (decl))); return DECL_ABSTRACT_ORIGIN (decl); } @@ -4688,10 +4666,8 @@ add_AT_flag (dw_die_ref die, enum dwarf_attribute attr_kind, unsigned int flag) static inline unsigned AT_flag (dw_attr_ref a) { - if (a && AT_class (a) == dw_val_class_flag) - return a->dw_attr_val.v.val_flag; - - abort (); + gcc_assert (a && AT_class (a) == dw_val_class_flag); + return a->dw_attr_val.v.val_flag; } /* Add a signed integer attribute value to a DIE. */ @@ -4711,10 +4687,8 @@ add_AT_int (dw_die_ref die, enum dwarf_attribute attr_kind, HOST_WIDE_INT int_va static inline HOST_WIDE_INT AT_int (dw_attr_ref a) { - if (a && AT_class (a) == dw_val_class_const) - return a->dw_attr_val.v.val_int; - - abort (); + gcc_assert (a && AT_class (a) == dw_val_class_const); + return a->dw_attr_val.v.val_int; } /* Add an unsigned integer attribute value to a DIE. */ @@ -4735,10 +4709,8 @@ add_AT_unsigned (dw_die_ref die, enum dwarf_attribute attr_kind, static inline unsigned HOST_WIDE_INT AT_unsigned (dw_attr_ref a) { - if (a && AT_class (a) == dw_val_class_unsigned_const) - return a->dw_attr_val.v.val_unsigned; - - abort (); + gcc_assert (a && AT_class (a) == dw_val_class_unsigned_const); + return a->dw_attr_val.v.val_unsigned; } /* Add an unsigned double integer attribute value to a DIE. */ @@ -4820,10 +4792,8 @@ add_AT_string (dw_die_ref die, enum dwarf_attribute attr_kind, const char *str) static inline const char * AT_string (dw_attr_ref a) { - if (a && AT_class (a) == dw_val_class_str) - return a->dw_attr_val.v.val_str->str; - - abort (); + gcc_assert (a && AT_class (a) == dw_val_class_str); + return a->dw_attr_val.v.val_str->str; } /* Find out whether a string should be output inline in DIE @@ -4832,38 +4802,35 @@ AT_string (dw_attr_ref a) static int AT_string_form (dw_attr_ref a) { - if (a && AT_class (a) == dw_val_class_str) - { - struct indirect_string_node *node; - unsigned int len; - char label[32]; - - node = a->dw_attr_val.v.val_str; - if (node->form) - return node->form; - - len = strlen (node->str) + 1; + struct indirect_string_node *node; + unsigned int len; + char label[32]; - /* If the string is shorter or equal to the size of the reference, it is - always better to put it inline. */ - if (len <= DWARF_OFFSET_SIZE || node->refcount == 0) - return node->form = DW_FORM_string; + gcc_assert (a && AT_class (a) == dw_val_class_str); + + node = a->dw_attr_val.v.val_str; + if (node->form) + return node->form; + + len = strlen (node->str) + 1; - /* If we cannot expect the linker to merge strings in .debug_str - section, only put it into .debug_str if it is worth even in this - single module. */ - if ((DEBUG_STR_SECTION_FLAGS & SECTION_MERGE) == 0 - && (len - DWARF_OFFSET_SIZE) * node->refcount <= len) - return node->form = DW_FORM_string; + /* If the string is shorter or equal to the size of the reference, it is + always better to put it inline. */ + if (len <= DWARF_OFFSET_SIZE || node->refcount == 0) + return node->form = DW_FORM_string; - ASM_GENERATE_INTERNAL_LABEL (label, "LASF", dw2_string_counter); - ++dw2_string_counter; - node->label = xstrdup (label); + /* If we cannot expect the linker to merge strings in .debug_str + section, only put it into .debug_str if it is worth even in this + single module. */ + if ((DEBUG_STR_SECTION_FLAGS & SECTION_MERGE) == 0 + && (len - DWARF_OFFSET_SIZE) * node->refcount <= len) + return node->form = DW_FORM_string; - return node->form = DW_FORM_strp; - } + ASM_GENERATE_INTERNAL_LABEL (label, "LASF", dw2_string_counter); + ++dw2_string_counter; + node->label = xstrdup (label); - abort (); + return node->form = DW_FORM_strp; } /* Add a DIE reference attribute value to a DIE. */ @@ -4888,18 +4855,15 @@ static inline void add_AT_specification (dw_die_ref die, dw_die_ref targ_die) { add_AT_die_ref (die, DW_AT_specification, targ_die); - if (targ_die->die_definition) - abort (); + gcc_assert (!targ_die->die_definition); targ_die->die_definition = die; } static inline dw_die_ref AT_ref (dw_attr_ref a) { - if (a && AT_class (a) == dw_val_class_die_ref) - return a->dw_attr_val.v.val_die_ref.die; - - abort (); + gcc_assert (a && AT_class (a) == dw_val_class_die_ref); + return a->dw_attr_val.v.val_die_ref.die; } static inline int @@ -4914,10 +4878,8 @@ AT_ref_external (dw_attr_ref a) static inline void set_AT_ref_external (dw_attr_ref a, int i) { - if (a && AT_class (a) == dw_val_class_die_ref) - a->dw_attr_val.v.val_die_ref.external = i; - else - abort (); + gcc_assert (a && AT_class (a) == dw_val_class_die_ref); + a->dw_attr_val.v.val_die_ref.external = i; } /* Add an FDE reference attribute value to a DIE. */ @@ -4951,10 +4913,8 @@ add_AT_loc (dw_die_ref die, enum dwarf_attribute attr_kind, dw_loc_descr_ref loc static inline dw_loc_descr_ref AT_loc (dw_attr_ref a) { - if (a && AT_class (a) == dw_val_class_loc) - return a->dw_attr_val.v.val_loc; - - abort (); + gcc_assert (a && AT_class (a) == dw_val_class_loc); + return a->dw_attr_val.v.val_loc; } static inline void @@ -4973,10 +4933,8 @@ add_AT_loc_list (dw_die_ref die, enum dwarf_attribute attr_kind, dw_loc_list_ref static inline dw_loc_list_ref AT_loc_list (dw_attr_ref a) { - if (a && AT_class (a) == dw_val_class_loc_list) - return a->dw_attr_val.v.val_loc_list; - - abort (); + gcc_assert (a && AT_class (a) == dw_val_class_loc_list); + return a->dw_attr_val.v.val_loc_list; } /* Add an address constant attribute value to a DIE. */ @@ -4996,10 +4954,8 @@ add_AT_addr (dw_die_ref die, enum dwarf_attribute attr_kind, rtx addr) static inline rtx AT_addr (dw_attr_ref a) { - if (a && AT_class (a) == dw_val_class_addr) - return a->dw_attr_val.v.val_addr; - - abort (); + gcc_assert (a && AT_class (a) == dw_val_class_addr); + return a->dw_attr_val.v.val_addr; } /* Add a label identifier attribute value to a DIE. */ @@ -5063,11 +5019,9 @@ add_AT_range_list (dw_die_ref die, enum dwarf_attribute attr_kind, static inline const char * AT_lbl (dw_attr_ref a) { - if (a && (AT_class (a) == dw_val_class_lbl_id - || AT_class (a) == dw_val_class_lbl_offset)) - return a->dw_attr_val.v.val_lbl_id; - - abort (); + gcc_assert (a && (AT_class (a) == dw_val_class_lbl_id + || AT_class (a) == dw_val_class_lbl_offset)); + return a->dw_attr_val.v.val_lbl_id; } /* Get the attribute of type attr_kind. */ @@ -5317,8 +5271,7 @@ add_child_die (dw_die_ref die, dw_die_ref child_die) { if (die != NULL && child_die != NULL) { - if (die == child_die) - abort (); + gcc_assert (die != child_die); child_die->die_parent = die; child_die->die_sib = die->die_child; @@ -5344,9 +5297,9 @@ splice_child_die (dw_die_ref parent, dw_die_ref child) child = tmp; } - if (child->die_parent != parent - && child->die_parent != get_AT_ref (parent, DW_AT_specification)) - abort (); + gcc_assert (child->die_parent == parent + || (child->die_parent + == get_AT_ref (parent, DW_AT_specification))); for (p = &(child->die_parent->die_child); *p; p = &((*p)->die_sib)) if (*p == child) @@ -5778,15 +5731,8 @@ attr_checksum (dw_attr_ref at, struct md5_ctx *ctx, int *mark) case dw_val_class_addr: r = AT_addr (at); - switch (GET_CODE (r)) - { - case SYMBOL_REF: - CHECKSUM_STRING (XSTR (r, 0)); - break; - - default: - abort (); - } + gcc_assert (GET_CODE (r) == SYMBOL_REF); + CHECKSUM_STRING (XSTR (r, 0)); break; case dw_val_class_offset: @@ -5886,14 +5832,8 @@ same_dw_val_p (dw_val_node *v1, dw_val_node *v2, int *mark) r2 = v2->v.val_addr; if (GET_CODE (r1) != GET_CODE (r2)) return 0; - switch (GET_CODE (r1)) - { - case SYMBOL_REF: - return !strcmp (XSTR (r1, 0), XSTR (r2, 0)); - - default: - abort (); - } + gcc_assert (GET_CODE (r1) == SYMBOL_REF); + return !strcmp (XSTR (r1, 0), XSTR (r2, 0)); case dw_val_class_offset: return v1->v.val_offset == v2->v.val_offset; @@ -6269,8 +6209,7 @@ break_out_includes (dw_die_ref die) #if 0 /* We can only use this in debugging, since the frontend doesn't check to make sure that we leave every include file we enter. */ - if (unit != NULL) - abort (); + gcc_assert (!unit); #endif assign_symbol_names (die); @@ -6351,8 +6290,7 @@ build_abbrev_table (dw_die_ref die) if (AT_class (d_attr) == dw_val_class_die_ref && AT_ref (d_attr)->die_mark == 0) { - if (AT_ref (d_attr)->die_symbol == 0) - abort (); + gcc_assert (AT_ref (d_attr)->die_symbol); set_AT_ref_external (d_attr, 1); } @@ -6497,7 +6435,7 @@ size_of_die (dw_die_ref die) size += strlen (a->dw_attr_val.v.val_str->str) + 1; break; default: - abort (); + gcc_unreachable (); } } @@ -6535,8 +6473,7 @@ mark_dies (dw_die_ref die) { dw_die_ref c; - if (die->die_mark) - abort (); + gcc_assert (!die->die_mark); die->die_mark = 1; for (c = die->die_child; c; c = c->die_sib) @@ -6550,8 +6487,7 @@ unmark_dies (dw_die_ref die) { dw_die_ref c; - if (!die->die_mark) - abort (); + gcc_assert (die->die_mark); die->die_mark = 0; for (c = die->die_child; c; c = c->die_sib) @@ -6627,11 +6563,15 @@ value_format (dw_attr_ref a) return DW_FORM_addr; case dw_val_class_range_list: case dw_val_class_offset: - if (DWARF_OFFSET_SIZE == 4) - return DW_FORM_data4; - if (DWARF_OFFSET_SIZE == 8) - return DW_FORM_data8; - abort (); + switch (DWARF_OFFSET_SIZE) + { + case 4: + return DW_FORM_data4; + case 8: + return DW_FORM_data8; + default: + gcc_unreachable (); + } case dw_val_class_loc_list: /* FIXME: Could be DW_FORM_data8, with a > 32 bit size .debug_loc section */ @@ -6644,7 +6584,7 @@ value_format (dw_attr_ref a) case 2: return DW_FORM_block2; default: - abort (); + gcc_unreachable (); } case dw_val_class_const: return DW_FORM_sdata; @@ -6660,7 +6600,7 @@ value_format (dw_attr_ref a) case 8: return DW_FORM_data8; default: - abort (); + gcc_unreachable (); } case dw_val_class_long_long: return DW_FORM_block1; @@ -6683,7 +6623,7 @@ value_format (dw_attr_ref a) return AT_string_form (a); default: - abort (); + gcc_unreachable (); } } @@ -6826,8 +6766,7 @@ output_loc_list (dw_loc_list_ref list_head) size = size_of_locs (curr->expr); /* Output the block length for this list of location operations. */ - if (size > 0xffff) - abort (); + gcc_assert (size <= 0xffff); dw2_asm_output_data (2, size, "%s", "Location expression size"); output_loc_sequence (curr->expr); @@ -6962,8 +6901,7 @@ output_die (dw_die_ref die) { char *sym = AT_loc_list (a)->ll_symbol; - if (sym == 0) - abort (); + gcc_assert (sym); dw2_asm_output_offset (DWARF_OFFSET_SIZE, sym, "%s", name); } break; @@ -6973,15 +6911,15 @@ output_die (dw_die_ref die) { char *sym = AT_ref (a)->die_symbol; - if (sym == 0) - abort (); + gcc_assert (sym); dw2_asm_output_offset (DWARF2_ADDR_SIZE, sym, "%s", name); } - else if (AT_ref (a)->die_offset == 0) - abort (); else - dw2_asm_output_data (DWARF_OFFSET_SIZE, AT_ref (a)->die_offset, - "%s", name); + { + gcc_assert (AT_ref (a)->die_offset); + dw2_asm_output_data (DWARF_OFFSET_SIZE, AT_ref (a)->die_offset, + "%s", name); + } break; case dw_val_class_fde_ref: @@ -7012,7 +6950,7 @@ output_die (dw_die_ref die) break; default: - abort (); + gcc_unreachable (); } } @@ -7155,8 +7093,7 @@ output_pubnames (void) pubname_ref pub = &pubname_table[i]; /* We shouldn't see pubnames for DIEs outside of the main CU. */ - if (pub->die->die_mark == 0) - abort (); + gcc_assert (pub->die->die_mark); dw2_asm_output_data (DWARF_OFFSET_SIZE, pub->die->die_offset, "DIE offset"); @@ -7229,8 +7166,7 @@ output_aranges (void) dw_die_ref die = arange_table[i]; /* We shouldn't see aranges for DIEs outside of the main CU. */ - if (die->die_mark == 0) - abort (); + gcc_assert (die->die_mark); if (die->die_tag == DW_TAG_subprogram) { @@ -7247,12 +7183,10 @@ output_aranges (void) dw_attr_ref a = get_AT (die, DW_AT_location); dw_loc_descr_ref loc; - if (! a || AT_class (a) != dw_val_class_loc) - abort (); + gcc_assert (a && AT_class (a) == dw_val_class_loc); loc = AT_loc (a); - if (loc->dw_loc_opc != DW_OP_addr) - abort (); + gcc_assert (loc->dw_loc_opc == DW_OP_addr); dw2_asm_output_addr_rtx (DWARF2_ADDR_SIZE, loc->dw_loc_oprnd1.v.val_addr, "Address"); @@ -8007,7 +7941,7 @@ base_type_die (tree type) default: /* No other TREE_CODEs are Dwarf fundamental types. */ - abort (); + gcc_unreachable (); } base_type_result = new_die (DW_TAG_base_type, comp_unit_die, type); @@ -8085,7 +8019,7 @@ is_base_type (tree type) return 0; default: - abort (); + gcc_unreachable (); } return 0; @@ -8323,8 +8257,7 @@ modified_type_die (tree type, int is_const_type, int is_volatile_type, /* Vectors have the debugging information in the type, not the main variant. */ mod_type_die = lookup_type_die (type); - if (mod_type_die == NULL) - abort (); + gcc_assert (mod_type_die); } /* We want to equate the qualified type to the die below. */ @@ -8365,8 +8298,7 @@ dbx_reg_number (rtx rtl) { unsigned regno = REGNO (rtl); - if (regno >= FIRST_PSEUDO_REGISTER) - abort (); + gcc_assert (regno < FIRST_PSEUDO_REGISTER); return DBX_REGISTER_NUMBER (regno); } @@ -8438,8 +8370,7 @@ multiple_reg_loc_descriptor (rtx rtl, rtx regs) /* Now onto stupid register sets in non contiguous locations. */ - if (GET_CODE (regs) != PARALLEL) - abort (); + gcc_assert (GET_CODE (regs) == PARALLEL); size = GET_MODE_SIZE (GET_MODE (XVECEXP (regs, 0, 0))); loc_result = NULL; @@ -8734,7 +8665,7 @@ mem_loc_descriptor (rtx rtl, enum machine_mode mode, bool can_use_fbreg) break; default: - abort (); + gcc_unreachable (); } return mem_loc_result; @@ -8844,7 +8775,7 @@ loc_descriptor (rtx rtl, bool can_use_fbreg) break; default: - abort (); + gcc_unreachable (); } return loc_result; @@ -9247,7 +9178,7 @@ loc_descriptor_from_tree_1 (tree loc, int want_address) #ifdef ENABLE_CHECKING /* Otherwise this is a generic code; we should just lists all of these explicitly. Aborting means we forgot one. */ - abort (); + gcc_unreachable (); #else /* In a release build, we want to degrade gracefully: better to generate incomplete debugging information than to crash. */ @@ -9350,8 +9281,8 @@ field_byte_offset (tree decl) if (TREE_CODE (decl) == ERROR_MARK) return 0; - else if (TREE_CODE (decl) != FIELD_DECL) - abort (); + + gcc_assert (TREE_CODE (decl) == FIELD_DECL); type = field_type (decl); field_size_tree = DECL_SIZE (decl); @@ -9513,8 +9444,7 @@ add_data_member_location_attribute (dw_die_ref die, tree decl) /* Calculate the address of the offset. */ offset = tree_low_cst (BINFO_VPTR_FIELD (decl), 0); - if (offset >= 0) - abort (); + gcc_assert (offset < 0); tmp = int_loc_descriptor (-offset); add_loc_descr (&loc_descr, tmp); @@ -9649,8 +9579,7 @@ add_const_value_attribute (dw_die_ref die, rtx rtl) else { /* ??? We really should be using HOST_WIDE_INT throughout. */ - if (HOST_BITS_PER_LONG != HOST_BITS_PER_WIDE_INT) - abort (); + gcc_assert (HOST_BITS_PER_LONG == HOST_BITS_PER_WIDE_INT); add_AT_long_long (die, DW_AT_const_value, CONST_DOUBLE_HIGH (rtl), CONST_DOUBLE_LOW (rtl)); @@ -9667,32 +9596,38 @@ add_const_value_attribute (dw_die_ref die, rtx rtl) unsigned int i; unsigned char *p; - if (GET_MODE_CLASS (mode) == MODE_VECTOR_INT) + switch (GET_MODE_CLASS (mode)) { + case MODE_VECTOR_INT: for (i = 0, p = array; i < length; i++, p += elt_size) { rtx elt = CONST_VECTOR_ELT (rtl, i); HOST_WIDE_INT lo, hi; - if (GET_CODE (elt) == CONST_INT) + + switch (GET_CODE (elt)) { + case CONST_INT: lo = INTVAL (elt); hi = -(lo < 0); - } - else if (GET_CODE (elt) == CONST_DOUBLE) - { + break; + + case CONST_DOUBLE: lo = CONST_DOUBLE_LOW (elt); hi = CONST_DOUBLE_HIGH (elt); + break; + + default: + gcc_unreachable (); } - else - abort (); - + if (elt_size <= sizeof (HOST_WIDE_INT)) insert_int (lo, elt_size, p); - else if (elt_size == 2 * sizeof (HOST_WIDE_INT)) + else { unsigned char *p0 = p; unsigned char *p1 = p + sizeof (HOST_WIDE_INT); - + + gcc_assert (elt_size == 2 * sizeof (HOST_WIDE_INT)); if (WORDS_BIG_ENDIAN) { p0 = p1; @@ -9701,20 +9636,20 @@ add_const_value_attribute (dw_die_ref die, rtx rtl) insert_int (lo, sizeof (HOST_WIDE_INT), p0); insert_int (hi, sizeof (HOST_WIDE_INT), p1); } - else - abort (); } - } - else if (GET_MODE_CLASS (mode) == MODE_VECTOR_FLOAT) - { + break; + + case MODE_VECTOR_FLOAT: for (i = 0, p = array; i < length; i++, p += elt_size) { rtx elt = CONST_VECTOR_ELT (rtl, i); insert_float (elt, p); } + break; + + default: + gcc_unreachable (); } - else - abort (); add_AT_vec (die, DW_AT_const_value, length, elt_size, array); } @@ -9747,7 +9682,7 @@ add_const_value_attribute (dw_die_ref die, rtx rtl) default: /* No other kinds of rtx should be possible here. */ - abort (); + gcc_unreachable (); } } @@ -9963,8 +9898,7 @@ rtl_for_decl_location (tree decl) rtl = expand_expr (DECL_INITIAL (decl), NULL_RTX, VOIDmode, EXPAND_INITIALIZER); /* If expand_expr returns a MEM, it wasn't immediate. */ - if (rtl && MEM_P (rtl)) - abort (); + gcc_assert (!rtl || !MEM_P (rtl)); } } @@ -10001,9 +9935,9 @@ add_location_or_const_value_attribute (dw_die_ref die, tree decl, if (TREE_CODE (decl) == ERROR_MARK) return; - else if (TREE_CODE (decl) != VAR_DECL && TREE_CODE (decl) != PARM_DECL - && TREE_CODE (decl) != RESULT_DECL) - abort (); + + gcc_assert (TREE_CODE (decl) == VAR_DECL || TREE_CODE (decl) == PARM_DECL + || TREE_CODE (decl) == RESULT_DECL); /* See if we possibly have multiple locations for this variable. */ loc_list = lookup_decl_loc (decl); @@ -10344,7 +10278,7 @@ add_byte_size_attribute (dw_die_ref die, tree tree_node) size = simple_type_size_in_bits (field_type (tree_node)) / BITS_PER_UNIT; break; default: - abort (); + gcc_unreachable (); } /* Note that `size' might be -1 when we get to this point. If it is, that @@ -10381,9 +10315,7 @@ add_bit_offset_attribute (dw_die_ref die, tree decl) HOST_WIDE_INT unsigned bit_offset; /* Must be a field and a bit field. */ - if (!type - || TREE_CODE (decl) != FIELD_DECL) - abort (); + gcc_assert (type && TREE_CODE (decl) == FIELD_DECL); /* We can't yet handle bit-fields whose offsets are variable, so if we encounter such things, just return without generating any attribute @@ -10423,9 +10355,8 @@ static inline void add_bit_size_attribute (dw_die_ref die, tree decl) { /* Must be a field and a bit field. */ - if (TREE_CODE (decl) != FIELD_DECL - || ! DECL_BIT_FIELD_TYPE (decl)) - abort (); + gcc_assert (TREE_CODE (decl) == FIELD_DECL + && DECL_BIT_FIELD_TYPE (decl)); if (host_integerp (DECL_SIZE (decl), 1)) add_AT_unsigned (die, DW_AT_bit_size, tree_low_cst (DECL_SIZE (decl), 1)); @@ -10474,8 +10405,7 @@ add_abstract_origin_attribute (dw_die_ref die, tree origin) else if (TYPE_P (origin)) origin_die = lookup_type_die (origin); - if (origin_die == NULL) - abort (); + gcc_assert (origin_die); add_AT_die_ref (die, DW_AT_abstract_origin, origin_die); } @@ -10562,8 +10492,7 @@ push_decl_scope (tree scope) static inline void pop_decl_scope (void) { - if (VARRAY_ACTIVE_SIZE (decl_scope_table) <= 0) - abort (); + gcc_assert (VARRAY_ACTIVE_SIZE (decl_scope_table) > 0); VARRAY_POP (decl_scope_table); } @@ -10582,8 +10511,7 @@ scope_die_for (tree t, dw_die_ref context_die) int i; /* Non-types always go in the current scope. */ - if (! TYPE_P (t)) - abort (); + gcc_assert (TYPE_P (t)); containing_scope = TYPE_CONTEXT (t); @@ -10615,9 +10543,8 @@ scope_die_for (tree t, dw_die_ref context_die) if (i < 0) { - if (debug_info_level > DINFO_LEVEL_TERSE - && !TREE_ASM_WRITTEN (containing_scope)) - abort (); + gcc_assert (debug_info_level <= DINFO_LEVEL_TERSE + || TREE_ASM_WRITTEN (containing_scope)); /* If none of the current dies are suitable, we get file scope. */ scope_die = comp_unit_die; @@ -10744,12 +10671,10 @@ decl_start_label (tree decl) const char *fnname; x = DECL_RTL (decl); - if (!MEM_P (x)) - abort (); + gcc_assert (MEM_P (x)); x = XEXP (x, 0); - if (GET_CODE (x) != SYMBOL_REF) - abort (); + gcc_assert (GET_CODE (x) == SYMBOL_REF); fnname = XSTR (x, 0); return fnname; @@ -11018,7 +10943,7 @@ gen_formal_parameter_die (tree node, dw_die_ref context_die) break; default: - abort (); + gcc_unreachable (); } return parm_die; @@ -11107,8 +11032,7 @@ gen_type_die_for_member (tree type, tree member, dw_die_ref context_die) if (TYPE_DECL_SUPPRESS_DEBUG (TYPE_STUB_DECL (type)) && ! lookup_decl_die (member)) { - if (decl_ultimate_origin (member)) - abort (); + gcc_assert (!decl_ultimate_origin (member)); push_decl_scope (type); if (TREE_CODE (member) == FUNCTION_DECL) @@ -11187,14 +11111,12 @@ gen_subprogram_die (tree decl, dw_die_ref context_die) if (origin && declaration && class_or_namespace_scope_p (context_die)) { origin = NULL; - if (old_die) - abort (); + gcc_assert (!old_die); } if (origin != NULL) { - if (declaration && ! local_scope_p (context_die)) - abort (); + gcc_assert (!declaration || local_scope_p (context_die)); /* Fixup die_parent for the abstract instance of a nested inline function. */ @@ -11220,9 +11142,8 @@ gen_subprogram_die (tree decl, dw_die_ref context_die) we should detect this case and ignore it. For now, if we have already reported an error, any error at all, then assume that we got here because of an input error, not a dwarf2 bug. */ - if (errorcount) - return; - abort (); + gcc_assert (errorcount); + return; } /* If the definition comes from the same place as the declaration, @@ -11563,8 +11484,7 @@ gen_label_die (tree decl, dw_die_ref context_die) represent source-level labels which were explicitly declared by the user. This really shouldn't be happening though, so catch it if it ever does happen. */ - if (INSN_DELETED_P (insn)) - abort (); + gcc_assert (!INSN_DELETED_P (insn)); ASM_GENERATE_INTERNAL_LABEL (label, "L", CODE_LABEL_NUMBER (insn)); add_AT_lbl_id (lbl_die, DW_AT_low_pc, label); @@ -12022,10 +11942,8 @@ gen_typedef_die (tree decl, dw_die_ref context_die) { type = DECL_ORIGINAL_TYPE (decl); - if (type == TREE_TYPE (decl)) - abort (); - else - equate_type_number_to_die (TREE_TYPE (decl), type_die); + gcc_assert (type != TREE_TYPE (decl)); + equate_type_number_to_die (TREE_TYPE (decl), type_die); } else type = TREE_TYPE (decl); @@ -12055,8 +11973,7 @@ gen_type_die (tree type, dw_die_ref context_die) return; /* Prevent broken recursion; we can't hand off to the same type. */ - if (DECL_ORIGINAL_TYPE (TYPE_NAME (type)) == type) - abort (); + gcc_assert (DECL_ORIGINAL_TYPE (TYPE_NAME (type)) != type); TREE_ASM_WRITTEN (type) = 1; gen_decl_die (TYPE_NAME (type), context_die); @@ -12113,7 +12030,8 @@ gen_type_die (tree type, dw_die_ref context_die) case FILE_TYPE: gen_type_die (TREE_TYPE (type), context_die); - abort (); /* No way to represent these in Dwarf yet! */ + /* No way to represent these in Dwarf yet! */ + gcc_unreachable (); break; case FUNCTION_TYPE: @@ -12199,7 +12117,7 @@ gen_type_die (tree type, dw_die_ref context_die) break; default: - abort (); + gcc_unreachable (); } TREE_ASM_WRITTEN (type) = 1; @@ -12217,8 +12135,7 @@ gen_tagged_type_instantiation_die (tree type, dw_die_ref context_die) this type (i.e. without any const or volatile qualifiers) so make sure that we have the main variant (i.e. the unqualified version) of this type now. */ - if (type != type_main_variant (type)) - abort (); + gcc_assert (type == type_main_variant (type)); /* Do not check TREE_ASM_WRITTEN (type) as it may not be set if this is an instance of an unresolved type. */ @@ -12242,7 +12159,7 @@ gen_tagged_type_instantiation_die (tree type, dw_die_ref context_die) break; default: - abort (); + gcc_unreachable (); } } @@ -12453,15 +12370,14 @@ force_decl_die (tree decl) break; default: - abort (); + gcc_unreachable (); } /* See if we can find the die for this deci now. If not then abort. */ if (!decl_die) decl_die = lookup_decl_die (decl); - if (!decl_die) - abort (); + gcc_assert (decl_die); } return decl_die; @@ -12488,8 +12404,7 @@ force_type_die (tree type) gen_type_die (type, context_die); type_die = lookup_type_die (type); - if (!type_die) - abort(); + gcc_assert (type_die); } return type_die; } @@ -12726,10 +12641,9 @@ gen_decl_die (tree decl, dw_die_ref context_die) break; default: - if ((int)TREE_CODE (decl) > NUM_TREE_CODES) - /* Probably some frontend-internal decl. Assume we don't care. */ - break; - abort (); + /* Probably some frontend-internal decl. Assume we don't care. */ + gcc_assert ((int)TREE_CODE (decl) > NUM_TREE_CODES); + break; } } @@ -12791,8 +12705,7 @@ dwarf2out_imported_module_or_decl (tree decl, tree context) if (debug_info_level <= DINFO_LEVEL_TERSE) return; - if (!decl) - abort (); + gcc_assert (decl); /* To emit DW_TAG_imported_module or DW_TAG_imported_decl, we need two DIEs. We need decl DIE for reference and scope die. First, get DIE for the decl @@ -13523,8 +13436,8 @@ static void prune_unused_types_prune (dw_die_ref die) { dw_die_ref c, p, n; - if (!die->die_mark) - abort(); + + gcc_assert (die->die_mark); p = NULL; for (c = die->die_child; c; c = n) @@ -13623,7 +13536,6 @@ dwarf2out_finish (const char *filename) if (die->die_parent == NULL) { dw_die_ref origin = get_AT_ref (die, DW_AT_abstract_origin); - tree context; if (origin) add_child_die (origin->die_parent, die); @@ -13632,25 +13544,28 @@ dwarf2out_finish (const char *filename) else if (errorcount > 0 || sorrycount > 0) /* It's OK to be confused by errors in the input. */ add_child_die (comp_unit_die, die); - else if (node->created_for - && ((DECL_P (node->created_for) - && (context = DECL_CONTEXT (node->created_for))) - || (TYPE_P (node->created_for) - && (context = TYPE_CONTEXT (node->created_for)))) - && TREE_CODE (context) == FUNCTION_DECL) + else { /* In certain situations, the lexical block containing a nested function can be optimized away, which results in the nested function die being orphaned. Likewise with the return type of that nested function. Force this to be a child of the containing function. */ + tree context = NULL_TREE; + + gcc_assert (node->created_for); + + if (DECL_P (node->created_for)) + context = DECL_CONTEXT (node->created_for); + else if (TYPE_P (node->created_for)) + context = TYPE_CONTEXT (node->created_for); + + gcc_assert (context && TREE_CODE (context) == FUNCTION_DECL); + origin = lookup_decl_die (context); - if (! origin) - abort (); + gcc_assert (origin); add_child_die (origin, die); } - else - abort (); } } -- 2.30.2