From ced7e9584b848a8d5975b23efb5eac04ee2aee6f Mon Sep 17 00:00:00 2001 From: Jan Hubicka Date: Tue, 8 Dec 2015 23:01:41 +0100 Subject: [PATCH] re PR lto/61886 (LTO breaks fread with _FORTIFY_SOURCE=2) PR ipa/61886 * ipa-visibility.c (can_replace_by_local_alias): Look through transparent aliaes; refuse weakrefs. (update_visibility_by_resolution_info): Skip transparent aliases in the analysis part From-SVN: r231428 --- gcc/ChangeLog | 8 ++++++++ gcc/ipa-visibility.c | 9 ++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index e4c720774dd..8554091625c 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2015-12-08 Jan Hubicka + + PR ipa/61886 + * ipa-visibility.c (can_replace_by_local_alias): Look through transparent + aliaes; refuse weakrefs. + (update_visibility_by_resolution_info): Skip transparent aliases in the + analysis part + 2015-12-08 Jan Hubicka PR ipa/61886 diff --git a/gcc/ipa-visibility.c b/gcc/ipa-visibility.c index 0423f242af0..5b03159197c 100644 --- a/gcc/ipa-visibility.c +++ b/gcc/ipa-visibility.c @@ -332,6 +332,13 @@ varpool_node::externally_visible_p (void) bool can_replace_by_local_alias (symtab_node *node) { + /* Weakrefs have a reason to be non-local. Be sure we do not replace + them. */ + while (node->transparent_alias && node->definition && !node->weakref) + node = node->get_alias_target (); + if (node->weakref) + return false; + return (node->get_availability () > AVAIL_INTERPOSABLE && !decl_binds_to_current_def_p (node->decl) && !node->can_be_discarded_p ()); @@ -392,7 +399,7 @@ update_visibility_by_resolution_info (symtab_node * node) for (symtab_node *next = node->same_comdat_group; next != node; next = next->same_comdat_group) { - if (!next->externally_visible) + if (!next->externally_visible || next->transparent_alias) continue; bool same_def -- 2.30.2