From cf5dda334945e2cbfaf5f83fd32c3fa01f436d81 Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Mon, 4 Jun 2018 13:31:47 -0400 Subject: [PATCH] freedreno/ir3: don't cp absneg into meta:fi If using a fanin (collect) to collect of consecutive registers together, we can CP mov's into the fanin, but not (abs) or (neg). No places that allow those modifiers are consuming a fanin anyways. But this caused an absneg to be lost between a ldgb and stgb for shaders like: outputs[n] = abs(input[n]) Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/ir3/ir3_cp.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_cp.c b/src/gallium/drivers/freedreno/ir3/ir3_cp.c index e3a3a9db690..0ee8ea2e0ea 100644 --- a/src/gallium/drivers/freedreno/ir3/ir3_cp.c +++ b/src/gallium/drivers/freedreno/ir3/ir3_cp.c @@ -543,6 +543,10 @@ instr_cp(struct ir3_cp_ctx *ctx, struct ir3_instruction *instr) if (reg->flags & IR3_REG_ARRAY) continue; + /* Don't CP absneg into meta instructions, that won't end well: */ + if (is_meta(instr) && (src->opc != OPC_MOV)) + continue; + reg_cp(ctx, instr, reg, n); } -- 2.30.2