From d117b270e2cb7841dd739a514fe8fac48f2225dd Mon Sep 17 00:00:00 2001 From: Dirk Mueller Date: Tue, 30 May 2006 13:43:55 +0000 Subject: [PATCH] re PR c/27273 (tree check fail for legal code when convert returns a constant from an expression that was not constant) PR c/27273 * c-common.c (convert_and_check): only track TREE_CONSTANT_OVERFLOW for CONSTANT_CLASS_P expressions. * gcc.dg/overflow-warn-5.c: New testcase. From-SVN: r114238 --- gcc/ChangeLog | 6 ++++++ gcc/c-common.c | 3 ++- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/overflow-warn-5.c | 7 +++++++ 4 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/overflow-warn-5.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c5470be129a..9cb3befcafc 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2006-05-30 Dirk Mueller + + PR c/27273 + * c-common.c (convert_and_check): Only track TREE_CONSTANT_OVERFLOW + for CONSTANT_CLASS_P expresisons. + 2006-05-30 Volker Reichelt PR c/27718 diff --git a/gcc/c-common.c b/gcc/c-common.c index a27f5d36a24..dea83894e7f 100644 --- a/gcc/c-common.c +++ b/gcc/c-common.c @@ -1083,7 +1083,8 @@ convert_and_check (tree type, tree expr) /* Do not diagnose overflow in a constant expression merely because a conversion overflowed. */ - TREE_CONSTANT_OVERFLOW (t) = TREE_CONSTANT_OVERFLOW (expr); + TREE_CONSTANT_OVERFLOW (t) = CONSTANT_CLASS_P (expr) + && TREE_CONSTANT_OVERFLOW (expr); /* No warning for converting 0x80000000 to int. */ if (!(TYPE_UNSIGNED (type) < TYPE_UNSIGNED (TREE_TYPE (expr)) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index dc0ec7cf698..d5b709419be 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2006-05-30 Dirk Mueller + + PR c/27273 + * gcc.dg/overflow-warn-5.c: New test. + 2006-05-30 Volker Reichelt PR c/27718 diff --git a/gcc/testsuite/gcc.dg/overflow-warn-5.c b/gcc/testsuite/gcc.dg/overflow-warn-5.c new file mode 100644 index 00000000000..472d4a7cab1 --- /dev/null +++ b/gcc/testsuite/gcc.dg/overflow-warn-5.c @@ -0,0 +1,7 @@ +/* PR c/27273 */ +/* { dg-do compile } */ +/* { dg-options "-Woverflow" } */ + +unsigned char rx_async(unsigned char p) { + return p & 512; /* { dg-warning "overflow in implicit constant conversion" } */ +} -- 2.30.2