From d13059f4d50d370eec76495dd2b51fdf5c6e1aee Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Mon, 3 Jun 2019 11:43:38 -0700 Subject: [PATCH] nouveau: Use nir_lower_doubles instead of lower_fmod64 on nvc0. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit We currently have two duplicate mechanisms for lowering fmod@64. One is a nir_opt_algebraic rule keyed off of options->lower_fmod64, and the other is nir_lower_doubles, which offers a full gamut of fp64 lowering. The latter works slightly better in some corner cases, so I'm trying to eliminate lower_fmod64 and drop the redundancy. Reviewed-by: Marek Olšák --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index 998116fc251..09f8c4135e5 100644 --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c @@ -906,7 +906,6 @@ static const nir_shader_compiler_options nir_options = { .lower_fsat = false, .lower_fsqrt = false, // TODO: only before gm200 .lower_fmod32 = true, - .lower_fmod64 = true, .lower_bitfield_extract = false, .lower_bitfield_extract_to_shifts = false, .lower_bitfield_insert = false, @@ -955,7 +954,7 @@ static const nir_shader_compiler_options nir_options = { .lower_mul_2x32_64 = true, // TODO .max_unroll_iterations = 32, .lower_int64_options = nir_lower_divmod64, // TODO - .lower_doubles_options = 0, // TODO + .lower_doubles_options = nir_lower_dmod, // TODO }; static const void * -- 2.30.2