From d1dd3cbcc766a70ec3b193201299792566c6b69a Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Fri, 22 Mar 2019 16:54:57 +0000 Subject: [PATCH] util/process: document memory leak MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit We consider it acceptable, but let's still document it in case people notice it and are not sure why it's there. Signed-off-by: Eric Engestrom Reviewed-by: Tapani Pälli --- src/util/u_process.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/util/u_process.c b/src/util/u_process.c index a1667e78074..94c975df396 100644 --- a/src/util/u_process.c +++ b/src/util/u_process.c @@ -52,6 +52,10 @@ __getProgramName() static char *path; if (!path) + /* Note: realpath() allocates memory that we will keep around for + * the lifetime of the app, and then leak as the app closes. + * FIXME: we should find a way to clean this properly + */ path = realpath("/proc/self/exe", NULL); if (path && strncmp(path, program_invocation_name, strlen(path)) == 0) { -- 2.30.2