From d2b585f3cfc253678bf33b552a219e25eb29e686 Mon Sep 17 00:00:00 2001 From: Paul Pluzhnikov Date: Mon, 8 May 2023 01:03:42 +0000 Subject: [PATCH] Fix bad interaction between element limit and repeated values (BZ#24331). Currently print -elements=3 -- "AAAAAA" prints complete string, which is not what the user asked for. Fix two buggy tests exposed by the fix, and add a new test. Reviewed-by: Keith Seitz --- gdb/testsuite/gdb.base/printcmds.exp | 15 +++++++++++ gdb/testsuite/gdb.python/py-format-string.exp | 2 +- gdb/valprint.c | 25 ++++++++++++++----- 3 files changed, 35 insertions(+), 7 deletions(-) diff --git a/gdb/testsuite/gdb.base/printcmds.exp b/gdb/testsuite/gdb.base/printcmds.exp index db57769c303..f2be549f2a5 100644 --- a/gdb/testsuite/gdb.base/printcmds.exp +++ b/gdb/testsuite/gdb.base/printcmds.exp @@ -1027,6 +1027,9 @@ proc test_repeat_bytes {} { set fmt(SR) "\"%s\", %s" set fmt(SS) "\"%s%s\"" + # We have up to 60 elements to print. + gdb_test_no_output "set print elements 100" + # Set the target-charset to ASCII, because the output varies from # different charset. with_target_charset "ASCII" { @@ -1074,6 +1077,17 @@ proc test_repeat_bytes {} { } } +# Test for BZ#24331 +proc test_repeat_bytes_limit {} { + gdb_test "print -elem 3 -- \"AAAAA\"" "= \"AAA\"..." + gdb_test "print -char 3 -elem 10 -- \"AAAAA\"" "= \"AAA\"..." + gdb_test "print -elem 3 -- \"ABBBB\"" "= \"ABB\"..." + gdb_test "print -char 3 -elem 10 -- \"ABBBB\"" "= \"ABB\"..." + + gdb_test "print -elem 3 -repeats 2 -- \"AAABBB\"" "= 'A' ..." + gdb_test "print -elem 4 -repeats 2 -- \"AAABBB\"" "= 'A' , 'B' " +} + # Test printf of convenience variables. # These tests can be done with or without a running inferior. # PREFIX ensures uniqueness of test names. @@ -1199,3 +1213,4 @@ test_printf_with_strings test_print_symbol test_repeat_bytes test_radices +test_repeat_bytes_limit diff --git a/gdb/testsuite/gdb.python/py-format-string.exp b/gdb/testsuite/gdb.python/py-format-string.exp index 1d50f59dee3..2a011ebd45a 100644 --- a/gdb/testsuite/gdb.python/py-format-string.exp +++ b/gdb/testsuite/gdb.python/py-format-string.exp @@ -748,7 +748,7 @@ proc test_max_string_one { setting unlimited } { # This will print four characters instead of three, see # . check_format_string "a_binary_string_array" $opts \ - "\"hell\"..." + "\"hel\"..." check_format_string "a_big_string" $opts \ [get_cut_big_string 3] if { $setting == "elements"} { diff --git a/gdb/valprint.c b/gdb/valprint.c index b05d90dd26b..94896621680 100644 --- a/gdb/valprint.c +++ b/gdb/valprint.c @@ -2356,23 +2356,27 @@ count_next_character (wchar_iterator *iter, /* Print the characters in CHARS to the OBSTACK. QUOTE_CHAR is the quote character to use with string output. WIDTH is the size of the output character type. BYTE_ORDER is the target byte order. OPTIONS - is the user's print options. */ + is the user's print options. *FINISHED is set to 0 if we didn't print + all the elements in CHARS. */ static void print_converted_chars_to_obstack (struct obstack *obstack, const std::vector &chars, int quote_char, int width, enum bfd_endian byte_order, - const struct value_print_options *options) + const struct value_print_options *options, + int *finished) { - unsigned int idx; + unsigned int idx, num_elements; const converted_character *elem; enum {START, SINGLE, REPEAT, INCOMPLETE, FINISH} state, last; gdb_wchar_t wide_quote_char = gdb_btowc (quote_char); bool need_escape = false; + const int print_max = options->print_max_chars > 0 + ? options->print_max_chars : options->print_max; /* Set the start state. */ - idx = 0; + idx = num_elements = 0; last = state = START; elem = NULL; @@ -2400,7 +2404,13 @@ print_converted_chars_to_obstack (struct obstack *obstack, obstack_grow (obstack, &wide_quote_char, sizeof (gdb_wchar_t)); } /* Output the character. */ - for (j = 0; j < elem->repeat_count; ++j) + int repeat_count = elem->repeat_count; + if (print_max < repeat_count + num_elements) + { + repeat_count = print_max - num_elements; + *finished = 0; + } + for (j = 0; j < repeat_count; ++j) { if (elem->result == wchar_iterate_ok) print_wchar (elem->chars[0], elem->buf, elem->buflen, width, @@ -2408,6 +2418,7 @@ print_converted_chars_to_obstack (struct obstack *obstack, else print_wchar (gdb_WEOF, elem->buf, elem->buflen, width, byte_order, obstack, quote_char, &need_escape); + num_elements += 1; } } break; @@ -2439,6 +2450,7 @@ print_converted_chars_to_obstack (struct obstack *obstack, obstack_grow_wstr (obstack, LCST ("'")); std::string s = string_printf (_(" "), elem->repeat_count); + num_elements += elem->repeat_count; for (j = 0; s[j]; ++j) { gdb_wchar_t w = gdb_btowc (s[j]); @@ -2463,6 +2475,7 @@ print_converted_chars_to_obstack (struct obstack *obstack, print_wchar (gdb_WEOF, elem->buf, elem->buflen, width, byte_order, obstack, 0, &need_escape); obstack_grow_wstr (obstack, LCST (">")); + num_elements += 1; /* We do not attempt to output anything after this. */ state = FINISH; @@ -2597,7 +2610,7 @@ generic_printstr (struct ui_file *stream, struct type *type, /* Print the output string to the obstack. */ print_converted_chars_to_obstack (&wchar_buf, converted_chars, quote_char, - width, byte_order, options); + width, byte_order, options, &finished); if (force_ellipses || !finished) obstack_grow_wstr (&wchar_buf, LCST ("...")); -- 2.30.2