From d308ba78cfaf7c1b3a8d33ceb66c9a180352b888 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Mon, 8 Mar 2021 07:27:57 -0700 Subject: [PATCH] Convert f-exp.y to use operations This converts the Fortran parser to generate operations rather than exp_elements. A couple of tests of expression debug dumping are updated to follow the new output. gdb/ChangeLog 2021-03-08 Tom Tromey * f-exp.y: Create operations. (f_language::parser): Update. gdb/testsuite/ChangeLog 2021-03-08 Tom Tromey * gdb.fortran/debug-expr.exp: Update tests. --- gdb/ChangeLog | 5 + gdb/f-exp.y | 357 ++++++++++++++--------- gdb/testsuite/ChangeLog | 4 + gdb/testsuite/gdb.fortran/debug-expr.exp | 8 +- 4 files changed, 238 insertions(+), 136 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 7834e755e70..3af105597cf 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2021-03-08 Tom Tromey + + * f-exp.y: Create operations. + (f_language::parser): Update. + 2021-03-08 Tom Tromey * m2-exp.y: Create operations. diff --git a/gdb/f-exp.y b/gdb/f-exp.y index f5360c10ef6..0e56669f0a3 100644 --- a/gdb/f-exp.y +++ b/gdb/f-exp.y @@ -55,6 +55,7 @@ #include #include #include "type-stack.h" +#include "f-exp.h" #define parse_type(ps) builtin_type (ps->gdbarch ()) #define parse_f_type(ps) builtin_f_type (ps->gdbarch ()) @@ -89,6 +90,7 @@ static void push_kind_type (LONGEST val, struct type *type); static struct type *convert_to_kind_type (struct type *basetype, int kind); +using namespace expr; %} /* Although the yacc "value" of an expression is not used, @@ -209,9 +211,7 @@ start : exp ; type_exp: type - { write_exp_elt_opcode (pstate, OP_TYPE); - write_exp_elt_type (pstate, $1); - write_exp_elt_opcode (pstate, OP_TYPE); } + { pstate->push_new ($1); } ; exp : '(' exp ')' @@ -220,39 +220,65 @@ exp : '(' exp ')' /* Expressions, not including the comma operator. */ exp : '*' exp %prec UNARY - { write_exp_elt_opcode (pstate, UNOP_IND); } + { pstate->wrap (); } ; exp : '&' exp %prec UNARY - { write_exp_elt_opcode (pstate, UNOP_ADDR); } + { pstate->wrap (); } ; exp : '-' exp %prec UNARY - { write_exp_elt_opcode (pstate, UNOP_NEG); } + { pstate->wrap (); } ; exp : BOOL_NOT exp %prec UNARY - { write_exp_elt_opcode (pstate, UNOP_LOGICAL_NOT); } + { pstate->wrap (); } ; exp : '~' exp %prec UNARY - { write_exp_elt_opcode (pstate, UNOP_COMPLEMENT); } + { pstate->wrap (); } ; exp : SIZEOF exp %prec UNARY - { write_exp_elt_opcode (pstate, UNOP_SIZEOF); } + { pstate->wrap (); } ; exp : KIND '(' exp ')' %prec UNARY - { write_exp_elt_opcode (pstate, UNOP_FORTRAN_KIND); } + { pstate->wrap (); } ; exp : UNOP_OR_BINOP_INTRINSIC '(' { pstate->start_arglist (); } one_or_two_args ')' - { write_exp_elt_opcode (pstate, $1); - write_exp_elt_longcst (pstate, pstate->end_arglist ()); - write_exp_elt_opcode (pstate, $1); } + { + int n = pstate->end_arglist (); + gdb_assert (n == 1 || n == 2); + if ($1 == FORTRAN_ASSOCIATED) + { + if (n == 1) + pstate->wrap (); + else + pstate->wrap2 (); + } + else + { + std::vector args + = pstate->pop_vector (n); + gdb_assert ($1 == FORTRAN_LBOUND + || $1 == FORTRAN_UBOUND); + operation_up op; + if (n == 1) + op.reset + (new fortran_bound_1arg ($1, + std::move (args[0]))); + else + op.reset + (new fortran_bound_2arg ($1, + std::move (args[0]), + std::move (args[1]))); + pstate->push (std::move (op)); + } + } ; one_or_two_args @@ -270,20 +296,53 @@ one_or_two_args exp : exp '(' { pstate->start_arglist (); } arglist ')' - { write_exp_elt_opcode (pstate, - OP_F77_UNDETERMINED_ARGLIST); - write_exp_elt_longcst (pstate, - pstate->end_arglist ()); - write_exp_elt_opcode (pstate, - OP_F77_UNDETERMINED_ARGLIST); } + { + std::vector args + = pstate->pop_vector (pstate->end_arglist ()); + pstate->push_new + (pstate->pop (), std::move (args)); + } ; exp : UNOP_INTRINSIC '(' exp ')' - { write_exp_elt_opcode (pstate, $1); } + { + switch ($1) + { + case UNOP_ABS: + pstate->wrap (); + break; + case UNOP_FORTRAN_FLOOR: + pstate->wrap (); + break; + case UNOP_FORTRAN_CEILING: + pstate->wrap (); + break; + case UNOP_FORTRAN_ALLOCATED: + pstate->wrap (); + break; + default: + gdb_assert_not_reached ("unhandled intrinsic"); + } + } ; exp : BINOP_INTRINSIC '(' exp ',' exp ')' - { write_exp_elt_opcode (pstate, $1); } + { + switch ($1) + { + case BINOP_MOD: + pstate->wrap2 (); + break; + case BINOP_FORTRAN_MODULO: + pstate->wrap2 (); + break; + case BINOP_FORTRAN_CMPLX: + pstate->wrap2 (); + break; + default: + gdb_assert_not_reached ("unhandled intrinsic"); + } + } ; arglist : @@ -308,63 +367,90 @@ arglist : arglist ',' subrange %prec ABOVE_COMMA /* There are four sorts of subrange types in F90. */ subrange: exp ':' exp %prec ABOVE_COMMA - { write_exp_elt_opcode (pstate, OP_RANGE); - write_exp_elt_longcst (pstate, RANGE_STANDARD); - write_exp_elt_opcode (pstate, OP_RANGE); } + { + operation_up high = pstate->pop (); + operation_up low = pstate->pop (); + pstate->push_new + (RANGE_STANDARD, std::move (low), + std::move (high), operation_up ()); + } ; subrange: exp ':' %prec ABOVE_COMMA - { write_exp_elt_opcode (pstate, OP_RANGE); - write_exp_elt_longcst (pstate, - RANGE_HIGH_BOUND_DEFAULT); - write_exp_elt_opcode (pstate, OP_RANGE); } + { + operation_up low = pstate->pop (); + pstate->push_new + (RANGE_HIGH_BOUND_DEFAULT, std::move (low), + operation_up (), operation_up ()); + } ; subrange: ':' exp %prec ABOVE_COMMA - { write_exp_elt_opcode (pstate, OP_RANGE); - write_exp_elt_longcst (pstate, - RANGE_LOW_BOUND_DEFAULT); - write_exp_elt_opcode (pstate, OP_RANGE); } + { + operation_up high = pstate->pop (); + pstate->push_new + (RANGE_LOW_BOUND_DEFAULT, operation_up (), + std::move (high), operation_up ()); + } ; subrange: ':' %prec ABOVE_COMMA - { write_exp_elt_opcode (pstate, OP_RANGE); - write_exp_elt_longcst (pstate, - (RANGE_LOW_BOUND_DEFAULT - | RANGE_HIGH_BOUND_DEFAULT)); - write_exp_elt_opcode (pstate, OP_RANGE); } + { + pstate->push_new + (RANGE_LOW_BOUND_DEFAULT + | RANGE_HIGH_BOUND_DEFAULT, + operation_up (), operation_up (), + operation_up ()); + } ; /* And each of the four subrange types can also have a stride. */ subrange: exp ':' exp ':' exp %prec ABOVE_COMMA - { write_exp_elt_opcode (pstate, OP_RANGE); - write_exp_elt_longcst (pstate, RANGE_HAS_STRIDE); - write_exp_elt_opcode (pstate, OP_RANGE); } + { + operation_up stride = pstate->pop (); + operation_up high = pstate->pop (); + operation_up low = pstate->pop (); + pstate->push_new + (RANGE_STANDARD | RANGE_HAS_STRIDE, + std::move (low), std::move (high), + std::move (stride)); + } ; subrange: exp ':' ':' exp %prec ABOVE_COMMA - { write_exp_elt_opcode (pstate, OP_RANGE); - write_exp_elt_longcst (pstate, - (RANGE_HIGH_BOUND_DEFAULT - | RANGE_HAS_STRIDE)); - write_exp_elt_opcode (pstate, OP_RANGE); } + { + operation_up stride = pstate->pop (); + operation_up low = pstate->pop (); + pstate->push_new + (RANGE_HIGH_BOUND_DEFAULT + | RANGE_HAS_STRIDE, + std::move (low), operation_up (), + std::move (stride)); + } ; subrange: ':' exp ':' exp %prec ABOVE_COMMA - { write_exp_elt_opcode (pstate, OP_RANGE); - write_exp_elt_longcst (pstate, - (RANGE_LOW_BOUND_DEFAULT - | RANGE_HAS_STRIDE)); - write_exp_elt_opcode (pstate, OP_RANGE); } + { + operation_up stride = pstate->pop (); + operation_up high = pstate->pop (); + pstate->push_new + (RANGE_LOW_BOUND_DEFAULT + | RANGE_HAS_STRIDE, + operation_up (), std::move (high), + std::move (stride)); + } ; subrange: ':' ':' exp %prec ABOVE_COMMA - { write_exp_elt_opcode (pstate, OP_RANGE); - write_exp_elt_longcst (pstate, - (RANGE_LOW_BOUND_DEFAULT - | RANGE_HIGH_BOUND_DEFAULT - | RANGE_HAS_STRIDE)); - write_exp_elt_opcode (pstate, OP_RANGE); } + { + operation_up stride = pstate->pop (); + pstate->push_new + (RANGE_LOW_BOUND_DEFAULT + | RANGE_HIGH_BOUND_DEFAULT + | RANGE_HAS_STRIDE, + operation_up (), operation_up (), + std::move (stride)); + } ; complexnum: exp ',' exp @@ -372,193 +458,197 @@ complexnum: exp ',' exp ; exp : '(' complexnum ')' - { write_exp_elt_opcode (pstate, OP_COMPLEX); - write_exp_elt_type (pstate, - parse_f_type (pstate) - ->builtin_complex_s16); - write_exp_elt_opcode (pstate, OP_COMPLEX); } + { + operation_up rhs = pstate->pop (); + operation_up lhs = pstate->pop (); + pstate->push_new + (std::move (lhs), std::move (rhs), + parse_f_type (pstate)->builtin_complex_s16); + } ; exp : '(' type ')' exp %prec UNARY - { write_exp_elt_opcode (pstate, UNOP_CAST); - write_exp_elt_type (pstate, $2); - write_exp_elt_opcode (pstate, UNOP_CAST); } + { + pstate->push_new + (pstate->pop (), $2); + } ; exp : exp '%' name - { write_exp_elt_opcode (pstate, STRUCTOP_STRUCT); - write_exp_string (pstate, $3); - write_exp_elt_opcode (pstate, STRUCTOP_STRUCT); } + { + pstate->push_new + (pstate->pop (), copy_name ($3)); + } ; exp : exp '%' name COMPLETE - { pstate->mark_struct_expression (); - write_exp_elt_opcode (pstate, STRUCTOP_STRUCT); - write_exp_string (pstate, $3); - write_exp_elt_opcode (pstate, STRUCTOP_STRUCT); } + { + structop_base_operation *op + = new structop_operation (pstate->pop (), + copy_name ($3)); + pstate->mark_struct_expression (op); + pstate->push (operation_up (op)); + } ; exp : exp '%' COMPLETE - { struct stoken s; - pstate->mark_struct_expression (); - write_exp_elt_opcode (pstate, STRUCTOP_PTR); - s.ptr = ""; - s.length = 0; - write_exp_string (pstate, s); - write_exp_elt_opcode (pstate, STRUCTOP_PTR); } + { + structop_base_operation *op + = new structop_operation (pstate->pop (), ""); + pstate->mark_struct_expression (op); + pstate->push (operation_up (op)); + } + ; /* Binary operators in order of decreasing precedence. */ exp : exp '@' exp - { write_exp_elt_opcode (pstate, BINOP_REPEAT); } + { pstate->wrap2 (); } ; exp : exp STARSTAR exp - { write_exp_elt_opcode (pstate, BINOP_EXP); } + { pstate->wrap2 (); } ; exp : exp '*' exp - { write_exp_elt_opcode (pstate, BINOP_MUL); } + { pstate->wrap2 (); } ; exp : exp '/' exp - { write_exp_elt_opcode (pstate, BINOP_DIV); } + { pstate->wrap2 (); } ; exp : exp '+' exp - { write_exp_elt_opcode (pstate, BINOP_ADD); } + { pstate->wrap2 (); } ; exp : exp '-' exp - { write_exp_elt_opcode (pstate, BINOP_SUB); } + { pstate->wrap2 (); } ; exp : exp LSH exp - { write_exp_elt_opcode (pstate, BINOP_LSH); } + { pstate->wrap2 (); } ; exp : exp RSH exp - { write_exp_elt_opcode (pstate, BINOP_RSH); } + { pstate->wrap2 (); } ; exp : exp EQUAL exp - { write_exp_elt_opcode (pstate, BINOP_EQUAL); } + { pstate->wrap2 (); } ; exp : exp NOTEQUAL exp - { write_exp_elt_opcode (pstate, BINOP_NOTEQUAL); } + { pstate->wrap2 (); } ; exp : exp LEQ exp - { write_exp_elt_opcode (pstate, BINOP_LEQ); } + { pstate->wrap2 (); } ; exp : exp GEQ exp - { write_exp_elt_opcode (pstate, BINOP_GEQ); } + { pstate->wrap2 (); } ; exp : exp LESSTHAN exp - { write_exp_elt_opcode (pstate, BINOP_LESS); } + { pstate->wrap2 (); } ; exp : exp GREATERTHAN exp - { write_exp_elt_opcode (pstate, BINOP_GTR); } + { pstate->wrap2 (); } ; exp : exp '&' exp - { write_exp_elt_opcode (pstate, BINOP_BITWISE_AND); } + { pstate->wrap2 (); } ; exp : exp '^' exp - { write_exp_elt_opcode (pstate, BINOP_BITWISE_XOR); } + { pstate->wrap2 (); } ; exp : exp '|' exp - { write_exp_elt_opcode (pstate, BINOP_BITWISE_IOR); } + { pstate->wrap2 (); } ; exp : exp BOOL_AND exp - { write_exp_elt_opcode (pstate, BINOP_LOGICAL_AND); } + { pstate->wrap2 (); } ; exp : exp BOOL_OR exp - { write_exp_elt_opcode (pstate, BINOP_LOGICAL_OR); } + { pstate->wrap2 (); } ; exp : exp '=' exp - { write_exp_elt_opcode (pstate, BINOP_ASSIGN); } + { pstate->wrap2 (); } ; exp : exp ASSIGN_MODIFY exp - { write_exp_elt_opcode (pstate, BINOP_ASSIGN_MODIFY); - write_exp_elt_opcode (pstate, $2); - write_exp_elt_opcode (pstate, BINOP_ASSIGN_MODIFY); } + { + operation_up rhs = pstate->pop (); + operation_up lhs = pstate->pop (); + pstate->push_new + ($2, std::move (lhs), std::move (rhs)); + } ; exp : INT - { write_exp_elt_opcode (pstate, OP_LONG); - write_exp_elt_type (pstate, $1.type); - write_exp_elt_longcst (pstate, (LONGEST) ($1.val)); - write_exp_elt_opcode (pstate, OP_LONG); } + { + pstate->push_new + ($1.type, $1.val); + } ; exp : NAME_OR_INT { YYSTYPE val; parse_number (pstate, $1.stoken.ptr, $1.stoken.length, 0, &val); - write_exp_elt_opcode (pstate, OP_LONG); - write_exp_elt_type (pstate, val.typed_val.type); - write_exp_elt_longcst (pstate, - (LONGEST)val.typed_val.val); - write_exp_elt_opcode (pstate, OP_LONG); } + pstate->push_new + (val.typed_val.type, + val.typed_val.val); + } ; exp : FLOAT - { write_exp_elt_opcode (pstate, OP_FLOAT); - write_exp_elt_type (pstate, $1.type); - write_exp_elt_floatcst (pstate, $1.val); - write_exp_elt_opcode (pstate, OP_FLOAT); } + { + float_data data; + std::copy (std::begin ($1.val), std::end ($1.val), + std::begin (data)); + pstate->push_new ($1.type, data); + } ; exp : variable ; exp : DOLLAR_VARIABLE - { write_dollar_variable (pstate, $1); } + { pstate->push_dollar ($1); } ; exp : SIZEOF '(' type ')' %prec UNARY - { write_exp_elt_opcode (pstate, OP_LONG); - write_exp_elt_type (pstate, - parse_f_type (pstate) - ->builtin_integer); + { $3 = check_typedef ($3); - write_exp_elt_longcst (pstate, - (LONGEST) TYPE_LENGTH ($3)); - write_exp_elt_opcode (pstate, OP_LONG); } + pstate->push_new + (parse_f_type (pstate)->builtin_integer, + TYPE_LENGTH ($3)); + } ; exp : BOOLEAN_LITERAL - { write_exp_elt_opcode (pstate, OP_BOOL); - write_exp_elt_longcst (pstate, (LONGEST) $1); - write_exp_elt_opcode (pstate, OP_BOOL); - } + { pstate->push_new ($1); } ; exp : STRING_LITERAL { - write_exp_elt_opcode (pstate, OP_STRING); - write_exp_string (pstate, $1); - write_exp_elt_opcode (pstate, OP_STRING); + pstate->push_new + (copy_name ($1)); } ; variable: name_not_typename { struct block_symbol sym = $1.sym; std::string name = copy_name ($1.stoken); - write_exp_symbol_reference (pstate, name.c_str (), - sym); + pstate->push_symbol (name.c_str (), sym); } ; @@ -1436,7 +1526,10 @@ f_language::parser (struct parser_state *par_state) const scoped_restore restore_type_stack = make_scoped_restore (&type_stack, &stack); - return yyparse (); + int result = yyparse (); + if (!result) + pstate->set_operation (pstate->pop ()); + return result; } static void diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 5b65aafe2e1..5767fa562c6 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2021-03-08 Tom Tromey + + * gdb.fortran/debug-expr.exp: Update tests. + 2021-03-08 Tom Tromey * gdb.base/debug-expr.exp: Update expected dump output. diff --git a/gdb/testsuite/gdb.fortran/debug-expr.exp b/gdb/testsuite/gdb.fortran/debug-expr.exp index fd63ea7b81a..ca1fb9755aa 100644 --- a/gdb/testsuite/gdb.fortran/debug-expr.exp +++ b/gdb/testsuite/gdb.fortran/debug-expr.exp @@ -42,10 +42,10 @@ gdb_continue_to_breakpoint "Break Here" gdb_test_no_output "set debug expression 1" gdb_test_debug_expr "print obj%three(1)%two(1)%one(1)%i" "\\\$$decimal = 1" gdb_test_debug_expr "print .TRUE." [multi_line \ - "" \ - "\\s+0\\s+OP_BOOL\\s+TRUE" \ + "Operation: OP_BOOL" \ + " Constant: .*1" \ "\\\$$decimal = \.TRUE\."] gdb_test_debug_expr "print .FALSE." [multi_line \ - "" \ - "\\s+0\\s+OP_BOOL\\s+FALSE" \ + "Operation: OP_BOOL" \ + " Constant: .*0" \ "\\\$$decimal = \.FALSE\."] -- 2.30.2