From d390b380e191eb4e2482e06f5ffef95e625b07e1 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Marcelina=20Ko=C5=9Bcielnicka?= <mwk@0x04.net>
Date: Sat, 17 Oct 2020 22:20:47 +0200
Subject: [PATCH] memory_unpack: Use Mem helpers.

---
 passes/memory/memory_unpack.cc | 116 +++------------------------------
 1 file changed, 10 insertions(+), 106 deletions(-)

diff --git a/passes/memory/memory_unpack.cc b/passes/memory/memory_unpack.cc
index d04d4ba7a..16b57d9c3 100644
--- a/passes/memory/memory_unpack.cc
+++ b/passes/memory/memory_unpack.cc
@@ -17,114 +17,12 @@
  *
  */
 
-#include "kernel/register.h"
-#include "kernel/log.h"
-#include <sstream>
-#include <algorithm>
-#include <stdlib.h>
+#include "kernel/yosys.h"
+#include "kernel/mem.h"
 
 USING_YOSYS_NAMESPACE
 PRIVATE_NAMESPACE_BEGIN
 
-void handle_memory(RTLIL::Module *module, RTLIL::Cell *memory)
-{
-	log("Creating $memrd and $memwr for memory `%s' in module `%s':\n",
-			memory->name.c_str(), module->name.c_str());
-
-	RTLIL::IdString mem_name = RTLIL::escape_id(memory->parameters.at(ID::MEMID).decode_string());
-
-	while (module->memories.count(mem_name) != 0)
-		mem_name = mem_name.str() + stringf("_%d", autoidx++);
-
-	RTLIL::Memory *mem = new RTLIL::Memory;
-	mem->name = mem_name;
-	mem->width = memory->parameters.at(ID::WIDTH).as_int();
-	mem->start_offset = memory->parameters.at(ID::OFFSET).as_int();
-	mem->size = memory->parameters.at(ID::SIZE).as_int();
-	module->memories[mem_name] = mem;
-
-	int abits = memory->parameters.at(ID::ABITS).as_int();
-	int num_rd_ports = memory->parameters.at(ID::RD_PORTS).as_int();
-	int num_wr_ports = memory->parameters.at(ID::WR_PORTS).as_int();
-
-	for (int i = 0; i < num_rd_ports; i++)
-	{
-		RTLIL::Cell *cell = module->addCell(NEW_ID, ID($memrd));
-		cell->parameters[ID::MEMID] = mem_name.str();
-		cell->parameters[ID::ABITS] = memory->parameters.at(ID::ABITS);
-		cell->parameters[ID::WIDTH] = memory->parameters.at(ID::WIDTH);
-		cell->parameters[ID::CLK_ENABLE] = RTLIL::SigSpec(memory->parameters.at(ID::RD_CLK_ENABLE)).extract(i, 1).as_const();
-		cell->parameters[ID::CLK_POLARITY] = RTLIL::SigSpec(memory->parameters.at(ID::RD_CLK_POLARITY)).extract(i, 1).as_const();
-		cell->parameters[ID::TRANSPARENT] = RTLIL::SigSpec(memory->parameters.at(ID::RD_TRANSPARENT)).extract(i, 1).as_const();
-		cell->setPort(ID::CLK, memory->getPort(ID::RD_CLK).extract(i, 1));
-		cell->setPort(ID::EN, memory->getPort(ID::RD_EN).extract(i, 1));
-		cell->setPort(ID::ADDR, memory->getPort(ID::RD_ADDR).extract(i*abits, abits));
-		cell->setPort(ID::DATA, memory->getPort(ID::RD_DATA).extract(i*mem->width, mem->width));
-	}
-
-	for (int i = 0; i < num_wr_ports; i++)
-	{
-		RTLIL::Cell *cell = module->addCell(NEW_ID, ID($memwr));
-		cell->parameters[ID::MEMID] = mem_name.str();
-		cell->parameters[ID::ABITS] = memory->parameters.at(ID::ABITS);
-		cell->parameters[ID::WIDTH] = memory->parameters.at(ID::WIDTH);
-		cell->parameters[ID::CLK_ENABLE] = RTLIL::SigSpec(memory->parameters.at(ID::WR_CLK_ENABLE)).extract(i, 1).as_const();
-		cell->parameters[ID::CLK_POLARITY] = RTLIL::SigSpec(memory->parameters.at(ID::WR_CLK_POLARITY)).extract(i, 1).as_const();
-		cell->parameters[ID::PRIORITY] = i;
-		cell->setPort(ID::CLK, memory->getPort(ID::WR_CLK).extract(i, 1));
-		cell->setPort(ID::EN, memory->getPort(ID::WR_EN).extract(i*mem->width, mem->width));
-		cell->setPort(ID::ADDR, memory->getPort(ID::WR_ADDR).extract(i*abits, abits));
-		cell->setPort(ID::DATA, memory->getPort(ID::WR_DATA).extract(i*mem->width, mem->width));
-	}
-
-	Const initval = memory->parameters.at(ID::INIT);
-	RTLIL::Cell *last_init_cell = nullptr;
-	SigSpec last_init_data;
-	int last_init_addr=0;
-
-	for (int i = 0; i < GetSize(initval) && i/mem->width < (1 << abits); i += mem->width) {
-		Const val = initval.extract(i, mem->width, State::Sx);
-		for (auto bit : val.bits)
-			if (bit != State::Sx)
-				goto found_non_undef_initval;
-		continue;
-	found_non_undef_initval:
-		if (last_init_cell && last_init_addr+1 == i/mem->width) {
-			last_init_cell->parameters[ID::WORDS] = last_init_cell->parameters[ID::WORDS].as_int() + 1;
-			last_init_data.append(val);
-			last_init_addr++;
-		} else {
-			if (last_init_cell)
-				last_init_cell->setPort(ID::DATA, last_init_data);
-			RTLIL::Cell *cell = module->addCell(NEW_ID, ID($meminit));
-			cell->parameters[ID::MEMID] = mem_name.str();
-			cell->parameters[ID::ABITS] = memory->parameters.at(ID::ABITS);
-			cell->parameters[ID::WIDTH] = memory->parameters.at(ID::WIDTH);
-			cell->parameters[ID::WORDS] = 1;
-			cell->parameters[ID::PRIORITY] = i/mem->width;
-			cell->setPort(ID::ADDR, SigSpec(i/mem->width, abits));
-			last_init_cell = cell;
-			last_init_addr = i/mem->width;
-			last_init_data = val;
-		}
-	}
-
-	if (last_init_cell)
-		last_init_cell->setPort(ID::DATA, last_init_data);
-
-	module->remove(memory);
-}
-
-void handle_module(RTLIL::Design *design, RTLIL::Module *module)
-{
-	std::vector<RTLIL::IdString> memcells;
-	for (auto cell : module->cells())
-		if (cell->type == ID($mem) && design->selected(module, cell))
-			memcells.push_back(cell->name);
-	for (auto &it : memcells)
-		handle_memory(module, module->cell(it));
-}
-
 struct MemoryUnpackPass : public Pass {
 	MemoryUnpackPass() : Pass("memory_unpack", "unpack multi-port memory cells") { }
 	void help() override
@@ -140,8 +38,14 @@ struct MemoryUnpackPass : public Pass {
 	void execute(std::vector<std::string> args, RTLIL::Design *design) override {
 		log_header(design, "Executing MEMORY_UNPACK pass (generating $memrd/$memwr cells form $mem cells).\n");
 		extra_args(args, 1, design);
-		for (auto module : design->selected_modules())
-			handle_module(design, module);
+		for (auto module : design->selected_modules()) {
+			for (auto &mem : Mem::get_selected_memories(module)) {
+				if (mem.packed) {
+					mem.packed = false;
+					mem.emit();
+				}
+			}
+		}
 	}
 } MemoryUnpackPass;
 
-- 
2.30.2