From d47032b7ca85852acb1d2bc645f477ffee4373fc Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Thu, 6 Sep 2018 14:44:17 -0600 Subject: [PATCH] Style the gdb welcome message This changes gdb to style the welcome message that is shown by default. The styling is only done interactively. gdb/ChangeLog 2018-12-28 Tom Tromey * top.c (print_gdb_version): Style gdb version number. gdb/testsuite/ChangeLog 2018-12-28 Tom Tromey * gdb.base/style.exp: Add test for version number styling. --- gdb/ChangeLog | 4 ++++ gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.base/style.exp | 6 ++++++ gdb/top.c | 9 ++++++++- 4 files changed, 22 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index aa98a94fb4b..dd19b80f4f4 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2018-12-28 Tom Tromey + + * top.c (print_gdb_version): Style gdb version number. + 2018-12-28 Tom Tromey * printcmd.c (print_address_symbolic): Style function name. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 78c8da4e45d..3d262d331f7 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2018-12-28 Tom Tromey + + * gdb.base/style.exp: Add test for version number styling. + 2018-12-28 Tom Tromey * gdb.base/style.exp: Add test for print_address_symbolic. diff --git a/gdb/testsuite/gdb.base/style.exp b/gdb/testsuite/gdb.base/style.exp index 2978d82c053..b72c2ab1fa0 100644 --- a/gdb/testsuite/gdb.base/style.exp +++ b/gdb/testsuite/gdb.base/style.exp @@ -44,4 +44,10 @@ save_vars { env(TERM) } { gdb_test "break main" "file $base_file_expr.*" gdb_test "print &main" " = .* <$main_expr>" + + gdb_exit + gdb_spawn + + gdb_test "" "\033\\\[35;1mGNU gdb.*\033\\\[m.*" \ + "version is styled" } diff --git a/gdb/top.c b/gdb/top.c index 4884888bec4..4bcb4e28fbc 100644 --- a/gdb/top.c +++ b/gdb/top.c @@ -1281,7 +1281,14 @@ print_gdb_version (struct ui_file *stream, bool interactive) program to parse, and is just canonical program name and version number, which starts after last space. */ - fprintf_filtered (stream, "GNU gdb %s%s\n", PKGVERSION, version); + ui_file_style style; + if (interactive) + { + ui_file_style nstyle = { ui_file_style::MAGENTA, ui_file_style::NONE, + ui_file_style::BOLD }; + style = nstyle; + } + fprintf_styled (stream, style, "GNU gdb %s%s\n", PKGVERSION, version); /* Second line is a copyright notice. */ -- 2.30.2