From d4cb7acdd8134607c321fc33c91696d672f49b1d Mon Sep 17 00:00:00 2001 From: Dave Korn Date: Fri, 15 Oct 2010 16:09:36 +0000 Subject: [PATCH] Fix potential use-after-free bugs. ld/ChangeLog: * plugin.c (add_input_file): Take copy of input string. (add_input_library): Likewise. (set_extra_library_path): Likewise. --- ld/ChangeLog | 6 ++++++ ld/plugin.c | 8 +++++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/ld/ChangeLog b/ld/ChangeLog index d171298e810..85c784af459 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,9 @@ +2010-10-15 Dave Korn + + * plugin.c (add_input_file): Take copy of input string. + (add_input_library): Likewise. + (set_extra_library_path): Likewise. + 2010-10-14 Dave Korn Apply LD plugin patch series (part 6/6). diff --git a/ld/plugin.c b/ld/plugin.c index b484bd045a5..0c88ef8beaf 100644 --- a/ld/plugin.c +++ b/ld/plugin.c @@ -433,7 +433,8 @@ static enum ld_plugin_status add_input_file (const char *pathname) { ASSERT (called_plugin); - if (!lang_add_input_file (pathname, lang_input_file_is_file_enum, NULL)) + if (!lang_add_input_file (xstrdup (pathname), lang_input_file_is_file_enum, + NULL)) return LDPS_ERR; return LDPS_OK; } @@ -443,7 +444,8 @@ static enum ld_plugin_status add_input_library (const char *pathname) { ASSERT (called_plugin); - if (!lang_add_input_file (pathname, lang_input_file_is_l_enum, NULL)) + if (!lang_add_input_file (xstrdup (pathname), lang_input_file_is_l_enum, + NULL)) return LDPS_ERR; return LDPS_OK; } @@ -454,7 +456,7 @@ static enum ld_plugin_status set_extra_library_path (const char *path) { ASSERT (called_plugin); - ldfile_add_library_path (path, FALSE); + ldfile_add_library_path (xstrdup (path), FALSE); return LDPS_OK; } -- 2.30.2