From d5548709911e5961c5cfbd4c32002815d98bc694 Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Fri, 27 Apr 2012 12:17:50 +0000 Subject: [PATCH] re PR target/53138 (spaceship operator miscompiled) 2012-04-27 Paolo Bonzini PR target/53138 * config/i386/i386.md (x86_movcc_0_m1_neg): Add clobber. testsuite: 2012-04-27 Paolo Bonzini PR target/53138 * gcc.c-torture/execute/20120427-1.c: New testcase. From-SVN: r186904 --- gcc/ChangeLog | 5 +++ gcc/config/i386/i386.md | 3 +- gcc/testsuite/ChangeLog | 5 +++ .../gcc.c-torture/execute/20120427-1.c | 36 +++++++++++++++++++ 4 files changed, 48 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.c-torture/execute/20120427-1.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 88b54acf000..152bbe1f6a3 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2012-04-27 Paolo Bonzini + + PR target/53138 + * config/i386/i386.md (x86_movcc_0_m1_neg): Add clobber. + 2012-04-27 Richard Guenther * tree-flow.h (is_hidden_global_store): Remove. diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index 60439f9fbd6..28d2f9ee023 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -16439,7 +16439,8 @@ (define_insn "*x86_movcc_0_m1_neg" [(set (match_operand:SWI48 0 "register_operand" "=r") (neg:SWI48 (match_operator 1 "ix86_carry_flag_operator" - [(reg FLAGS_REG) (const_int 0)])))] + [(reg FLAGS_REG) (const_int 0)]))) + (clobber (reg:CC FLAGS_REG))] "" "sbb{}\t%0, %0" [(set_attr "type" "alu") diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 2109f5d376e..0c41cc52e92 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2012-04-27 Paolo Bonzini + + PR target/53138 + * gcc.c-torture/execute/20120427-1.c: New testcase. + 2012-04-27 Marc Glisse PR middle-end/27139 diff --git a/gcc/testsuite/gcc.c-torture/execute/20120427-1.c b/gcc/testsuite/gcc.c-torture/execute/20120427-1.c new file mode 100644 index 00000000000..46ed76ae943 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/20120427-1.c @@ -0,0 +1,36 @@ +typedef struct sreal +{ + unsigned sig; /* Significant. */ + int exp; /* Exponent. */ +} sreal; + +sreal_compare (sreal *a, sreal *b) +{ + if (a->exp > b->exp) + return 1; + if (a->exp < b->exp) + return -1; + if (a->sig > b->sig) + return 1; + return -(a->sig < b->sig); +} + +sreal a[] = { + { 0, 0 }, + { 1, 0 }, + { 0, 1 }, + { 1, 1 } +}; + +int main() +{ + int i, j; + for (i = 0; i <= 3; i++) { + for (j = 0; j < 3; j++) { + if (i < j && sreal_compare(&a[i], &a[j]) != -1) abort(); + if (i == j && sreal_compare(&a[i], &a[j]) != 0) abort(); + if (i > j && sreal_compare(&a[i], &a[j]) != 1) abort(); + } + } + return 0; +} -- 2.30.2