From d55c1ffd497193b56ee9f7540d5b0eadf6717c42 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Wed, 26 Jun 2019 10:26:18 +0200 Subject: [PATCH] re PR target/90991 (_mm_loadu_ps instrinsic translates to vmovaps in combination with _mm512_insertf32x4) PR target/90991 * config/i386/sse.md (*_vinsert_0): Use vmovupd, vmovups, vmovdqu, vmovdqu32 or vmovdqu64 instead of the aligned insns if operands[2] is misaligned_operand. * gcc.target/i386/avx512dq-pr90991-1.c: New test. From-SVN: r272674 --- gcc/ChangeLog | 8 ++++ gcc/config/i386/sse.md | 26 +++++++--- gcc/testsuite/ChangeLog | 5 ++ .../gcc.target/i386/avx512dq-pr90991-1.c | 47 +++++++++++++++++++ 4 files changed, 80 insertions(+), 6 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/avx512dq-pr90991-1.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index f8d3574326b..bd65d2a3a43 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2019-06-26 Jakub Jelinek + + PR target/90991 + * config/i386/sse.md + (*_vinsert_0): Use vmovupd, + vmovups, vmovdqu, vmovdqu32 or vmovdqu64 instead of the aligned + insns if operands[2] is misaligned_operand. + 2019-06-26 Li Jia He * config/rs6000/rs6000.h (TARGET_MADDLD): Remove the restriction of diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md index abf7d987e12..29f16bc558f 100644 --- a/gcc/config/i386/sse.md +++ b/gcc/config/i386/sse.md @@ -13747,15 +13747,29 @@ switch (mode) { case E_V8DFmode: - return "vmovapd\t{%2, %x0|%x0, %2}"; + if (misaligned_operand (operands[2], mode)) + return "vmovupd\t{%2, %x0|%x0, %2}"; + else + return "vmovapd\t{%2, %x0|%x0, %2}"; case E_V16SFmode: - return "vmovaps\t{%2, %x0|%x0, %2}"; + if (misaligned_operand (operands[2], mode)) + return "vmovups\t{%2, %x0|%x0, %2}"; + else + return "vmovaps\t{%2, %x0|%x0, %2}"; case E_V8DImode: - return which_alternative == 2 ? "vmovdqa64\t{%2, %x0|%x0, %2}" - : "vmovdqa\t{%2, %x0|%x0, %2}"; + if (misaligned_operand (operands[2], mode)) + return which_alternative == 2 ? "vmovdqu64\t{%2, %x0|%x0, %2}" + : "vmovdqu\t{%2, %x0|%x0, %2}"; + else + return which_alternative == 2 ? "vmovdqa64\t{%2, %x0|%x0, %2}" + : "vmovdqa\t{%2, %x0|%x0, %2}"; case E_V16SImode: - return which_alternative == 2 ? "vmovdqa32\t{%2, %x0|%x0, %2}" - : "vmovdqa\t{%2, %x0|%x0, %2}"; + if (misaligned_operand (operands[2], mode)) + return which_alternative == 2 ? "vmovdqu32\t{%2, %x0|%x0, %2}" + : "vmovdqu\t{%2, %x0|%x0, %2}"; + else + return which_alternative == 2 ? "vmovdqa32\t{%2, %x0|%x0, %2}" + : "vmovdqa\t{%2, %x0|%x0, %2}"; default: gcc_unreachable (); } diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 5b54f28fbd8..a77eb7e04c6 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2019-06-26 Jakub Jelinek + + PR target/90991 + * gcc.target/i386/avx512dq-pr90991-1.c: New test. + 2019-06-26 Li Jia He * gcc.target/powerpc/maddld-1.c: New testcase. diff --git a/gcc/testsuite/gcc.target/i386/avx512dq-pr90991-1.c b/gcc/testsuite/gcc.target/i386/avx512dq-pr90991-1.c new file mode 100644 index 00000000000..6c968126b7d --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/avx512dq-pr90991-1.c @@ -0,0 +1,47 @@ +/* PR target/90991 */ +/* { dg-do compile } */ +/* { dg-options "-O2 -mavx512dq -masm=att" } */ +/* { dg-final { scan-assembler-times "vmovaps\[ \t]\+\\(\[^\n\r]*\\), %xmm0" 1 } } */ +/* { dg-final { scan-assembler-times "vmovapd\[ \t]\+\\(\[^\n\r]*\\), %xmm0" 1 } } */ +/* { dg-final { scan-assembler-times "vmovdqa\[ \t]\+\\(\[^\n\r]*\\), %xmm0" 1 } } */ +/* { dg-final { scan-assembler-times "vmovups\[ \t]\+\\(\[^\n\r]*\\), %xmm0" 1 } } */ +/* { dg-final { scan-assembler-times "vmovupd\[ \t]\+\\(\[^\n\r]*\\), %xmm0" 1 } } */ +/* { dg-final { scan-assembler-times "vmovdqu\[ \t]\+\\(\[^\n\r]*\\), %xmm0" 1 } } */ + +#include + +__m512 +f1 (void *a) +{ + return _mm512_insertf32x4 (_mm512_set1_ps (0.0f), _mm_load_ps (a), 0); +} + +__m512d +f2 (void *a) +{ + return _mm512_insertf64x2 (_mm512_set1_pd (0.0), _mm_load_pd (a), 0); +} + +__m512i +f3 (void *a) +{ + return _mm512_inserti32x4 (_mm512_set1_epi32 (0), _mm_load_si128 (a), 0); +} + +__m512 +f4 (void *a) +{ + return _mm512_insertf32x4 (_mm512_set1_ps (0.0f), _mm_loadu_ps (a), 0); +} + +__m512d +f5 (void *a) +{ + return _mm512_insertf64x2 (_mm512_set1_pd (0.0), _mm_loadu_pd (a), 0); +} + +__m512i +f6 (void *a) +{ + return _mm512_inserti32x4 (_mm512_set1_epi32 (0), _mm_loadu_si128 (a), 0); +} -- 2.30.2