From d589eddc8be5240632d42ae1931b0b6a82ff524c Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Tue, 24 Apr 2018 18:49:22 +0100 Subject: [PATCH] glsl/tests/glcpp: reinstate "error out if no tests found" With the recent rework of converting the shell script to a python one the check for actual tests was dropped. Bring that back, since it was explicitly added considering we had a ~2 year period, during which the tests were not run. v2: use raise Exception() over print() & return false (Dylan) Fixes: db8cd8e36771 ("glcpp/tests: Convert shell scripts to a python script") Cc: Dylan Baker Signed-off-by: Emil Velikov --- src/compiler/glsl/glcpp/tests/glcpp_test.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/compiler/glsl/glcpp/tests/glcpp_test.py b/src/compiler/glsl/glcpp/tests/glcpp_test.py index cdc63b3ac2a..8ac5d7cb0a1 100755 --- a/src/compiler/glsl/glcpp/tests/glcpp_test.py +++ b/src/compiler/glsl/glcpp/tests/glcpp_test.py @@ -119,6 +119,9 @@ def test_unix(args): for l in diff: print(l, file=sys.stderr) + if not total: + raise Exception('Could not find any tests.') + print('{}/{}'.format(passed, total), 'tests returned correct results') return total == passed @@ -155,6 +158,9 @@ def _replace_test(args, replace): for l in diff: print(l, file=sys.stderr) + if not total: + raise Exception('Could not find any tests.') + print('{}/{}'.format(passed, total), 'tests returned correct results') return total == passed @@ -197,6 +203,9 @@ def test_valgrind(args): print('FAIL') print(log, file=sys.stderr) + if not total: + raise Exception('Could not find any tests.') + print('{}/{}'.format(passed, total), 'tests returned correct results') return total == passed -- 2.30.2