From d71a9badda20d48bcd4031f030d2d0901f837261 Mon Sep 17 00:00:00 2001 From: Alberto Gonzalez Date: Fri, 19 Jun 2020 20:57:27 +0000 Subject: [PATCH] dict: Remove guard for past-the-end iterators that might mask problems in static analysis. Co-Authored-By: whitequark --- kernel/hashlib.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/hashlib.h b/kernel/hashlib.h index 52dfd1280..a523afadd 100644 --- a/kernel/hashlib.h +++ b/kernel/hashlib.h @@ -363,7 +363,7 @@ public: public: const_iterator() { } const_iterator operator++() { index--; return *this; } - const_iterator operator+=(int amt) { index -= amt; if(index < 0) index = -1; return *this; } + const_iterator operator+=(int amt) { index -= amt; return *this; } bool operator<(const const_iterator &other) const { return index > other.index; } bool operator==(const const_iterator &other) const { return index == other.index; } bool operator!=(const const_iterator &other) const { return index != other.index; } @@ -381,7 +381,7 @@ public: public: iterator() { } iterator operator++() { index--; return *this; } - iterator operator+=(int amt) { index -= amt; if(index < 0) index = -1; return *this; } + iterator operator+=(int amt) { index -= amt; return *this; } bool operator<(const iterator &other) const { return index > other.index; } bool operator==(const iterator &other) const { return index == other.index; } bool operator!=(const iterator &other) const { return index != other.index; } -- 2.30.2