From d8221f45584159193e29130db4628f7d0b2b42c7 Mon Sep 17 00:00:00 2001 From: Thomas Quinot Date: Fri, 10 Apr 2009 15:12:15 +0000 Subject: [PATCH] sem_ch6.ads (Check_Subtype_Conformant): Add ??? comment for undocumented formal. 2009-04-10 Thomas Quinot * sem_ch6.ads (Check_Subtype_Conformant): Add ??? comment for undocumented formal. Minor reformatting * a-direio.ads: Fix typo in comment * sem_ch3.adb, g-dirope.adb, sem_type.adb, sem_ch12.adb, sem_case.adb, errout.adb, sem_ch4.adb, sem_ch11.adb, exp_dist.adb, sem_ch13.adb: Use uniform phrasing for comment at start of subprogram body. * xsnamest.adb: Add note to explain why we use specific names for the newly generated files instead of generating snames.{ads,adb,h} directly From-SVN: r145918 --- gcc/ada/ChangeLog | 15 +++++++++++++++ gcc/ada/a-direio.ads | 2 +- gcc/ada/errout.adb | 2 +- gcc/ada/exp_dist.adb | 2 +- gcc/ada/g-dirope.adb | 2 +- gcc/ada/sem_case.adb | 2 +- gcc/ada/sem_ch11.adb | 2 +- gcc/ada/sem_ch12.adb | 11 ++++++----- gcc/ada/sem_ch13.adb | 2 +- gcc/ada/sem_ch3.adb | 4 ++-- gcc/ada/sem_ch4.adb | 4 ++-- gcc/ada/sem_ch6.ads | 3 ++- gcc/ada/sem_type.adb | 2 +- gcc/ada/xsnamest.adb | 5 +++++ 14 files changed, 40 insertions(+), 18 deletions(-) diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog index 1a645a185d2..395cf6331f7 100644 --- a/gcc/ada/ChangeLog +++ b/gcc/ada/ChangeLog @@ -1,3 +1,18 @@ +2009-04-10 Thomas Quinot + + * sem_ch6.ads (Check_Subtype_Conformant): Add ??? comment for + undocumented formal. + Minor reformatting + + * a-direio.ads: Fix typo in comment + + * sem_ch3.adb, g-dirope.adb, sem_type.adb, sem_ch12.adb, sem_case.adb, + errout.adb, sem_ch4.adb, sem_ch11.adb, exp_dist.adb, sem_ch13.adb: + Use uniform phrasing for comment at start of subprogram body. + + * xsnamest.adb: Add note to explain why we use specific names for the + newly generated files instead of generating snames.{ads,adb,h} directly + 2009-04-10 Sergey Rybin * vms_data.ads: diff --git a/gcc/ada/a-direio.ads b/gcc/ada/a-direio.ads index 5410d1f012b..1244b2dbfbd 100644 --- a/gcc/ada/a-direio.ads +++ b/gcc/ada/a-direio.ads @@ -170,7 +170,7 @@ private -- Size of an element in storage units. The Max operation here is to ensure -- that we allocate a single byte for zero-sized elements. It's a bit weird -- to instantiate Direct_IO with zero sized elements, but it is legal and - -- this adjustment ensures that we don't get anomolous behavior. + -- this adjustment ensures that we don't get anomalous behavior. pragma Inline (Close); pragma Inline (Create); diff --git a/gcc/ada/errout.adb b/gcc/ada/errout.adb index 68d6409ed43..d2c1caed843 100644 --- a/gcc/ada/errout.adb +++ b/gcc/ada/errout.adb @@ -278,7 +278,7 @@ package body Errout is return; end if; - -- Start processing of new message + -- Start of processing for new message Sindex := Get_Source_File_Index (Flag_Location); Test_Style_Warning_Serious_Msg (Msg); diff --git a/gcc/ada/exp_dist.adb b/gcc/ada/exp_dist.adb index 516a55f46fd..0fc6288604f 100644 --- a/gcc/ada/exp_dist.adb +++ b/gcc/ada/exp_dist.adb @@ -9595,7 +9595,7 @@ package body Exp_Dist is return Nod; end Make_Discriminant_Reference; - -- Start processing for Variant_Part + -- Start of processing for Variant_Part begin Append_To (Stmts, diff --git a/gcc/ada/g-dirope.adb b/gcc/ada/g-dirope.adb index f27336697ab..ad03db8c7b7 100644 --- a/gcc/ada/g-dirope.adb +++ b/gcc/ada/g-dirope.adb @@ -146,7 +146,7 @@ package body GNAT.Directory_Operations is end Check_For_Standard_Dirs; end Basename; - -- Start processing for Base_Name + -- Start of processing for Base_Name begin if Path'Length <= Suffix'Length then diff --git a/gcc/ada/sem_case.adb b/gcc/ada/sem_case.adb index f226c348bde..7afd0d3f718 100644 --- a/gcc/ada/sem_case.adb +++ b/gcc/ada/sem_case.adb @@ -203,7 +203,7 @@ package body Sem_Case is Lo : Uint; Prev_Hi : Uint; - -- Start processing for Check_Choices + -- Start of processing for Check_Choices begin -- Choice_Table must start at 0 which is an unused location used diff --git a/gcc/ada/sem_ch11.adb b/gcc/ada/sem_ch11.adb index 1aa3e7c07f7..8aedaf5be31 100644 --- a/gcc/ada/sem_ch11.adb +++ b/gcc/ada/sem_ch11.adb @@ -156,7 +156,7 @@ package body Sem_Ch11 is return False; end Others_Present; - -- Start processing for Analyze_Exception_Handlers + -- Start of processing for Analyze_Exception_Handlers begin Handler := First (L); diff --git a/gcc/ada/sem_ch12.adb b/gcc/ada/sem_ch12.adb index 739cbafa133..b8e5d888355 100644 --- a/gcc/ada/sem_ch12.adb +++ b/gcc/ada/sem_ch12.adb @@ -6158,12 +6158,13 @@ package body Sem_Ch12 is while Present (E1) and then E1 /= Instance loop if Ekind (E1) = E_Package and then Nkind (Parent (E1)) = N_Package_Renaming_Declaration - and then Renamed_Object (E1) = Pack then - return True; + if Renamed_Object (E1) = Pack then + return True; - elsif Renamed_Object (E1) = P then - return False; + elsif Renamed_Object (E1) = P then + return False; + end if; end if; Next_Entity (E1); @@ -6172,7 +6173,7 @@ package body Sem_Ch12 is return False; end Is_Actual_Of_Previous_Formal; - -- Start processing of Denotes_Formal_Package + -- Start of processing for Denotes_Formal_Package begin if On_Exit then diff --git a/gcc/ada/sem_ch13.adb b/gcc/ada/sem_ch13.adb index f5394dc172d..47ffb42384f 100644 --- a/gcc/ada/sem_ch13.adb +++ b/gcc/ada/sem_ch13.adb @@ -4051,7 +4051,7 @@ package body Sem_Ch13 is end if; end Same_Rep; - -- Start processing for Record_Case + -- Start of processing for Record_Case begin if Has_Discriminants (T1) then diff --git a/gcc/ada/sem_ch3.adb b/gcc/ada/sem_ch3.adb index bc3ffadca9c..70d6ceb4077 100644 --- a/gcc/ada/sem_ch3.adb +++ b/gcc/ada/sem_ch3.adb @@ -8434,7 +8434,7 @@ package body Sem_Ch3 is end if; end Post_Error; - -- Start processing for Check_Completion + -- Start of processing for Check_Completion begin E := First_Entity (Current_Scope); @@ -13243,7 +13243,7 @@ package body Sem_Ch3 is end if; end Tag_Mismatch; - -- Start processing for Find_Type_Name + -- Start of processing for Find_Type_Name begin -- Find incomplete declaration, if one was given diff --git a/gcc/ada/sem_ch4.adb b/gcc/ada/sem_ch4.adb index bd546fa845f..e8199b5efeb 100644 --- a/gcc/ada/sem_ch4.adb +++ b/gcc/ada/sem_ch4.adb @@ -4395,7 +4395,7 @@ package body Sem_Ch4 is end if; end Check_Right_Argument; - -- Start processing for Find_Arithmetic_Types + -- Start of processing for Find_Arithmetic_Types begin if not Is_Overloaded (L) then @@ -4576,7 +4576,7 @@ package body Sem_Ch4 is end if; end Try_One_Interp; - -- Start processing for Find_Comparison_Types + -- Start of processing for Find_Comparison_Types begin -- If left operand is aggregate, the right operand has to diff --git a/gcc/ada/sem_ch6.ads b/gcc/ada/sem_ch6.ads index e54c1e1117c..aecb09af949 100644 --- a/gcc/ada/sem_ch6.ads +++ b/gcc/ada/sem_ch6.ads @@ -116,9 +116,10 @@ package Sem_Ch6 is Err_Loc : Node_Id := Empty; Skip_Controlling_Formals : Boolean := False); -- Check that two callable entities (subprograms, entries, literals) - -- are subtype conformant, post error message if not (RM 6.3.1(16)) + -- are subtype conformant, post error message if not (RM 6.3.1(16)), -- the flag being placed on the Err_Loc node if it is specified, and -- on the appropriate component of the New_Id construct if not. + -- What is the semantics of Skip_Controlling_Formals??? procedure Check_Type_Conformant (New_Id : Entity_Id; diff --git a/gcc/ada/sem_type.adb b/gcc/ada/sem_type.adb index 815986456d8..e7c2125c043 100644 --- a/gcc/ada/sem_type.adb +++ b/gcc/ada/sem_type.adb @@ -2416,7 +2416,7 @@ package body Sem_Type is end if; end Check_Right_Argument; - -- Start processing for Intersect_Types + -- Start of processing for Intersect_Types begin if Etype (L) = Any_Type or else Etype (R) = Any_Type then diff --git a/gcc/ada/xsnamest.adb b/gcc/ada/xsnamest.adb index 2d6e8e97e08..c4c386bd6c8 100644 --- a/gcc/ada/xsnamest.adb +++ b/gcc/ada/xsnamest.adb @@ -185,6 +185,11 @@ begin Open (InB, In_File, "snames.adb-tmpl"); Open (InH, In_File, "snames.h-tmpl"); + -- Note that we do not generate snames.{ads,adb,h} directly. Instead + -- we output them to snames.n{s,b,h} so that Makefiles can use + -- move-if-change to not touch previously generated files if the + -- new ones are identical. + Create (OutS, Out_File, "snames.ns"); Create (OutB, Out_File, "snames.nb"); Create (OutH, Out_File, "snames.nh"); -- 2.30.2