From d92c7521f9b01841f27a16502819081e992dd0f5 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Wed, 6 Jul 2022 09:20:29 +0200 Subject: [PATCH] x86: don't leak sub-architecture accumulated strings While it may not be necessary in i386_target_format() (but then setting the variable to NULL also wouldn't be necessary), at least in the other cases strings may already have accumulated. --- gas/config/tc-i386.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c index e2b618fe302..4829ff8aaad 100644 --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -2738,6 +2738,7 @@ set_cpu_arch (int dummy ATTRIBUTE_UNUSED) check_cpu_arch_compatible (string, cpu_arch[j].flags); cpu_arch_name = cpu_arch[j].name; + free (cpu_sub_arch_name); cpu_sub_arch_name = NULL; cpu_arch_flags = cpu_arch[j].flags; if (flag_code == CODE_64BIT) @@ -13234,6 +13235,7 @@ md_parse_option (int c, const char *arg) continue; cpu_arch_name = cpu_arch[j].name; + free (cpu_sub_arch_name); cpu_sub_arch_name = NULL; cpu_arch_flags = cpu_arch[j].flags; cpu_arch_isa = cpu_arch[j].type; @@ -13897,6 +13899,7 @@ i386_target_format (void) { static const i386_cpu_flags iamcu_flags = CPU_IAMCU_FLAGS; cpu_arch_name = "iamcu"; + free (cpu_sub_arch_name); cpu_sub_arch_name = NULL; cpu_arch_flags = iamcu_flags; cpu_arch_isa = PROCESSOR_IAMCU; -- 2.30.2