From d954b0409407643ba3aa56a7b623e328a9538156 Mon Sep 17 00:00:00 2001 From: Hans-Peter Nilsson Date: Mon, 9 Apr 2001 03:24:32 +0000 Subject: [PATCH] * elflink.h (elf_fix_symbol_flags): For non-default visibilities, only hide symbols marked STV_INTERNAL or STV_HIDDEN. --- bfd/ChangeLog | 5 +++++ bfd/elflink.h | 12 ++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index f26eacf91f6..f16feaa61a8 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2001-04-09 Hans-Peter Nilsson + + * elflink.h (elf_fix_symbol_flags): For non-default visibilities, + only hide symbols marked STV_INTERNAL or STV_HIDDEN. + 2001-04-05 Steven J. Hill * config.bfd (mips*el*-*-linux-gnu*): Use traditional little diff --git a/bfd/elflink.h b/bfd/elflink.h index 9f15e9add0b..554713ba9f3 100644 --- a/bfd/elflink.h +++ b/bfd/elflink.h @@ -3515,12 +3515,16 @@ elf_fix_symbol_flags (h, eif) /* If -Bsymbolic was used (which means to bind references to global symbols to the definition within the shared object), and this symbol was defined in a regular object, then it actually doesn't - need a PLT entry. Likewise, if the symbol has any kind of - visibility (internal, hidden, or protected), it doesn't need a - PLT. */ + need a PLT entry, and we can accomplish that by forcing it local. + Likewise, if the symbol has hidden or internal visibility. + FIXME: It might be that we also do not need a PLT for other + non-hidden visibilities, but we would have to tell that to the + backend specifically; we can't just clear PLT-related data here. */ if ((h->elf_link_hash_flags & ELF_LINK_HASH_NEEDS_PLT) != 0 && eif->info->shared - && (eif->info->symbolic || ELF_ST_VISIBILITY (h->other)) + && (eif->info->symbolic + || ELF_ST_VISIBILITY (h->other) == STV_INTERNAL + || ELF_ST_VISIBILITY (h->other) == STV_HIDDEN) && (h->elf_link_hash_flags & ELF_LINK_HASH_DEF_REGULAR) != 0) { struct elf_backend_data *bed; -- 2.30.2