From da39d3ba57639b715dea7ce68b6a4a3d70dfcb03 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Sat, 21 Nov 2020 18:11:36 +0100 Subject: [PATCH] [gdb/testsuite] Add clang xfail in gdb.base/vla-ptr.exp When running gdb.base/vla-ptr.exp with clang-10, we run into this FAIL: ... (gdb) print td_vla^M $6 = 0x7fffffffd2b0^M (gdb) FAIL: gdb.base/vla-ptr.exp: print td_vla ... Clang 10.0.1 generates the following DWARF for td_vla. A variable DIE: ... <2><19f>: Abbrev Number: 6 (DW_TAG_variable) <1a0> DW_AT_location : 0x39 (location list) <1a4> DW_AT_name : td_vla <1aa> DW_AT_type : <0x1ae> .... with typedef type: ... <2><1ae>: Abbrev Number: 7 (DW_TAG_typedef) <1af> DW_AT_type : <0x1fc> <1b3> DW_AT_name : typedef_vla ... pointing to: ... <1><1fc>: Abbrev Number: 11 (DW_TAG_array_type) <1fd> DW_AT_type : <0x1d3> <2><201>: Abbrev Number: 14 (DW_TAG_subrange_type) <202> DW_AT_type : <0x1f5> ... The subrange type is missing the count attribute. This was filed as llvm PR48247 - "vla var with typedef'd type has incomplete debug info". Mark this as xfail. gdb/testsuite/ChangeLog: 2020-11-21 Tom de Vries * gdb.base/vla-ptr.exp: Add XFAIL. --- gdb/testsuite/ChangeLog | 4 +++ gdb/testsuite/gdb.base/vla-ptr.exp | 40 +++++++++++++++++++++++++++++- 2 files changed, 43 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index eed9e449b3b..b89633fb9ec 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2020-11-21 Tom de Vries + + * gdb.base/vla-ptr.exp: Add XFAIL. + 2020-11-19 Andrew Burgess * gdb.fortran/array-slices-bad.exp: New file. diff --git a/gdb/testsuite/gdb.base/vla-ptr.exp b/gdb/testsuite/gdb.base/vla-ptr.exp index 346ff00c524..23b3383903e 100644 --- a/gdb/testsuite/gdb.base/vla-ptr.exp +++ b/gdb/testsuite/gdb.base/vla-ptr.exp @@ -14,6 +14,7 @@ # along with this program. If not, see . standard_testfile +set using_clang [test_compiler_info clang*] if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { return -1 @@ -38,4 +39,41 @@ gdb_test "print *vla_ptr" " = 2" "print *vla_ptr (bar)" gdb_breakpoint [gdb_get_line_number "vla_func_bp"] gdb_continue_to_breakpoint "vla_func_bp" -gdb_test "print td_vla" " = \\\{4, 5, 6, 7, 8\\\}" + +gdb_test_multiple "print td_vla" "" { + -re -wrap " = \\\{4, 5, 6, 7, 8\\\}" { + pass $gdb_test_name + } + -re -wrap " = $hex" { + if { $using_clang } { + # Clang 10.0.1 fails to generate complete type info, filed as + # llvm PR48247 - "vla var with typedef'd type has incomplete + # debug info". See note below. + xfail $gdb_test_name + # Verify that despite the incomplete type info, the variable is + # there and has the right value. + gdb_test "p *td_vla@5" " = \\\{4, 5, 6, 7, 8\\\}" + } else { + fail $gdb_test_name + } + } +} + +# Clang 10.0.1 generates this DWARF for td_vla: +# +# A variable DIE: +# <2><19f>: Abbrev Number: 6 (DW_TAG_variable) +# <1a0> DW_AT_location : 0x39 (location list) +# <1a4> DW_AT_name : td_vla +# <1aa> DW_AT_type : <0x1ae> +# with type: +# <2><1ae>: Abbrev Number: 7 (DW_TAG_typedef) +# <1af> DW_AT_type : <0x1fc> +# <1b3> DW_AT_name : typedef_vla +# pointing to: +# <1><1fc>: Abbrev Number: 11 (DW_TAG_array_type) +# <1fd> DW_AT_type : <0x1d3> +# <2><201>: Abbrev Number: 14 (DW_TAG_subrange_type) +# <202> DW_AT_type : <0x1f5> +# +# The subrange type is missing the count attribute. -- 2.30.2