From db09fd595743443974ccc14fbdb1c4e3733ab525 Mon Sep 17 00:00:00 2001 From: Chris Forbes Date: Sun, 3 Aug 2014 21:23:31 +1200 Subject: [PATCH] i965/fs/Gen8: Pass sampler_index to generate_tex Signed-off-by: Chris Forbes Reviewed-by: Matt Turner Reviewed-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- .../drivers/dri/i965/gen8_fs_generator.cpp | 18 ++++++++++++------ 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index f3ce4e0cb54..dfb13ea709d 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.h +++ b/src/mesa/drivers/dri/i965/brw_fs.h @@ -717,7 +717,8 @@ private: void generate_fb_write(fs_inst *inst); void generate_linterp(fs_inst *inst, struct brw_reg dst, struct brw_reg *src); - void generate_tex(fs_inst *inst, struct brw_reg dst, struct brw_reg src); + void generate_tex(fs_inst *inst, struct brw_reg dst, struct brw_reg src, + struct brw_reg sampler_index); void generate_math1(fs_inst *inst, struct brw_reg dst, struct brw_reg src); void generate_math2(fs_inst *inst, struct brw_reg dst, struct brw_reg src0, struct brw_reg src1); diff --git a/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp b/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp index 4e53d155bac..f4aae67ae66 100644 --- a/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp +++ b/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp @@ -153,7 +153,8 @@ gen8_fs_generator::generate_linterp(fs_inst *inst, void gen8_fs_generator::generate_tex(fs_inst *ir, struct brw_reg dst, - struct brw_reg src) + struct brw_reg src, + struct brw_reg sampler_index) { int msg_type = -1; int rlen = 4; @@ -238,6 +239,11 @@ gen8_fs_generator::generate_tex(fs_inst *ir, dst = vec16(dst); } + assert(sampler_index.file == BRW_IMMEDIATE_VALUE); + assert(sampler_index.type == BRW_REGISTER_TYPE_UD); + + uint32_t sampler = sampler_index.dw1.ud; + if (ir->header_present) { /* The send-from-GRF for SIMD16 texturing with a header has an extra * hardware register allocated to it, which we need to skip over (since @@ -258,7 +264,7 @@ gen8_fs_generator::generate_tex(fs_inst *ir, brw_imm_ud(ir->texture_offset)); } - if (ir->sampler >= 16) { + if (sampler >= 16) { /* The "Sampler Index" field can only store values between 0 and 15. * However, we can add an offset to the "Sampler State Pointer" * field, effectively selecting a different set of 16 samplers. @@ -271,7 +277,7 @@ gen8_fs_generator::generate_tex(fs_inst *ir, gen8_instruction *add = ADD(get_element_ud(src, 3), get_element_ud(brw_vec8_grf(0, 0), 3), - brw_imm_ud(16 * (ir->sampler / 16) * sampler_state_size)); + brw_imm_ud(16 * (sampler / 16) * sampler_state_size)); gen8_set_mask_control(add, BRW_MASK_DISABLE); } @@ -279,14 +285,14 @@ gen8_fs_generator::generate_tex(fs_inst *ir, } uint32_t surf_index = - prog_data->base.binding_table.texture_start + ir->sampler; + prog_data->base.binding_table.texture_start + sampler; gen8_instruction *inst = next_inst(BRW_OPCODE_SEND); gen8_set_dst(brw, inst, dst); gen8_set_src0(brw, inst, src); gen8_set_sampler_message(brw, inst, surf_index, - ir->sampler % 16, + sampler % 16, msg_type, rlen, ir->mlen, @@ -1137,7 +1143,7 @@ gen8_fs_generator::generate_code(exec_list *instructions) case SHADER_OPCODE_LOD: case SHADER_OPCODE_TG4: case SHADER_OPCODE_TG4_OFFSET: - generate_tex(ir, dst, src[0]); + generate_tex(ir, dst, src[0], src[1]); break; case FS_OPCODE_DDX: -- 2.30.2