From dc46317d1ab1805feacd94297bd9e57b6881c4d3 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Thu, 31 Jan 2019 16:54:43 -0800 Subject: [PATCH] st/mesa: Set pipe_image_view::shader_access in PBO readpixels. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Commit 8b626a22b24089edf90cb1b06e5b1895bb36c61b introduced a new pipe_image_view::shader_access field, indicating the access mode specified in the shader. st/mesa's built-in PBO download shader creates a write-only image buffer, so we should flag it as such. Nobody uses this field yet (Iris will), so we don't need to backport this fix to stable branches. Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_cb_readpixels.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_cb_readpixels.c b/src/mesa/state_tracker/st_cb_readpixels.c index 3e008904eff..f614849b956 100644 --- a/src/mesa/state_tracker/st_cb_readpixels.c +++ b/src/mesa/state_tracker/st_cb_readpixels.c @@ -199,6 +199,7 @@ try_pbo_readpixels(struct st_context *st, struct st_renderbuffer *strb, image.resource = addr.buffer; image.format = dst_format; image.access = PIPE_IMAGE_ACCESS_WRITE; + image.shader_access = PIPE_IMAGE_ACCESS_WRITE; image.u.buf.offset = addr.first_element * addr.bytes_per_pixel; image.u.buf.size = (addr.last_element - addr.first_element + 1) * addr.bytes_per_pixel; -- 2.30.2