From dc4726c23606eee0dddf49dbd6130c5c2ac7d97a Mon Sep 17 00:00:00 2001
From: Steve Chamberlain <sac@cygnus>
Date: Fri, 1 May 1992 20:09:44 +0000
Subject: [PATCH] lint

---
 ld/ChangeLog |  4 ++++
 ld/ldlang.c  | 68 +++++++++++++++++++++++++---------------------------
 ld/ldlex.l   |  8 +++----
 3 files changed, 41 insertions(+), 39 deletions(-)

diff --git a/ld/ChangeLog b/ld/ChangeLog
index d1d09b35e8c..d51e664d478 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,7 @@
+Fri May  1 13:03:41 1992  Steve Chamberlain  (sac@thepub.cygnus.com)
+
+	* ldlex.l, ldlang.c, ldctor.c: lint
+
 Wed Apr 22 12:48:42 1992  Steve Chamberlain  (sac@thepub.cygnus.com)
 
 	* ldlex.l: added CMDFILENAMECHAR state so that you can lex
diff --git a/ld/ldlang.c b/ld/ldlang.c
index 191dd484814..eaa9d4b8658 100644
--- a/ld/ldlang.c
+++ b/ld/ldlang.c
@@ -170,7 +170,6 @@ DEFUN(lang_for_each_statement_worker,(func,  s),
 	case lang_target_statement_enum:
 	case lang_input_section_enum:
 	case lang_input_statement_enum:
-	case lang_fill_statement_enum:
 	case lang_assignment_statement_enum:
 	case lang_padding_statement_enum:
 	case lang_address_statement_enum:
@@ -237,6 +236,7 @@ DEFUN(new_afile, (name, file_type, target),
       CONST lang_input_file_enum_type file_type AND
       CONST char *CONST target)
 {
+
   lang_input_statement_type *p = new_stat(lang_input_statement, 
 					  stat_ptr);
   lang_has_input_file = true;
@@ -815,7 +815,6 @@ DEFUN_VOID(lang_place_undefineds)
 {
   ldlang_undef_chain_list_type *ptr = ldlang_undef_chain_list_head;
   while (ptr != (ldlang_undef_chain_list_type*)NULL) {
-    ldsym_type *sy = ldsym_get(ptr->name);
     asymbol *def;
     asymbol **def_ptr = (asymbol **)ldmalloc((bfd_size_type)(sizeof(asymbol **)));
     def = (asymbol *)bfd_make_empty_symbol(script_file->the_bfd);
@@ -1201,7 +1200,6 @@ DEFUN(print_statement,(s, os),
 	   case lang_address_statement_enum:
 	    fprintf(config.map_file, "address\n");
 	    break;
-	    break;
 	   case lang_object_symbols_statement_enum:
 	    fprintf(config.map_file, "object symbols\n");
 	    break;
@@ -1509,6 +1507,8 @@ DEFUN(lang_size_sections,(s, output_section_statement, prev, fill,
       case lang_input_statement_enum:
 	break;
       case lang_fill_statement_enum:
+	s->fill_statement.output_section =output_section_statement->bfd_section;
+
 	fill = s->fill_statement.fill;
 	break;
       case lang_assignment_statement_enum:
@@ -1740,11 +1740,9 @@ static void
 DEFUN_VOID(lang_check)
 {
   lang_statement_union_type *file;
-
   bfd * input_bfd;
-  unsigned long input_machine;
-  enum bfd_architecture input_architecture;
-
+unsigned long input_machine;
+enum bfd_architecture input_architecture;
   CONST  bfd_arch_info_type *compatible;
 
   for (file = file_chain.head;
@@ -1945,35 +1943,35 @@ DEFUN(lang_set_flags,(ptr, flags),
       int  *ptr AND
       CONST char *flags)
 {
-  boolean state = true;
-*ptr= 0;
+boolean state = false;
+  *ptr= 0;
   while (*flags)
-      {
-	if (*flags == '!') {
-	  state = false;
-	  flags++;
-	}
-	else state = true;
-	switch (*flags) {
-	case 'R':
-/*	  ptr->flag_read = state; */
-	  break;
-	case 'W':
-/*	  ptr->flag_write = state; */
-	  break;
-	case 'X':
-/*	  ptr->flag_executable= state;*/
-	  break;
-	case 'L':
-	case 'I':
-/*	  ptr->flag_loadable= state;*/
-	  break;
-	default:
-	  einfo("%P%F illegal syntax in flags\n");
-	  break;
-	}
-	flags++;
-      }
+  {
+    if (*flags == '!') {
+      state = false;
+      flags++;
+    }
+    else state = true;
+    switch (*flags) {
+     case 'R':
+      /*	  ptr->flag_read = state; */
+      break;
+     case 'W':
+      /*	  ptr->flag_write = state; */
+      break;
+     case 'X':
+      /*	  ptr->flag_executable= state;*/
+      break;
+     case 'L':
+     case 'I':
+      /*	  ptr->flag_loadable= state;*/
+      break;
+     default:
+      einfo("%P%F illegal syntax in flags\n");
+      break;
+    }
+    flags++;
+  }
 }
 
 
diff --git a/ld/ldlex.l b/ld/ldlex.l
index d2f4db3914d..31b85a28ef5 100644
--- a/ld/ldlex.l
+++ b/ld/ldlex.l
@@ -40,7 +40,7 @@ extern int yyparse();
 
 char *buystring();
 
-int lineno = 1;
+unsigned int lineno = 1;
 int old;
 
 #undef YY_INPUT
@@ -168,7 +168,7 @@ WHITE		[ \t\n]+
 			       	}
 
 <MRI,EXPRESSION>"$"([0-9A-Fa-f])+ {
-  				yylval.integer = strtol(yytext+1, 0,16);	
+  				yylval.integer = strtoul(yytext+1, 0,16);	
 				return INT;
 			}
 
@@ -189,11 +189,11 @@ WHITE		[ \t\n]+
 				    default:
 				     base = 10;
 				   }
-				   yylval.integer = strtol(yytext+1, 0, base);	
+				   yylval.integer = strtoul(yytext+1, 0, base);	
 				   return INT;
 				 }
 <DEFSYMEXP,MRI,BOTH,EXPRESSION>"$"?"0x"?([0-9A-Fa-f])+(M|K|m|k)? {
-				  yylval.integer = strtol(yytext,0,hex_mode);
+				  yylval.integer = strtoul(yytext,0,hex_mode);
 				  if (yytext[yyleng-1]=='M'
 					|| yytext[yyleng-1] == 'm') {
 				      yylval.integer *= 1024*1024;
-- 
2.30.2