From dc4b53e129150e85903214fc7cdd3cd437843392 Mon Sep 17 00:00:00 2001 From: Axel Davy Date: Sun, 16 Sep 2018 21:59:55 +0200 Subject: [PATCH] st/nine: Lock the entire buffer in some cases. Previously we had already found that for MANAGED buffers the buffer started dirty (which meant all writes out of bound before the first draw call using the buffer have to be taken into account). Possibly it is the same for the other types of buffers. For now always lock the entire buffer (starting from the offset) for these (except for DYNAMIC buffers, which might hurt performance too much). Fixes: https://github.com/iXit/Mesa-3D/issues/301 Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/buffer9.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/gallium/state_trackers/nine/buffer9.c b/src/gallium/state_trackers/nine/buffer9.c index 69b08e8c10e..5880ee3c1a2 100644 --- a/src/gallium/state_trackers/nine/buffer9.c +++ b/src/gallium/state_trackers/nine/buffer9.c @@ -231,6 +231,14 @@ NineBuffer9_Lock( struct NineBuffer9 *This, user_warn(OffsetToLock != 0); } + /* Write out of bound seems to have to be taken into account for these. + * TODO: Do more tests (is it only at buffer first lock ? etc). + * Since these buffers are supposed to be locked once and never + * writen again (MANAGED or DYNAMIC is used for the other uses cases), + * performance should be unaffected. */ + if (!(This->base.usage & D3DUSAGE_DYNAMIC) && This->base.pool != D3DPOOL_MANAGED) + SizeToLock = This->size - OffsetToLock; + u_box_1d(OffsetToLock, SizeToLock, &box); if (This->base.pool == D3DPOOL_MANAGED) { -- 2.30.2