From dcdec67858b1db5a91c1947569d6085310bfabe6 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Mon, 18 Nov 2019 18:08:50 +0000 Subject: [PATCH] gdb/testsuite: Fix minor bug in skip_btrace*tests procs The two guard functions skip_btrace_tests and skip_btrace_pt_tests have a minor bug, if the check function fails to compile then surely we should skip the btrace tests - currently we return 0 to indicate don't skip. gdb/testsuite/ChangeLog: * lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to compile. (skip_btrace_pt_tests): Likewise. Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301 --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/lib/gdb.exp | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 86f2130c269..6b520e1f118 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2019-11-28 Andrew Burgess + + * lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to + compile. + (skip_btrace_pt_tests): Likewise. + 2019-11-27 Andrew Burgess * gdb.fortran/info-modules.exp: Compile source files in correct diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 828c91dd9e9..4682f5d2f8f 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2942,7 +2942,7 @@ gdb_caching_proc skip_btrace_tests { # Compile a test program. set src { int main() { return 0; } } if {![gdb_simple_compile $me $src executable]} { - return 0 + return 1 } # No error message, compilation succeeded so now run it via gdb. @@ -2993,7 +2993,7 @@ gdb_caching_proc skip_btrace_pt_tests { # Compile a test program. set src { int main() { return 0; } } if {![gdb_simple_compile $me $src executable]} { - return 0 + return 1 } # No error message, compilation succeeded so now run it via gdb. -- 2.30.2