From dd80eb2cff5c415a6623e144119010917922d1f7 Mon Sep 17 00:00:00 2001 From: Mikael Pettersson Date: Thu, 17 Sep 2020 10:45:39 +0100 Subject: [PATCH] Skip IFUNC relocations in debug sections ignored by ld.so. Fixes some ld test failures on sparc-linux-gnu. PR ld/18808 * elfxx-sparc.c (_bfd_sparc_elf_relocate_section): Skip IFUNC relocations in debug sections, change abort to _bfd_error_handler. --- bfd/ChangeLog | 6 ++++++ bfd/elfxx-sparc.c | 20 +++++++++++++++++++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 75904fe20b2..66463bdbabe 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2020-09-17 Mikael Pettersson + + PR ld/18808 + * elfxx-sparc.c (_bfd_sparc_elf_relocate_section): Skip IFUNC + relocations in debug sections, change abort to _bfd_error_handler. + 2020-09-16 H.J. Lu PR ld/26583 diff --git a/bfd/elfxx-sparc.c b/bfd/elfxx-sparc.c index 273789e5f7d..be82612aefc 100644 --- a/bfd/elfxx-sparc.c +++ b/bfd/elfxx-sparc.c @@ -2904,7 +2904,25 @@ _bfd_sparc_elf_relocate_section (bfd *output_bfd, STT_GNU_IFUNC symbol as STT_FUNC. */ if (elf_section_type (input_section) == SHT_NOTE) goto skip_ifunc; - abort (); + + /* Dynamic relocs are not propagated for SEC_DEBUGGING + sections because such sections are not SEC_ALLOC and + thus ld.so will not process them. */ + if ((input_section->flags & SEC_ALLOC) == 0 + && (input_section->flags & SEC_DEBUGGING) != 0) + continue; + + _bfd_error_handler + /* xgettext:c-format */ + (_("%pB(%pA+%#" PRIx64 "): " + "unresolvable %s relocation against symbol `%s'"), + input_bfd, + input_section, + (uint64_t) rel->r_offset, + howto->name, + h->root.root.string); + bfd_set_error (bfd_error_bad_value); + return FALSE; } plt_sec = htab->elf.splt; -- 2.30.2