From dfc87947b5ac6d6382c225449d4fdce411c7ee66 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 1 Jul 2015 09:32:47 -0700 Subject: [PATCH] Refactor elf_x86_64_convert_mov_to_lea * elf64-x86-64.c (elf_x86_64_convert_mov_to_lea): Refactor. --- bfd/ChangeLog | 4 ++++ bfd/elf64-x86-64.c | 13 +++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 2dd71f26cb7..5c1e94ce961 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,7 @@ +2015-07-01 H.J. Lu + + * elf64-x86-64.c (elf_x86_64_convert_mov_to_lea): Refactor. + 2015-06-30 Nick Clifton PR binutils/18570 diff --git a/bfd/elf64-x86-64.c b/bfd/elf64-x86-64.c index 3022debb99d..a4dfdc830cc 100644 --- a/bfd/elf64-x86-64.c +++ b/bfd/elf64-x86-64.c @@ -2952,16 +2952,21 @@ elf_x86_64_convert_mov_to_lea (bfd *abfd, asection *sec, enum { none, local, global } convert_mov_to_lea; + unsigned int opcode; if (r_type != R_X86_64_GOTPCREL) continue; roff = irel->r_offset; - /* Don't convert R_X86_64_GOTPCREL relocation if it isn't for mov - instruction. */ - if (roff < 2 - || bfd_get_8 (abfd, contents + roff - 2) != 0x8b) + if (roff < 2) + continue; + + opcode = bfd_get_8 (abfd, contents + roff - 2); + + /* PR ld/18591: Don't convert R_X86_64_GOTPCREL relocation if it + isn't for mov instruction. */ + if (opcode != 0x8b) continue; tsec = NULL; -- 2.30.2