From e06963ffef465de9702443d1f3e04b7d34fa5616 Mon Sep 17 00:00:00 2001 From: Andrew Cagney Date: Thu, 15 May 2003 22:23:24 +0000 Subject: [PATCH] 2003-05-15 Andrew Cagney * symtab.h (DEPRECATED_SYMBOL_MATCHES_NAME): Delete macro. * minsyms.c (lookup_minimal_symbol): Inline DEPRECATED_SYMBOL_MATCHES_NAME. Replace STREQ with strcmp. --- gdb/ChangeLog | 4 ++++ gdb/minsyms.c | 10 +++++++++- gdb/symtab.h | 10 ---------- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5e4706f57fc..5802390fc23 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2003-05-15 Andrew Cagney + * symtab.h (DEPRECATED_SYMBOL_MATCHES_NAME): Delete macro. + * minsyms.c (lookup_minimal_symbol): Inline + DEPRECATED_SYMBOL_MATCHES_NAME. Replace STREQ with strcmp. + * c-lang.c (c_printstr): Delete "extern inspect_it" declaration. * p-valprint.c (pascal_object_print_value_fields): Ditto. * p-lang.c (pascal_printstr): Ditto. diff --git a/gdb/minsyms.c b/gdb/minsyms.c index 1f6cb388800..fa7209d2bc6 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -189,7 +189,15 @@ lookup_minimal_symbol (register const char *name, const char *sfile, while (msymbol != NULL && found_symbol == NULL) { - if (DEPRECATED_SYMBOL_MATCHES_NAME (msymbol, name)) + /* FIXME: carlton/2003-02-27: This is an unholy + mixture of linkage names and natural names. If + you want to test the linkage names with strcmp, + do that. If you want to test the natural names + with strcmp_iw, use SYMBOL_MATCHES_NATURAL_NAME. */ + if (strcmp (DEPRECATED_SYMBOL_NAME (msymbol), (name)) == 0 + || (SYMBOL_DEMANGLED_NAME (msymbol) != NULL + && strcmp_iw (SYMBOL_DEMANGLED_NAME (msymbol), + (name)) == 0)) { switch (MSYMBOL_TYPE (msymbol)) { diff --git a/gdb/symtab.h b/gdb/symtab.h index 000ae0edfa3..f8be03b75ab 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -219,16 +219,6 @@ extern char *symbol_demangled_name (struct general_symbol_info *symbol); "foo :: bar (int, long)". Evaluates to zero if the match fails, or nonzero if it succeeds. */ -/* FIXME: carlton/2003-02-27: This is an unholy mixture of linkage - names and natural names. If you want to test the linkage names - with strcmp, do that. If you want to test the natural names with - strcmp_iw, use SYMBOL_MATCHES_NATURAL_NAME. */ - -#define DEPRECATED_SYMBOL_MATCHES_NAME(symbol, name) \ - (STREQ (DEPRECATED_SYMBOL_NAME (symbol), (name)) \ - || (SYMBOL_DEMANGLED_NAME (symbol) != NULL \ - && strcmp_iw (SYMBOL_DEMANGLED_NAME (symbol), (name)) == 0)) - /* Macro that tests a symbol for a match against a specified name string. It tests against SYMBOL_NATURAL_NAME, and it ignores whitespace and trailing parentheses. (See strcmp_iw for details -- 2.30.2