From e0bffbbb5936be8b6a35d868db4226ca1b2365fa Mon Sep 17 00:00:00 2001 From: Jason Merrill Date: Tue, 29 Mar 2016 14:40:02 -0400 Subject: [PATCH] re PR c++/70353 (ICE on __PRETTY_FUNCTION__ in a constexpr function) PR c++/70353 gcc/ * tree-inline.c (remap_decls): Don't add_local_decl if cfun is null. gcc/cp/ * decl.c (make_rtl_for_nonlocal_decl): Don't defer local statics in constexpr functions. From-SVN: r234530 --- gcc/ChangeLog | 4 ++++ gcc/cp/ChangeLog | 6 ++++++ gcc/cp/decl.c | 7 +++++-- gcc/testsuite/g++.dg/cpp0x/constexpr-__func__2.C | 13 +++++++++++++ gcc/tree-inline.c | 3 ++- 5 files changed, 30 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/g++.dg/cpp0x/constexpr-__func__2.C diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 895587a5971..cb6297710d5 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,9 @@ 2016-03-29 Jakub Jelinek + PR c++/70353 + * tree-inline.c (remap_decls): Don't add_local_decl if + cfun is null. + PR tree-optimization/70405 * ssa-iterators.h (num_imm_uses): Add missing braces. diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 2028f7e6d63..91ad5ac341f 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2016-03-29 Jason Merrill + + PR c++/70353 + * decl.c (make_rtl_for_nonlocal_decl): Don't defer local statics + in constexpr functions. + 2016-03-28 Jason Merrill PR c++/70422 diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c index cd5db3f06dc..cfae210da55 100644 --- a/gcc/cp/decl.c +++ b/gcc/cp/decl.c @@ -6251,8 +6251,11 @@ make_rtl_for_nonlocal_decl (tree decl, tree init, const char* asmspec) return; /* We defer emission of local statics until the corresponding - DECL_EXPR is expanded. */ - defer_p = DECL_FUNCTION_SCOPE_P (decl) || DECL_VIRTUAL_P (decl); + DECL_EXPR is expanded. But with constexpr its function might never + be expanded, so go ahead and tell cgraph about the variable now. */ + defer_p = ((DECL_FUNCTION_SCOPE_P (decl) + && !DECL_DECLARED_CONSTEXPR_P (DECL_CONTEXT (decl))) + || DECL_VIRTUAL_P (decl)); /* Defer template instantiations. */ if (DECL_LANG_SPECIFIC (decl) diff --git a/gcc/testsuite/g++.dg/cpp0x/constexpr-__func__2.C b/gcc/testsuite/g++.dg/cpp0x/constexpr-__func__2.C new file mode 100644 index 00000000000..e6782905423 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-__func__2.C @@ -0,0 +1,13 @@ +// PR c++/70353 +// { dg-do link { target c++11 } } + +constexpr const char* ce () +{ + return __func__; +} + +const char *c = ce(); + +int main() +{ +} diff --git a/gcc/tree-inline.c b/gcc/tree-inline.c index 9d4f8f7815d..5206d202bab 100644 --- a/gcc/tree-inline.c +++ b/gcc/tree-inline.c @@ -616,7 +616,8 @@ remap_decls (tree decls, vec **nonlocalized_list, /* We need to add this variable to the local decls as otherwise nothing else will do so. */ if (TREE_CODE (old_var) == VAR_DECL - && ! DECL_EXTERNAL (old_var)) + && ! DECL_EXTERNAL (old_var) + && cfun) add_local_decl (cfun, old_var); if ((!optimize || debug_info_level > DINFO_LEVEL_TERSE) && !DECL_IGNORED_P (old_var) -- 2.30.2