From e0e5e971ae89da1ded13013bb7378dc5f09363af Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Tue, 10 Apr 2018 20:18:53 +0100 Subject: [PATCH] gdb/testsuite: Ensure test links in malloc and free The test associated with the source file gdb.base/share-env-with-gdbserver.c relies on calling malloc and free within the inferior from GDB. However, as the test source itself makes no use of these functions, there's no requirement that they be linked into the test executable. This commit adds a dummy call to malloc and free to ensure they are linked into the test executable. gdb/testsuite/ChangeLog: * gdb.base/share-env-with-gdbserver.c (main): Add call to malloc/free. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/share-env-with-gdbserver.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index a9e1618410f..d908b8537d7 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-07-06 Andrew Burgess + + * gdb.base/share-env-with-gdbserver.c (main): Add call to + malloc/free. + 2018-07-04 Tom de Vries * gdb.dwarf2/dw2-error.exp: Update expected error message. diff --git a/gdb/testsuite/gdb.base/share-env-with-gdbserver.c b/gdb/testsuite/gdb.base/share-env-with-gdbserver.c index 2b821cd854d..213dde3d6e8 100644 --- a/gdb/testsuite/gdb.base/share-env-with-gdbserver.c +++ b/gdb/testsuite/gdb.base/share-env-with-gdbserver.c @@ -29,6 +29,8 @@ my_getenv (const char *name) int main (int argc, char *argv[]) { + /* Call malloc to ensure it is linked in. */ + char *tmp = malloc (1); const char *myvar = getenv ("GDB_TEST_VAR"); if (myvar != NULL) @@ -36,5 +38,6 @@ main (int argc, char *argv[]) else printf ("It failed."); + free (tmp); return 0; /* break-here */ } -- 2.30.2