From e1b8f529d3246b031352882c3eb85fa2ccedd02e Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Mon, 13 Mar 2023 17:20:09 +0100 Subject: [PATCH] [gdb/testsuite] Fix gdb.tui/tui-layout.exp for remote host When running test-case gdb.tui/tui-layout.exp with host board local-remote-host-notty and target board native-gdbserver, I get: ... FAIL: gdb.tui/tui-layout.exp: terminal=dumb: execution=false: layout=asm: \ layout asm (timeout) ... The problem is that the test-case expects that the default "setenv TERM dumb" has effect, which is not the case for remote host. Fix this by skipping the test for remote host. Tested on x86_64-linux. --- gdb/testsuite/gdb.tui/tui-layout.exp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/testsuite/gdb.tui/tui-layout.exp b/gdb/testsuite/gdb.tui/tui-layout.exp index c7fdb1b0c0a..13823387e72 100644 --- a/gdb/testsuite/gdb.tui/tui-layout.exp +++ b/gdb/testsuite/gdb.tui/tui-layout.exp @@ -61,6 +61,10 @@ proc test_layout_or_focus {layout_name terminal execution} { } if {$dumb_terminal} { + if { [is_remote host] } { + # setenv TERM dummy has no effect on remote host. + return + } gdb_test "layout $layout_name" \ "Cannot enable the TUI: terminal doesn't support cursor addressing \\\[TERM=dumb\\\]" } else { -- 2.30.2