From e219f04592373560fe39b7dafd2ef42bbc1124d0 Mon Sep 17 00:00:00 2001 From: Icecream95 Date: Sat, 20 Jun 2020 17:54:19 +1200 Subject: [PATCH] pan/decode: Fix helper invocations when tracing midgard1.flags_lo was being changed when tracing, causing helper invocations to be disabled. This was found by using mprotect to make BOs read only in pandecode_fetch_gpu_mem. Reviewed-by: Tomeu Vizoso Part-of: --- src/panfrost/pandecode/decode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/panfrost/pandecode/decode.c b/src/panfrost/pandecode/decode.c index 76352173b93..1774bedafef 100644 --- a/src/panfrost/pandecode/decode.c +++ b/src/panfrost/pandecode/decode.c @@ -2616,7 +2616,6 @@ pandecode_vertex_tiler_postfix_pre( pandecode_log_cont(",\n"); } else { bool helpers = s->midgard1.flags_lo & MALI_HELPER_INVOCATIONS; - s->midgard1.flags_lo &= ~MALI_HELPER_INVOCATIONS; if (helpers != info.helper_invocations) { pandecode_msg("XXX: expected helpers %u but got %u\n", @@ -2624,7 +2623,8 @@ pandecode_vertex_tiler_postfix_pre( } pandecode_log(".midgard1.flags_lo = "); - pandecode_log_decoded_flags(shader_midgard1_flag_lo_info, s->midgard1.flags_lo); + pandecode_log_decoded_flags(shader_midgard1_flag_lo_info, + s->midgard1.flags_lo & ~MALI_HELPER_INVOCATIONS); pandecode_log_cont(",\n"); pandecode_log(".midgard1.flags_hi = "); -- 2.30.2