From e29ccaac298d04ad4272af2d8b8d7a953c523e28 Mon Sep 17 00:00:00 2001 From: Francisco Jerez Date: Fri, 18 Aug 2017 12:04:55 -0700 Subject: [PATCH] anv: Check that in_fence fd is valid before closing it. Probably harmless, but will overwrite errno with a failure status code. Reported by coverity. CID 1416600: Argument cannot be negative (NEGATIVE_RETURNS) Fixes: 5c4e4932e02 (anv: Implement support for exporting semaphores as FENCE_FD) Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_batch_chain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_batch_chain.c b/src/intel/vulkan/anv_batch_chain.c index 26b5375903b..1e7455f71e1 100644 --- a/src/intel/vulkan/anv_batch_chain.c +++ b/src/intel/vulkan/anv_batch_chain.c @@ -1571,7 +1571,8 @@ anv_cmd_buffer_execbuf(struct anv_device *device, result = anv_device_execbuf(device, &execbuf.execbuf, execbuf.bos); /* Execbuf does not consume the in_fence. It's our job to close it. */ - close(in_fence); + if (in_fence != -1) + close(in_fence); for (uint32_t i = 0; i < num_in_semaphores; i++) { ANV_FROM_HANDLE(anv_semaphore, semaphore, in_semaphores[i]); -- 2.30.2