From e3829d13f6d0615f663d2a85ef4281a4365a947c Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Thu, 5 Apr 2018 16:09:29 -0600 Subject: [PATCH] Add two fall-through comments in rs6000-tdep.c This adds two fall-through comments in rs6000-tdep.c. I looked at the PPC instruction manual and convinced myself that this was correct. And, this isn't a semantic change. However, close review would still be good. 2018-05-04 Tom Tromey * rs6000-tdep.c (ppc_process_record_op4) (ppc_process_record_op63): Add fall-through comment. --- gdb/ChangeLog | 5 +++++ gdb/rs6000-tdep.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index aad783096d2..c0deadf4fb1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-05-04 Tom Tromey + + * rs6000-tdep.c (ppc_process_record_op4) + (ppc_process_record_op63): Add fall-through comment. + 2018-05-04 Tom Tromey * i386-tdep.c (i386_process_record): Add fall-through comment. diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index 425c41df244..c5b49c5f465 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -3969,6 +3969,7 @@ ppc_process_record_op4 (struct gdbarch *gdbarch, struct regcache *regcache, && vra != 7 /* Decimal Convert From National */ && vra != 31) /* Decimal Set Sign */ break; + /* Fall through. */ /* 5.16 Decimal Integer Arithmetic Instructions */ case 1: /* Decimal Add Modulo */ case 65: /* Decimal Subtract Modulo */ @@ -5565,6 +5566,7 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache, case 22: /* Move From FPSCR Control & set RN */ case 23: /* Move From FPSCR Control & set RN Immediate */ record_full_arch_list_add_reg (regcache, tdep->ppc_fpscr_regnum); + /* Fall through. */ case 0: /* Move From FPSCR */ case 24: /* Move From FPSCR Lightweight */ if (PPC_FIELD (insn, 11, 5) == 0 && PPC_RC (insn)) -- 2.30.2