From e3ee27c7b4da421676ca7d77c0953726259890d5 Mon Sep 17 00:00:00 2001 From: Ali Saidi Date: Wed, 29 Oct 2014 23:18:24 -0500 Subject: [PATCH] cpu: Add support to checker for CACHE_BLOCK_ZERO commands. The checker didn't know how to properly validate these new commands. --- src/cpu/checker/cpu.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/cpu/checker/cpu.cc b/src/cpu/checker/cpu.cc index 61c127ec4..f91bad294 100644 --- a/src/cpu/checker/cpu.cc +++ b/src/cpu/checker/cpu.cc @@ -231,6 +231,7 @@ CheckerCPU::writeMem(uint8_t *data, unsigned size, bool checked_flags = false; bool flags_match = true; Addr pAddr = 0x0; + static uint8_t zero_data[64] = {}; int fullSize = size; @@ -304,6 +305,15 @@ CheckerCPU::writeMem(uint8_t *data, unsigned size, unverifiedReq->getExtraData() : true; } + // If the request is to ZERO a cache block, there is no data to check + // against, but it's all zero. We need something to compare to, so use a + // const set of zeros. + if (flags & Request::CACHE_BLOCK_ZERO) { + assert(!data); + assert(sizeof(zero_data) <= fullSize); + data = zero_data; + } + if (unverifiedReq && unverifiedMemData && memcmp(data, unverifiedMemData, fullSize) && extraData) { warn("%lli: Store value does not match value sent to memory! " -- 2.30.2