From e48ef82dd2fc85560d14a45a632c82eaaadca7ce Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Thu, 12 Oct 2017 19:54:34 +0100 Subject: [PATCH] checkpoint.exp: Check for non-"target native" instead of isnative/is_remote This gets rid of a number of FAILs with --target_board=native-extended-gdbserver. The fact that checkpointing does not work has nothing to do with dejagnu's native and remote concepts. It only works with native Linux targets because the implementation is currently baked with linux-nat.c. gdb/testsuite/ChangeLog: 2017-10-12 Pedro Alves Simon Marchi * gdb.base/checkpoint.exp: Don't check is_remote or isnative. Instead skip if there's any gdb_protocol set. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.base/checkpoint.exp | 10 ++++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 8ecdc5051a1..48769145ce8 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2017-10-12 Pedro Alves + Simon Marchi + + * gdb.base/checkpoint.exp: Don't check is_remote or isnative. + Instead skip if there's any gdb_protocol set. + 2017-10-12 Simon Marchi Pedro Alves diff --git a/gdb/testsuite/gdb.base/checkpoint.exp b/gdb/testsuite/gdb.base/checkpoint.exp index 677c3892fd7..b93c5f4d4a2 100644 --- a/gdb/testsuite/gdb.base/checkpoint.exp +++ b/gdb/testsuite/gdb.base/checkpoint.exp @@ -13,10 +13,6 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . */ -if { [is_remote target] || ![isnative] } then { - continue -} - # Until "set follow-fork-mode" and "catch fork" are implemented on # other targets... # @@ -24,6 +20,12 @@ if {![istarget "*-*-linux*"]} then { continue } +# Checkpoint support is currently implemented in the Linux native +# target, so only works with "target native". +if { [target_info gdb_protocol] != "" } { + continue +} + # Must name the source file explicitly, otherwise when driven by # checkpoints-ns.exp, we'd try compiling checkpoints-ns.c, which # doesn't exist. -- 2.30.2