From e49d4f0c378960e3895381eea78ada48cca310fb Mon Sep 17 00:00:00 2001 From: "Yann E. MORIN" Date: Sun, 8 Jun 2014 16:15:12 +0200 Subject: [PATCH] support/scripts: prepare handling virtual packages in generated lists Prepare to tell apart real packages from virtual packages. Currently, the code implicitly recognises only real packages, and discards virtual packages, because of the heuristic used to recognise whether a symbol is a package: - for real package: - symbols : BR2_PACKAGE_FOO - .mk files: foo.mk - for virtual packages: - symbols : BR2_PACKAGE_HAS_FOO - .mk files: foo.mk The current heuristic is to check for each symbol if a corresponding .mk file exists, by stripping 'BR2_PACKAGE_' from the beginning of the symbol, converting the result to lowercase, and checking if a .mk file exists. So, as a side effect, it completely misses the virtual packages [*], which is pretty nice since we get a list with only real packages that the user can indeed select and see in the menuconfig. [*] Except for 'cryptodev' and 'jpeg' which are both virtual packages and normal packages. Except they are not normal packages, they are used to display a choice of the implementation to use. This case will be fixed in follow-up patches. Since we'll soon need to also output the table of virtual packages, we need to teach the _is_package() function to recognise them as well. This patch is the first step into that direction: it introduces a new function _is_real_package() that is just a wrapper to _is_package(), which gains a new parameter, being the type of packages to filter on. No behavioural change is made in this patch, it is just a preparatory patch. Signed-off-by: "Yann E. MORIN" Cc: Samuel Martin Signed-off-by: Thomas Petazzoni --- support/scripts/gen-manual-lists.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/support/scripts/gen-manual-lists.py b/support/scripts/gen-manual-lists.py index b33fcf03da..e234ef1106 100644 --- a/support/scripts/gen-manual-lists.py +++ b/support/scripts/gen-manual-lists.py @@ -183,14 +183,14 @@ class Buildroot: 'target-packages': { 'filename': "package-list", 'root_menu': "Target packages", - 'filter': "_is_package", + 'filter': "_is_real_package", 'sorted': True, 'sub_menu': True, }, 'host-packages': { 'filename': "host-package-list", 'root_menu': "Host utilities", - 'filter': "_is_package", + 'filter': "_is_real_package", 'sorted': True, 'sub_menu': False, }, @@ -238,11 +238,14 @@ class Buildroot: return bool([ symbol for x in symbol.get_referenced_symbols() if x.get_name().startswith(self._deprecated.get_name()) ]) - def _is_package(self, symbol): + def _is_package(self, symbol, type='real'): """ Return True if the symbol is a package or a host package, otherwise False. :param symbol: The symbol to check + :param type: Limit to 'real' or 'virtual' types of packages, + with 'real' being the default. + Note: only 'real' is (implictly) handled for now """ if not self.re_pkg_prefix.match(symbol.get_name()): @@ -280,6 +283,9 @@ class Buildroot: return True return False + def _is_real_package(self, symbol): + return self._is_package(symbol, 'real') + def _get_pkg_name(self, symbol): """ Return the package name of the specified symbol. -- 2.30.2