From e4b52fcaf50dadbed3ebd0e8e9805a61644231e2 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Tue, 5 Feb 2019 13:17:45 +0100 Subject: [PATCH] GCOV: remove misleading branches and calls info for -f option (PR gcov-profile/89000). 2019-02-05 Martin Liska PR gcov-profile/89000 * gcov.c (function_summary): Remove argument. (file_summary): New function. (print_usage): Replace tabs with spaces. (generate_results): Use new function file_summary. From-SVN: r268533 --- gcc/ChangeLog | 8 ++++++++ gcc/gcov.c | 24 +++++++++++++++++------- 2 files changed, 25 insertions(+), 7 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 76a3e18b21c..a6c7f8c6c7a 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2019-02-05 Martin Liska + + PR gcov-profile/89000 + * gcov.c (function_summary): Remove argument. + (file_summary): New function. + (print_usage): Replace tabs with spaces. + (generate_results): Use new function file_summary. + 2019-02-05 Jakub Jelinek PR target/89186 diff --git a/gcc/gcov.c b/gcc/gcov.c index cb6bc7ef85f..9e27a826ea4 100644 --- a/gcc/gcov.c +++ b/gcc/gcov.c @@ -615,7 +615,8 @@ static void find_exception_blocks (function_info *); static void add_branch_counts (coverage_info *, const arc_info *); static void add_line_counts (coverage_info *, function_info *); static void executed_summary (unsigned, unsigned); -static void function_summary (const coverage_info *, const char *); +static void function_summary (const coverage_info *); +static void file_summary (const coverage_info *); static const char *format_gcov (gcov_type, gcov_type, int); static void accumulate_line_counts (source_info *); static void output_gcov_file (const char *, source_info *); @@ -886,7 +887,7 @@ print_usage (int error_p) fnotice (file, " -d, --display-progress Display progress information\n"); fnotice (file, " -f, --function-summaries Output summaries for each function\n"); fnotice (file, " -h, --help Print this help, then exit\n"); - fnotice (file, " -i, --json-format Output JSON intermediate format into .gcov.json.gz file\n"); + fnotice (file, " -i, --json-format Output JSON intermediate format into .gcov.json.gz file\n"); fnotice (file, " -j, --human-readable Output human readable numbers\n"); fnotice (file, " -k, --use-colors Emit colored output\n"); fnotice (file, " -l, --long-file-names Use long output file names for included\n\ @@ -1376,7 +1377,7 @@ generate_results (const char *file_name) add_line_counts (flag_function_summary ? &coverage : NULL, fn); if (flag_function_summary) { - function_summary (&coverage, "Function"); + function_summary (&coverage); fnotice (stdout, "\n"); } } @@ -1427,7 +1428,7 @@ generate_results (const char *file_name) accumulate_line_counts (src); if (!flag_use_stdout) - function_summary (&src->coverage, "File"); + file_summary (&src->coverage); total_lines += src->coverage.lines; total_executed += src->coverage.lines_executed; if (flag_gcov_file) @@ -2339,12 +2340,21 @@ executed_summary (unsigned lines, unsigned executed) fnotice (stdout, "No executable lines\n"); } -/* Output summary info for a function or file. */ +/* Output summary info for a function. */ static void -function_summary (const coverage_info *coverage, const char *title) +function_summary (const coverage_info *coverage) { - fnotice (stdout, "%s '%s'\n", title, coverage->name); + fnotice (stdout, "%s '%s'\n", "Function", coverage->name); + executed_summary (coverage->lines, coverage->lines_executed); +} + +/* Output summary info for a file. */ + +static void +file_summary (const coverage_info *coverage) +{ + fnotice (stdout, "%s '%s'\n", "File", coverage->name); executed_summary (coverage->lines, coverage->lines_executed); if (flag_branches) -- 2.30.2