From e4c2c34bf162df585e5cda5a65a9a066b178a8e7 Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Thu, 19 Aug 2004 09:01:50 +0100 Subject: [PATCH] re PR c++/17041 (Erroneous "suggest parentheses around assignment used as truth value" warning in template members.) PR c++/17041 * pt.c (tsubst_copy, tsubst_copy_and_build): Copy TREE_NO_WARNING from input for MODOP_EXPR. testsuite: * g++.dg/Wparentheses-3.C: New test. From-SVN: r86241 --- gcc/cp/ChangeLog | 6 ++++++ gcc/cp/pt.c | 13 +++++++++---- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/warn/Wparentheses-3.C | 13 +++++++++++++ 4 files changed, 33 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/g++.dg/warn/Wparentheses-3.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index eb271e5b2b6..5ce9af30f2a 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2004-08-19 Joseph S. Myers + + PR c++/17041 + * pt.c (tsubst_copy, tsubst_copy_and_build): Copy TREE_NO_WARNING + from input for MODOP_EXPR. + 2004-08-18 Mark Mitchell * pt.c (dependent_template_p): Fix typo in commment. diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c index 4107d1ca1c6..f4e9362ff1b 100644 --- a/gcc/cp/pt.c +++ b/gcc/cp/pt.c @@ -7667,6 +7667,7 @@ tsubst_copy (tree t, tree args, tsubst_flags_t complain, tree in_decl) (code, tsubst_copy (TREE_OPERAND (t, 0), args, complain, in_decl), tsubst_copy (TREE_OPERAND (t, 1), args, complain, in_decl), tsubst_copy (TREE_OPERAND (t, 2), args, complain, in_decl)); + TREE_NO_WARNING (r) = TREE_NO_WARNING (t); return r; } @@ -8331,10 +8332,14 @@ tsubst_copy_and_build (tree t, return cxx_sizeof_or_alignof_expr (op1, TREE_CODE (t)); case MODOP_EXPR: - return build_x_modify_expr - (RECUR (TREE_OPERAND (t, 0)), - TREE_CODE (TREE_OPERAND (t, 1)), - RECUR (TREE_OPERAND (t, 2))); + { + tree r = build_x_modify_expr + (RECUR (TREE_OPERAND (t, 0)), + TREE_CODE (TREE_OPERAND (t, 1)), + RECUR (TREE_OPERAND (t, 2))); + TREE_NO_WARNING (r) = TREE_NO_WARNING (t); + return r; + } case ARROW_EXPR: op1 = tsubst_non_call_postfix_expression (TREE_OPERAND (t, 0), diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 007f3dc36a2..02c9cc83f1a 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2004-08-19 Joseph S. Myers + + PR c++/17041 + * g++.dg/Wparentheses-3.C: New test. + 2004-08-19 Dorit Naishlos * gcc.dg/vect/vect-1.c: Remove xfail from i?86-*-* x86_64-*-* due diff --git a/gcc/testsuite/g++.dg/warn/Wparentheses-3.C b/gcc/testsuite/g++.dg/warn/Wparentheses-3.C new file mode 100644 index 00000000000..8781953b64a --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Wparentheses-3.C @@ -0,0 +1,13 @@ +// Test that -Wparentheses does not give bogus warnings in the +// presence of templates. Bug 17041. + +// { dg-do compile } +// { dg-options "-Wparentheses" } + +template struct A +{ + int i; + A() { if ((i = 0)) ; } +}; + +A<0> a; -- 2.30.2