From e4ca1d64565b4d665bcaf5d08922bfbe1d920e7a Mon Sep 17 00:00:00 2001 From: Neha Bhende Date: Mon, 22 Jan 2018 15:01:20 -0800 Subject: [PATCH] svga: Check rasterization state object before checking poly_stipple_enable Sometimes rasterization state object could be empty. This is causing segfault on hw8,9,10 for some traces. This patch fixes enemy_territory_quake_wars_high, enemy_territory_quake_wars_low, etqw-demo, lightsmark2008, quake1 glretrace crashes on hw 8,9,10. Tested with mtt-glretrace and mtt-piglit. Reviewed-by: Charmaine Lee Reviewed-by: Brian Paul --- src/gallium/drivers/svga/svga_state_tss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_state_tss.c b/src/gallium/drivers/svga/svga_state_tss.c index 63f3c8c8583..d598d23c4ea 100644 --- a/src/gallium/drivers/svga/svga_state_tss.c +++ b/src/gallium/drivers/svga/svga_state_tss.c @@ -256,7 +256,7 @@ svga_reemit_tss_bindings(struct svga_context *svga) } /* Polygon stipple */ - if (svga->curr.rast->templ.poly_stipple_enable) { + if (svga->curr.rast && svga->curr.rast->templ.poly_stipple_enable) { const unsigned unit = svga->state.hw_draw.fs->pstipple_sampler_unit; struct svga_hw_view_state *view = &svga->state.hw_draw.views[unit]; -- 2.30.2