From e671835b7afc90b3ff201b79f07a6fb67797bc5c Mon Sep 17 00:00:00 2001 From: Baruch Siach Date: Mon, 20 Jan 2014 09:53:12 +0200 Subject: [PATCH] gdb: xtensa: fix linux ptrace includes Currently, xtensa code using the Linux ptrace interface only include sys/ptrace.h. This file comes from the C library (glibc and uClibc, at least), and includes a declaration of the ptrace() functions, along with some cross architecture constants that are mostly copied from the file located at include/uapi/linux/ptrace.h in recent Linux kernels. For xtensa specific constants like PTRACE_GETXTREGS and PTRACE_SETXTREGS the asm/ptrace.h include from the Linux kernel UAPI is needed. The code in gdbserver xtensa specific part doesn't call ptrace() directly, so we can remove the unneeded sys/ptrace.h include. The gdb xtensa specific code needs both headers, since it calls ptrace(). gdb/ * xtensa-linux-nat.c: Include asm/ptrace.h. gdb/gdbserver/ * linux-xtensa-low.c: Include asm/ptrace.h instead of sys/ptrace.h. --- gdb/ChangeLog | 4 ++++ gdb/gdbserver/ChangeLog | 5 +++++ gdb/gdbserver/linux-xtensa-low.c | 2 +- gdb/xtensa-linux-nat.c | 1 + 4 files changed, 11 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8671d4fdbea..78ee32918b1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2014-01-20 Baruch Siach + + * xtensa-linux-nat.c: Include asm/ptrace.h. + 2014-01-17 Iain Buclaw * Makefile.in (SFILES): Add d-support.c. diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 7eb9e60dfdc..1deea578a6b 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,8 @@ +2014-01-20 Baruch Siach + + * linux-xtensa-low.c: Include asm/ptrace.h instead of + sys/ptrace.h. + 2014-01-17 Pedro Alves PR build/16445 diff --git a/gdb/gdbserver/linux-xtensa-low.c b/gdb/gdbserver/linux-xtensa-low.c index 7db97a9cc54..479b65b26b0 100644 --- a/gdb/gdbserver/linux-xtensa-low.c +++ b/gdb/gdbserver/linux-xtensa-low.c @@ -24,7 +24,7 @@ void init_registers_xtensa (void); extern const struct target_desc *tdesc_xtensa; -#include +#include #include #include "xtensa-xtregs.c" diff --git a/gdb/xtensa-linux-nat.c b/gdb/xtensa-linux-nat.c index 2372e792f3f..9340c62fe85 100644 --- a/gdb/xtensa-linux-nat.c +++ b/gdb/xtensa-linux-nat.c @@ -36,6 +36,7 @@ #include #include #include +#include #include "gregset.h" #include "xtensa-tdep.h" -- 2.30.2