From e714001c7896d90413e2eee13acb56bdd9639abe Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Tue, 31 Jan 2023 07:41:09 -0700 Subject: [PATCH] Move ~value body out-of-line struct value is going to move to value.h, but to avoid having excessive code there, first move the destructor body out-of-line. Approved-By: Simon Marchi --- gdb/value.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/gdb/value.c b/gdb/value.c index 7606fa2666f..be981b1d3a0 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -191,18 +191,7 @@ struct value { } - ~value () - { - if (VALUE_LVAL (this) == lval_computed) - { - const struct lval_funcs *funcs = m_location.computed.funcs; - - if (funcs->free_closure) - funcs->free_closure (this); - } - else if (VALUE_LVAL (this) == lval_xcallable) - delete m_location.xm_worker; - } + ~value (); DISABLE_COPY_AND_ASSIGN (value); @@ -383,6 +372,19 @@ struct value ULONGEST m_limited_length = 0; }; +value::~value () +{ + if (VALUE_LVAL (this) == lval_computed) + { + const struct lval_funcs *funcs = m_location.computed.funcs; + + if (funcs->free_closure) + funcs->free_closure (this); + } + else if (VALUE_LVAL (this) == lval_xcallable) + delete m_location.xm_worker; +} + /* See value.h. */ struct gdbarch * -- 2.30.2