From e71dbd03045836f8a604ccc2ac709823479110cc Mon Sep 17 00:00:00 2001 From: Markus Metzger Date: Tue, 15 Dec 2020 12:46:58 +0100 Subject: [PATCH] testsuite, gdb.btrace: remove assembly-check in delta.exp In gdb.btrace/delta.exp, we test that we do not extend the trace unintentionally. This can be tested by checking the number of instructions. If we wanted to check the instruction history, as well, we'd need to work on an assembly file to have deterministic behaviour. This isn't really necessary for this test, however, and covered elsewhere. Also remove the function call history check for the same reason. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.btrace/delta.exp | 9 +-------- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 9bc6995aa87..1f0941e13e1 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2021-03-03 Markus Metzger + + * gdb.btrace/delta.exp: Remove instruction-history and + function-call-history checks. + 2021-03-03 Markus Metzger * README (Note): Add nopie_ldflag. diff --git a/gdb/testsuite/gdb.btrace/delta.exp b/gdb/testsuite/gdb.btrace/delta.exp index 9f6d741c013..0d61e9aa54e 100644 --- a/gdb/testsuite/gdb.btrace/delta.exp +++ b/gdb/testsuite/gdb.btrace/delta.exp @@ -58,9 +58,6 @@ proc check_trace {} { "Recording format: .*" \ "Recorded 1 instructions in 1 functions \\\(0 gaps\\\) for .*" \ ] - gdb_test "record instruction-history /f 1" \ - "1\t 0x\[0-9a-f\]+ <\\+\[0-9\]+>:\tmov *\\\$0x0,%eax\r" - gdb_test "record function-call-history /c 1" "1\tmain" } # make sure we don't extend the trace when we ask twice. @@ -86,9 +83,5 @@ with_test_prefix "reverse" { # and back with_test_prefix "forward" { gdb_test "stepi" - gdb_test "info record" [multi_line \ - "Active record target: record-btrace" \ - "Recording format: .*" \ - "Recorded 1 instructions in 1 functions \\\(0 gaps\\\) for .*" \ - ] + check_trace } -- 2.30.2