From e729c8e003707934687e0da85e4b151a553a28d9 Mon Sep 17 00:00:00 2001 From: Richard Biener Date: Thu, 14 Dec 2017 11:12:52 +0000 Subject: [PATCH] re PR tree-optimization/83418 (ICE in extract_range_for_var_from_comparison_expr, at vr-values.c:448) 2017-12-14 Richard Biener PR tree-optimization/83418 * vr-values.c (vr_values::extract_range_for_var_from_comparison_expr): Instead of asserting we don't get unfolded comparisons deal with them. * gcc.dg/torture/pr83418.c: New testcase. From-SVN: r255628 --- gcc/ChangeLog | 7 +++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/torture/pr83418.c | 17 +++++++++++++++++ gcc/vr-values.c | 7 ++++--- 4 files changed, 33 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/torture/pr83418.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 504b331ec8a..d18230841f4 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2017-12-14 Richard Biener + + PR tree-optimization/83418 + * vr-values.c (vr_values::extract_range_for_var_from_comparison_expr): + Instead of asserting we don't get unfolded comparisons deal with + them. + 2017-12-14 Jakub Jelinek PR bootstrap/83396 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index ff3747961b5..811568e7d2a 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2017-12-14 Richard Biener + + PR tree-optimization/83418 + * gcc.dg/torture/pr83418.c: New testcase. + 2017-12-14 Jakub Jelinek PR bootstrap/83396 diff --git a/gcc/testsuite/gcc.dg/torture/pr83418.c b/gcc/testsuite/gcc.dg/torture/pr83418.c new file mode 100644 index 00000000000..b545a39a803 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr83418.c @@ -0,0 +1,17 @@ +/* { dg-do compile } */ + +void +yj (int j4) +{ + int t3; + + for (t3 = 0; t3 < 6; ++t3) + { + short int v4 = t3; + + if (v4 == j4 || v4 > t3) + for (;;) + { + } + } +} diff --git a/gcc/vr-values.c b/gcc/vr-values.c index 9352e120d9d..794b4635f9e 100644 --- a/gcc/vr-values.c +++ b/gcc/vr-values.c @@ -445,11 +445,12 @@ vr_values::extract_range_for_var_from_comparison_expr (tree var, tree min, max, type; value_range *limit_vr; type = TREE_TYPE (var); - gcc_assert (limit != var); /* For pointer arithmetic, we only keep track of pointer equality - and inequality. */ - if (POINTER_TYPE_P (type) && cond_code != NE_EXPR && cond_code != EQ_EXPR) + and inequality. If we arrive here with unfolded conditions like + _1 > _1 do not derive anything. */ + if ((POINTER_TYPE_P (type) && cond_code != NE_EXPR && cond_code != EQ_EXPR) + || limit == var) { set_value_range_to_varying (vr_p); return; -- 2.30.2