From e8b6c1da565c93f015d93a4f8554830118e9bd07 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Mon, 26 Apr 2021 09:53:32 -0600 Subject: [PATCH] Add test case for gdb 10 crash PR gdb/27743 points out a gdb crash when expanding partial symtabs, where one of the compilation units uses DW_TAG_imported_unit. This crash happens for gdb 10, but not git trunk. This patch pulls over the new test case only. gdb/testsuite/ChangeLog 2021-04-26 Tom Tromey PR gdb/27743: * gdb.dwarf2/imported-unit-bp.exp: New file. * gdb.dwarf2/imported-unit-bp-main.c: New file. * gdb.dwarf2/imported-unit-bp-alt.c: New file. --- gdb/testsuite/ChangeLog | 7 + .../gdb.dwarf2/imported-unit-bp-alt.c | 50 +++++++ .../gdb.dwarf2/imported-unit-bp-main.c | 24 ++++ gdb/testsuite/gdb.dwarf2/imported-unit-bp.exp | 128 ++++++++++++++++++ 4 files changed, 209 insertions(+) create mode 100644 gdb/testsuite/gdb.dwarf2/imported-unit-bp-alt.c create mode 100644 gdb/testsuite/gdb.dwarf2/imported-unit-bp-main.c create mode 100644 gdb/testsuite/gdb.dwarf2/imported-unit-bp.exp diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 8c4e34728b4..45bca311a39 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2021-04-26 Tom Tromey + + PR gdb/27743: + * gdb.dwarf2/imported-unit-bp.exp: New file. + * gdb.dwarf2/imported-unit-bp-main.c: New file. + * gdb.dwarf2/imported-unit-bp-alt.c: New file. + 2021-04-26 Simon Marchi PR gdb/27773 diff --git a/gdb/testsuite/gdb.dwarf2/imported-unit-bp-alt.c b/gdb/testsuite/gdb.dwarf2/imported-unit-bp-alt.c new file mode 100644 index 00000000000..0785e0a344e --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/imported-unit-bp-alt.c @@ -0,0 +1,50 @@ +/* Copyright 2020-2021 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +/* Used to insert labels with which we can build a fake line table. */ +#define LL(N) asm ("line_label_" #N ": .globl line_label_" #N) + +volatile int var; +volatile int bar; + +/* Generate some code to take up some space. */ +#define FILLER do { \ + var = 99; \ +} while (0) + +int +func (void) +{ /* func prologue */ + asm ("func_label: .globl func_label"); + LL (1); // F1, Ln 16 + FILLER; + LL (2); // F1, Ln 17 + FILLER; + LL (3); // F2, Ln 21 + FILLER; + LL (4); // F2, Ln 22 // F1, Ln 18, !S + FILLER; + LL (5); // F1, Ln 19 !S + FILLER; + LL (6); // F1, Ln 20 + FILLER; + LL (7); + FILLER; + return 0; /* func end */ +} + +#ifdef WITHMAIN +int main () { return 0; } +#endif diff --git a/gdb/testsuite/gdb.dwarf2/imported-unit-bp-main.c b/gdb/testsuite/gdb.dwarf2/imported-unit-bp-main.c new file mode 100644 index 00000000000..e355582b358 --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/imported-unit-bp-main.c @@ -0,0 +1,24 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2004-2021 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +extern int func (void); + +int +main() +{ + return func (); +} diff --git a/gdb/testsuite/gdb.dwarf2/imported-unit-bp.exp b/gdb/testsuite/gdb.dwarf2/imported-unit-bp.exp new file mode 100644 index 00000000000..b6a0f25d2ce --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/imported-unit-bp.exp @@ -0,0 +1,128 @@ +# Copyright 2020-2021 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test that "break /absolute/file:line" works ok with imported CUs. + +load_lib dwarf.exp + +# This test can only be run on targets which support DWARF-2 and use gas. +if {![dwarf2_support]} { + return 0 +} + +# The .c files use __attribute__. +if [get_compiler_info] { + return -1 +} +if !$gcc_compiled { + return 0 +} + +standard_testfile imported-unit-bp-alt.c .S imported-unit-bp-main.c + +set build_options {nodebug optimize=-O1} + +set asm_file [standard_output_file $srcfile2] +Dwarf::assemble $asm_file { + global srcdir subdir srcfile srcfile + global build_options + declare_labels lines_label callee_subprog_label cu_label + + get_func_info func "$build_options additional_flags=-DWITHMAIN" + + cu {} { + compile_unit { + {language @DW_LANG_C} + {name ""} + } { + imported_unit { + {import %$cu_label} + } + } + } + + cu {} { + cu_label: compile_unit { + {producer "gcc"} + {language @DW_LANG_C} + {name ${srcfile}} + {comp_dir "/tmp"} + {low_pc 0 addr} + {stmt_list ${lines_label} DW_FORM_sec_offset} + } { + callee_subprog_label: subprogram { + {external 1 flag} + {name callee} + {inline 3 data1} + } + subprogram { + {external 1 flag} + {name func} + {low_pc $func_start addr} + {high_pc "$func_start + $func_len" addr} + } { + } + } + } + + lines {version 2 default_is_stmt 1} lines_label { + include_dir "/tmp" + file_name "$srcfile" 1 + + program { + {DW_LNE_set_address line_label_1} + {DW_LNS_advance_line 15} + {DW_LNS_copy} + + {DW_LNE_set_address line_label_2} + {DW_LNS_advance_line 1} + {DW_LNS_copy} + + {DW_LNE_set_address line_label_3} + {DW_LNS_advance_line 4} + {DW_LNS_copy} + + {DW_LNE_set_address line_label_4} + {DW_LNS_advance_line 1} + {DW_LNS_copy} + + {DW_LNS_advance_line -4} + {DW_LNS_negate_stmt} + {DW_LNS_copy} + + {DW_LNE_set_address line_label_5} + {DW_LNS_advance_line 1} + {DW_LNS_copy} + + {DW_LNE_set_address line_label_6} + {DW_LNS_advance_line 1} + {DW_LNS_negate_stmt} + {DW_LNS_copy} + + {DW_LNE_set_address line_label_7} + {DW_LNE_end_sequence} + } + } +} + +if { [prepare_for_testing "failed to prepare" ${testfile} \ + [list $srcfile $asm_file $srcfile3] $build_options] } { + return -1 +} + +gdb_reinitialize_dir /tmp + +# Using an absolute path is important to see the bug. +gdb_test "break /tmp/${srcfile}:19" "Breakpoint .* file $srcfile, line .*" -- 2.30.2