From e8ea2809d0dd85f1a235ba868897da51b79fca64 Mon Sep 17 00:00:00 2001 From: Richard Kenner Date: Mon, 12 Mar 2001 19:09:57 +0000 Subject: [PATCH] flow.c (insn_dead_p): Don't consider two memrefs equivalent unless anti_dependence says they are. * flow.c (insn_dead_p): Don't consider two memrefs equivalent unless anti_dependence says they are. * alias.c (objects_must_conflict): If neither has a type specified, they must conflict. From-SVN: r40420 --- gcc/ChangeLog | 7 +++++++ gcc/alias.c | 6 ++++++ gcc/flow.c | 37 +++++++++++++++++++------------------ 3 files changed, 32 insertions(+), 18 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index ebbcd041ce4..ea73863cfbe 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +Mon Mar 12 14:05:32 2001 Richard Kenner + + * flow.c (insn_dead_p): Don't consider two memrefs equivalent + unless anti_dependence says they are. + * alias.c (objects_must_conflict): If neither has a type specified, + they must conflict. + 2001-03-12 Neil Booth David Billinghurst diff --git a/gcc/alias.c b/gcc/alias.c index 85bce38c70f..6d794ba98c5 100644 --- a/gcc/alias.c +++ b/gcc/alias.c @@ -309,6 +309,12 @@ int objects_must_conflict_p (t1, t2) tree t1, t2; { + /* If neither has a type specified, we don't know if they'll conflict + because we may be using them to store objects of various types, for + example the argument and local variables areas of inlined functions. */ + if (t1 == 0 && t1 == 0) + return 0; + /* If one or the other has readonly fields or is readonly, then they may not conflict. */ if ((t1 != 0 && readonly_fields_p (t1)) diff --git a/gcc/flow.c b/gcc/flow.c index 82e90174063..819765523a2 100644 --- a/gcc/flow.c +++ b/gcc/flow.c @@ -4420,27 +4420,28 @@ insn_dead_p (pbi, x, call_ok, notes) /* Walk the set of memory locations we are currently tracking and see if one is an identical match to this memory location. If so, this memory write is dead (remember, we're walking - backwards from the end of the block to the start). */ - temp = pbi->mem_set_list; - while (temp) - { - rtx mem = XEXP (temp, 0); + backwards from the end of the block to the start). Since + rtx_equal_p does not check the alias set or flags, we also + must have the potential for them to conflict (anti_dependence). */ + for (temp = pbi->mem_set_list; temp != 0; temp = XEXP (temp, 1)) + if (anti_dependence (r, XEXP (temp, 0))) + { + rtx mem = XEXP (temp, 0); - if (rtx_equal_p (mem, r)) - return 1; + if (rtx_equal_p (mem, r)) + return 1; #ifdef AUTO_INC_DEC - /* Check if memory reference matches an auto increment. Only - post increment/decrement or modify are valid. */ - if (GET_MODE (mem) == GET_MODE (r) - && (GET_CODE (XEXP (mem, 0)) == POST_DEC - || GET_CODE (XEXP (mem, 0)) == POST_INC - || GET_CODE (XEXP (mem, 0)) == POST_MODIFY) - && GET_MODE (XEXP (mem, 0)) == GET_MODE (r) - && rtx_equal_p (XEXP (XEXP (mem, 0), 0), XEXP (r, 0))) - return 1; + /* Check if memory reference matches an auto increment. Only + post increment/decrement or modify are valid. */ + if (GET_MODE (mem) == GET_MODE (r) + && (GET_CODE (XEXP (mem, 0)) == POST_DEC + || GET_CODE (XEXP (mem, 0)) == POST_INC + || GET_CODE (XEXP (mem, 0)) == POST_MODIFY) + && GET_MODE (XEXP (mem, 0)) == GET_MODE (r) + && rtx_equal_p (XEXP (XEXP (mem, 0), 0), XEXP (r, 0))) + return 1; #endif - temp = XEXP (temp, 1); - } + } } else { -- 2.30.2