From e920c014ecd9fbb630c76576d2771aa4631d93f7 Mon Sep 17 00:00:00 2001 From: "Jose E. Marchesi" Date: Tue, 4 Sep 2018 20:19:06 +0200 Subject: [PATCH] bfd, sparc: avoid duplicated error messages on invalid relocations. This patch avoids a duplicated error message when an invalid relocation number is read from an object file in sparc-* ELF targets: $ strip -g test.o strip: test.o: unsupported relocation type 0xd7 strip: test.o: unsupported relocation type 0xd7 strip: test.o: bad value Tested in x86_64-linux-gnu, sparc64-linux-gnu and sparc-linux-gnu targets. bfd/ChangeLog: 2018-09-04 Jose E. Marchesi * elfxx-sparc.c (_bfd_sparc_elf_info_to_howto): Do not issue an error when an invalid relocation is passed; this is already done by `_bfd_sparc_elf_info_to_howto_ptr'. --- bfd/ChangeLog | 6 ++++++ bfd/elfxx-sparc.c | 2 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 22837e0f0e8..bc1cb15a8f9 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2018-09-04 Jose E. Marchesi + + * elfxx-sparc.c (_bfd_sparc_elf_info_to_howto): Do not issue an + error when an invalid relocation is passed; this is already done + by `_bfd_sparc_elf_info_to_howto_ptr'. + 2018-09-04 Jose E. Marchesi * elf64-sparc.c (elf64_sparc_slurp_one_reloc_table): Issue an diff --git a/bfd/elfxx-sparc.c b/bfd/elfxx-sparc.c index 81812afc5a4..bf143c400f4 100644 --- a/bfd/elfxx-sparc.c +++ b/bfd/elfxx-sparc.c @@ -658,8 +658,6 @@ _bfd_sparc_elf_info_to_howto (bfd *abfd, arelent *cache_ptr, if ((cache_ptr->howto = _bfd_sparc_elf_info_to_howto_ptr (abfd, r_type)) == NULL) { - _bfd_error_handler (_("%pB: unsupported relocation type %#x"), - abfd, r_type); bfd_set_error (bfd_error_bad_value); return FALSE; } -- 2.30.2