From e98a23bfb3088fb129540d7fd26f3205e2de6f2a Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Wed, 22 Feb 2023 15:21:45 -0700 Subject: [PATCH] Remove 'eval' from gdb_breakpoint Now that Tcl has the {*} operator, we can remove the use of eval from gdb_breakpoint. Tested on x86-64 Fedora 36. --- gdb/testsuite/lib/gdb.exp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 6864dac3ac9..66a5d31d9ad 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -704,12 +704,7 @@ proc runto { linespec args } { set test_name "runto: run to $linespec" - # We need to use eval here to pass our varargs args to gdb_breakpoint - # which is also a varargs function. - # But we also have to be careful because $linespec may have multiple - # elements, and we don't want Tcl to move the remaining elements after - # the first to $args. That is why $linespec is wrapped in {}. - if ![eval gdb_breakpoint {$linespec} $args] { + if {![gdb_breakpoint $linespec {*}$args]} { return 0 } -- 2.30.2